Improve Close Thumb Animation Tab Grid |
||||||||
Issue descriptionUsing the current implementation as a reference, the improved implementation should be: - Don't animate Y offset. - Use the thumbnail X, Y center as the origin, to which the animation scales to 0. - Send closing thumbnail to back, to be behind all other thumbnails. - Increase the time spent easing out the reposition animation by 50ms. This gives you a direction, but we should probably tweak these in person.
,
Jun 12 2018
,
Jun 12 2018
,
Jun 12 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd6e2add0131984d9bc9d3cf7ad296c652a1e033 commit bd6e2add0131984d9bc9d3cf7ad296c652a1e033 Author: Mark Cogan <marq@google.com> Date: Wed Jun 13 15:43:19 2018 [iOS] Tweak tab grid item delete animation. This CL updates the tab grid item delete animation to scale down further and not translate. It also adds a z-index change, which (so far) isn't honored by the collection view. Bug: 851458 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7cec788adb61d6a56243941b1c7032fd16f9ed8b Reviewed-on: https://chromium-review.googlesource.com/1098960 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566843} [modify] https://crrev.com/bd6e2add0131984d9bc9d3cf7ad296c652a1e033/ios/chrome/browser/ui/tab_grid/grid/grid_layout.mm
,
Jul 10
,
Jul 19
Moving this to P2; I haven't been able to accomplish the z-layering change using the collection view APIs. Pete/Martijn -- Let me know if you feel this is a must-have.
,
Jul 19
Would be nice to have the z-index thing but I don't think it is a must-have.
,
Aug 8
Resurfacing as animation polish for M-70
,
Aug 22
And submerging this again; working around the collection view bugs that make this not work is fairly painful. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by marq@chromium.org
, Jun 12 2018