New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 851457 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 850011
Owner:
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

pointer events missing when using active stylus with eraser button pressed

Reported by steven.o...@gmail.com, Jun 11 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.79 Safari/537.36

Steps to reproduce the problem:
(logging all pointer events)
1. Place stylus on page holding the eraser button
2. Lift stylus
3. Multiple pointer events were not fired: pointerdown, gotpointercapture, pointerup, lostpointercapture

What is the expected behavior?
Expecting all pointerevents with correct button & buttons values as described here for eraser button
https://www.w3.org/TR/pointerevents/

What went wrong?
Multiple pointer events were not fired

Did this work before? Yes v. 66.0.3359.0

Does this work in other browsers? N/A

Chrome version: 67.0.3396.79  Channel: stable
OS Version: 10.0
Flash Version: 

Possibly related: https://bugs.chromium.org/p/chromium/issues/detail?id=850011
Reproducible on MS Surface Pro 4 with stylus and generic touch display with active pen
 
eraserpointermissing.PNG
4.6 KB View Download
pointerevent.html
538 bytes View Download
Labels: Needs-Bisect Needs-Triage-M67
Cc: krajshree@chromium.org
Labels: Triaged-ET Needs-Feedback
Unable to reproduce the issue on Win-10 surface pro using chrome reported version #67.0.3396.79 and latest canary #69.0.3455.0.

Attached a screen cast for reference.

Following are the steps followed to reproduce the issue.
------------
1. Opened the attached file "pointerevent.html "
2. Placed stylus on page holding the eraser button.
2. Lifted stylus.
3. Multiple pointer events were fired: pointerdown, gotpointercapture, pointerup, lostpointercapture as expected.

steven.oeyen@ - Could you please check the attached screen cast and please let us know if anything missed from our end. Also please check the issue on latest canary #69.0.3455.0 by creating a new profile without any apps and extensions and please let us know if the issue still persist or not.

Thanks...!!
851457.mp4
1.3 MB View Download
Hi, in the screen cast it seems the "right mouse" button is being pressed.
The eraser button on the MS Surface Pro Stylus is the back of the Stylus, not the button on the side.
Placing the back of the stylus on the screen does not trigger all pointer events. I've also tested with a generic pen on another touch display, behavior is the same.
I will get back to you on canary #69.0.3455.0
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 12 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I can confirm the issue persists on canary #69.0.3455.0
Labels: -Needs-Bisect
Mergedinto: 850011
Status: Duplicate (was: Unconfirmed)
The issue looks similar to issue id: 850011. Hence, merging into issue id: 850011.

Thanks...!!
Cc: nzolghadr@chromium.org
Owner: lanwei@chromium.org
Status: Assigned (was: Duplicate)
Labels: Needs-Feedback
Could you tell us what stylus you use? Is it the same for external stylus or only surface stylus?
Can you provide the results and the list of actions you do in text please? Like the actual output and expected output after each action. That would be great if you can also provide the button and buttons value of those events you are printing.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7b13da0ce3c2a57eae58499b1e8c13e8432baa7

commit a7b13da0ce3c2a57eae58499b1e8c13e8432baa7
Author: lanwei <lanwei@chromium.org>
Date: Mon Jul 16 19:33:10 2018

Make sure that the corresponding pointer events are sent when pressing
eraser button

When we press an eraser button of a stylus, we should send the missing
pointerdown, pointerup, gotpointercapture and lostpointercapture events.

Bug:  851457 
Change-Id: Iff45a897a87ef03d73cc308d84e874dbc1310fa1
Reviewed-on: https://chromium-review.googlesource.com/1129619
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575384}
[modify] https://crrev.com/a7b13da0ce3c2a57eae58499b1e8c13e8432baa7/third_party/blink/renderer/core/events/pointer_event_factory.cc
[modify] https://crrev.com/a7b13da0ce3c2a57eae58499b1e8c13e8432baa7/third_party/blink/renderer/core/events/pointer_event_factory_test.cc
[modify] https://crrev.com/a7b13da0ce3c2a57eae58499b1e8c13e8432baa7/ui/views/win/pen_event_processor.cc
[modify] https://crrev.com/a7b13da0ce3c2a57eae58499b1e8c13e8432baa7/ui/views/win/pen_event_processor.h
[modify] https://crrev.com/a7b13da0ce3c2a57eae58499b1e8c13e8432baa7/ui/views/win/pen_event_processor_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment