Regression:Cookies and site data doesn't appear after clicking on back button.
Reported by
vku...@etouch.net,
Jun 11 2018
|
||||||||
Issue descriptionChrome Version: 69.0.3453.0 (Official Build) Revision 67baaec3f00fba7d0a5b1041fca4e28b16ac5e55-refs/branch-heads/3453@{#1} (32/64-bit) OS:Windows (7,8,8.1,10),Mac OS X(10.12.6,10.13.1,10.13.6) & Linux (14.04 LTS) Precondition: Login into browser with credentials which has long cookies data OR create cookies by navigating to multiple sites. What steps will reproduce the problem? (1)Launch chrome and navigate to chrome://settings/content > cookies (2)Click on "See all cookies and site data" button, scroll at bottom of page and click on any cookie. (3)Now click on back button of cookies page and observe the contents. Actual: Cookies and site data doesn't appear after clicking on back button(i.e after step 2&3) Expected: Cookies and site data should be properly displayed after clicking on back button. This is a regression issue broken in 'M68' and below is the bisect info Good Build: 68.0.3425.0(Revision:557063) Bad Build: 68.0.3427.0(Revision:557758) (Unable to narrow down the range using per-revision bisect,hence providing bisect using old script) Narrow Bisect info: You are probably looking for a change made after 562149 (known good), but no later than 562150 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/56205ade5fedcee73206c6f7ebc9d1cb33763cd6..894c79630192ac3b94dccebb5dfab3a473385aa5?pretty=fuller&n=50 Suspecting: r557337 ? @aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Jun 11 2018
,
Jun 18 2018
Friendly ping to get an update as stable release is coming soon and this bug is marked as RBS for M68. Thanks..!
,
Jun 18 2018
I have a proposed fix here https://chromium-review.googlesource.com/c/chromium/src/+/1096351 I am working on getting the CL approved and merged by end of day. Once complete, I'll add a merge request tag for M68.
,
Jun 18 2018
Creating https://bugs.chromium.org/p/chromium/issues/detail?id=853906 so a better fix can be investigated.
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60f40c35649f205c51aa5a8669d110c5344e689d commit 60f40c35649f205c51aa5a8669d110c5344e689d Author: Esmael El-Moslimany <aee@chromium.org> Date: Tue Jun 19 00:30:50 2018 Settings: workaround iron-list rendering issue by clearing sites on route change Bug: 851431 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib81a7c7bc9cd2177919702c078b140e6a0b39281 Reviewed-on: https://chromium-review.googlesource.com/1096351 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568258} [modify] https://crrev.com/60f40c35649f205c51aa5a8669d110c5344e689d/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/60f40c35649f205c51aa5a8669d110c5344e689d/chrome/browser/resources/settings/site_settings/site_data.js
,
Jun 19 2018
,
Jun 19 2018
How safe is this merge? Has this been verified in canary yet?
,
Jun 19 2018
It's a very safe and small change. It's not in canary yet. I'll verify the fix when it is available.
,
Jun 20 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 20 2018
I've confirmed that the change is working in the latest canary on Mac. chrome://version Google Chrome 69.0.3466.0 (Official Build) canary (64-bit) Revision 7a22a4a62948746c970b84f31b1f78cd2cb3a1c2-refs/branch-heads/3466@{#1} OS Mac OS X
,
Jun 20 2018
,
Jun 21 2018
Approved - branch:3440
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d635e4a35792cd8551ae1ce2987c78e45ddced7 commit 0d635e4a35792cd8551ae1ce2987c78e45ddced7 Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Jun 22 17:25:19 2018 Settings: workaround iron-list rendering issue by clearing sites on route change Bug: 851431 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib81a7c7bc9cd2177919702c078b140e6a0b39281 Reviewed-on: https://chromium-review.googlesource.com/1096351 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#568258}(cherry picked from commit 60f40c35649f205c51aa5a8669d110c5344e689d) Reviewed-on: https://chromium-review.googlesource.com/1112357 Cr-Commit-Position: refs/branch-heads/3440@{#495} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/0d635e4a35792cd8551ae1ce2987c78e45ddced7/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/0d635e4a35792cd8551ae1ce2987c78e45ddced7/chrome/browser/resources/settings/site_settings/site_data.js
,
Jun 27 2018
Update: Rechecked the above issue on Win(7,8,8.1,10) and Linux(14.04 LTS)OS using latest Beta build #68.0.3440.42 and issue is fixed. Please refer attached screen cast for reference. Thank You. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rbasuvula@chromium.org
, Jun 11 2018Labels: ReleaseBlock-Stable