New issue
Advanced search Search tips

Issue 851417 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Reenable GeometryMapperTest.NestedTransformsIntermediateDestination on Android

Project Member Reported by altimin@chromium.org, Jun 11 2018 
Test GeometryMapperTest.NestedTransformsIntermediateDestination failed and was disabled when blink_platform_unittests were reenabled on Android[1].

Assigning to wangxianzhu@ for triage based on the history.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1088913
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75a75e522ef1b0b829ef89c29568568609e2c2cb

commit 75a75e522ef1b0b829ef89c29568568609e2c2cb
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Jun 13 21:08:07 2018

[PE] Deflake GeometryMapperTest.NestedTransformsIntermediateDestination

The flakiness was caused by the rotation above the tested transform.
There were tiny errors when mapping back and forth the rotation.
Now change it to a translation. Also change |scale_transform| to a
real scale.

Re-enable it on Android.

Bug:  851417 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I01b81fd47bdc09f6aeee021c4c334d9f06be3413
Reviewed-on: https://chromium-review.googlesource.com/1099595
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566985}
[modify] https://crrev.com/75a75e522ef1b0b829ef89c29568568609e2c2cb/third_party/blink/renderer/platform/graphics/paint/geometry_mapper_test.cc

Comment 2 by wangxianzhu@chromium.org, Jun 13 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment