Border for table cells rendered on prior page on print
Reported by
thong.k...@crssoftware.co.nz,
Jun 11 2018
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.79 Safari/537.36 Example URL: Steps to reproduce the problem: When printing, the border for a table cell is sometimes rendered on the prior page *and* the page the cell is on. What is the expected behavior? That borders from table cells stay on the page where the table cell is. What went wrong? See the extra green line on the bottom of page 1 on the printed PDF, which should not be there. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? N/A Chrome version: 67.0.3396.79 Channel: stable OS Version: OS X 10.13.5 Flash Version:
,
Jun 11 2018
,
Jun 12 2018
,
Jun 12 2018
,
Jun 12 2018
Confirmed on linux 67.0.3396.79 The border is not actually duplicated, we just start painting the top part of the second page's top border on the first page, for some reason.
,
Jun 13 2018
Able to reproduce the issue on the reported chrome 67.0.3396.79,latest chrome 69.0.3456.0 using Windows10,Mac OS 10.13.5 ,Ubuntu14.04. Below is the bisect information for same. Bisect Info: ================ Good build: 61.0.3137.0 Bad build: 61.0.3138.0 You are probably looking for a change made after 481330 (known good), but no later than 481331 (first known bad). CHANGELOG URL:https://chromium.googlesource.com/chromium/src/+log/08a57486698031c8dc183e77503d8a54f8987ec8..0c1f73a50ab7c31c987decaba4abb5e3cbe8e286 Suspect: https://chromium.googlesource.com/chromium/src/+/0c1f73a50ab7c31c987decaba4abb5e3cbe8e286 Reviewed-on: https://chromium-review.googlesource.com/528561 wangxianzhu:Please confirm the issue and help in re-assigning if it is not related to your change. Thanks!
,
Jun 13 2018
The issue occurred with my CL which changed painting, but the root cause is actually a layout issue. For the page-braking TR, the table layout system doesn't give enough strut to the TR, causing the collapsed border to cross the page boundary. The current collapsed border painting just correctly follows the layout data to paint the collapsed border. Before the CL, the top half of the collapsed border was lost. With correct strut, the whole collapsed border will be painted on the second page. Lowering priority because the root cause is really old.
,
Jun 13 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/881a8dd02d18b4817b0e397763fff8d56dec8915 commit 881a8dd02d18b4817b0e397763fff8d56dec8915 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Jun 13 21:39:45 2018 [PE] Put whole collapsed borders of page-breaking row on the next fragment Bug: 851412 Change-Id: Id9177b63eee4c0d6f1a438c682951f5105f25823 Reviewed-on: https://chromium-review.googlesource.com/1099355 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566997} [modify] https://crrev.com/881a8dd02d18b4817b0e397763fff8d56dec8915/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/881a8dd02d18b4817b0e397763fff8d56dec8915/third_party/WebKit/LayoutTests/fragmentation/table-row-page-break-collapsed-border-expected.html [add] https://crrev.com/881a8dd02d18b4817b0e397763fff8d56dec8915/third_party/WebKit/LayoutTests/fragmentation/table-row-page-break-collapsed-border.html [modify] https://crrev.com/881a8dd02d18b4817b0e397763fff8d56dec8915/third_party/blink/renderer/core/layout/layout_table_section.cc
,
Jul 3
Unable to verify fix on the latest Canary 69.0.3480.0 as issue still persists on Windows 10, Mac OS 10.13.5 and Ubuntu 17.10 by following the below steps. 1. Download the page-break-inside-avoid-border.html 2. Try to print 3. A green extra line is observed at the bottom of first page Attached is the screen cast for reference. Thanks.. @Xianzhu Wang : please find the attached screen cast and help us in confirming the issue
,
Jul 3
It seems broken again.
,
Oct 9
The remaining issue is about subpixel layout, so is less severe, and may depend on bug 377847. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by dtapu...@chromium.org
, Jun 11 2018