New issue
Advanced search Search tips

Issue 851399 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Investigate detached resource request failures

Project Member Reported by lizeb@chromium.org, Jun 11 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e4d618d4238f2f9e640e47982476d1a2b6449d3

commit 7e4d618d4238f2f9e640e47982476d1a2b6449d3
Author: Benoit Lize <lizeb@chromium.org>
Date: Mon Jun 11 13:09:51 2018

customtabs: report the correct value for a UMA histogram.

CustomTabs.DetachedResourceRequest.FinalStatus enum contains labels for
-net::ERR_*, not the direct value. This causes reporting in UMA to be
incorrectly labeled.

Bug:  816837 , 851399
Change-Id: I7febe0ec98f9ae7b028f36af9ff4a40cc938191d
Reviewed-on: https://chromium-review.googlesource.com/1095178
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565982}
[modify] https://crrev.com/7e4d618d4238f2f9e640e47982476d1a2b6449d3/chrome/browser/android/customtabs/detached_resource_request.cc
[modify] https://crrev.com/7e4d618d4238f2f9e640e47982476d1a2b6449d3/chrome/browser/android/customtabs/detached_resource_request_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c88d2db535f6c407afb185e8eb40edca2b10f13

commit 0c88d2db535f6c407afb185e8eb40edca2b10f13
Author: Benoit Lize <lizeb@chromium.org>
Date: Thu Jun 28 17:17:39 2018

android: Retry detached requests on network change.

Some detached requests fail because the network changes between
requests. Retry the request in this case, only once.

Bug: 851399
Change-Id: Ic77c28e5ac49fecaf634e4a225c8f443f75e2560
Reviewed-on: https://chromium-review.googlesource.com/1118262
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571173}
[modify] https://crrev.com/0c88d2db535f6c407afb185e8eb40edca2b10f13/chrome/browser/android/customtabs/detached_resource_request.cc

Cc: mard...@chromium.org
Labels: Merge-Request-68
Requesting a merge for the CL above (#2) to M68.

Apologies for the very late request, this is to unblock an experiment, and getting a reasonable amount of data requires the fix to propagate to Chrome Stable.

More context:
This is a fix for the "Accelerate redirected URLs in CCT (stage 2)" feature that launched in M67 (https://bugs.chromium.org/p/chromium/issues/detail?id=817854).

The initial launch was meant to allow external experiments of the feature. These experiments showed an issue that we believe has been fixed by the commit above, which has been in Canary for a few days, and UMA from #1 point at the issue being fixed. However to unblock the external experiment (and launch), we need the commit to be in stable.

About the commit:
- Very small fix (changing a parameter's value)
- Only affects a new feature for which we and the external experiment have a kill switch (server-controlled external experiment)
- Android (and Custom Tabs) only.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 3

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 4

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78f13501e9192861ebb258ab685186b75782c4c2

commit 78f13501e9192861ebb258ab685186b75782c4c2
Author: Benoit Lize <lizeb@chromium.org>
Date: Wed Jul 04 09:38:26 2018

android: Retry detached requests on network change.

Some detached requests fail because the network changes between
requests. Retry the request in this case, only once.

Bug: 851399
Change-Id: Ic77c28e5ac49fecaf634e4a225c8f443f75e2560
Reviewed-on: https://chromium-review.googlesource.com/1118262
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#571173}(cherry picked from commit 0c88d2db535f6c407afb185e8eb40edca2b10f13)
Reviewed-on: https://chromium-review.googlesource.com/1125759
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#598}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/78f13501e9192861ebb258ab685186b75782c4c2/chrome/browser/android/customtabs/detached_resource_request.cc

Sign in to add a comment