Issue metadata
Sign in to add a comment
|
Regression: Browser crash is seen after clicking on 'Remove' button in Touchbar panel.
Reported by
aiman.an...@etouch.net,
Jun 11 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3453.0 (Official Build) Revision 67baaec3f00fba7d0a5b1041fca4e28b16ac5e55-refs/branch-heads/3453@{#1}(64-bit) OS: Mac Touch-bar(10.13.6). Pre-Condiiton: 1. Enable 'Use Views browser windows instead of Cocoa' flag from chrome://flags and relaunch the browser. 2. Sign in to Chrome Steps to reproduce: 1. Launch chrome, Open NTP and click on bookmark icon in omnibox 2. On bookmark bubble click on More option. 3. On Edit bookmark overlay, add many 'new folder' by clicking on new folder button and click on Save button. 4. On Mac-Touchbar panel click on Remove button and Observe. Actual Result: Browser crash is seen when clicked on Remove button on Touch-bar panel. Expected Result: Browser should not crash. This is a regression issue, broken in 'M-69', and below is the bisect provided using per-revision script. Good Build:69.0.3447.0 (Revision: 563479) Bad Build: 69.0.3448.0 (Revision: 563958) You are probably looking for a change made after 563957 (known good), but no later than 563958 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/8fd698baad2716d78d3d4cc25fdd7694fa3c2422..07a1071502f4699d445d0b7f46f3ca27d10efef0 Suspect: https://chromium.googlesource.com/chromium/src/+/07a1071502f4699d445d0b7f46f3ca27d10efef0 sdy@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Note: Issue is Mac Touch-bar specific and is not reproducible on Windows(7,8,8.1,10) and Linux(14.04 LTS). Kindly refer the screen-cast using the below given link. https://drive.google.com/drive/folders/10ITAUz71J9xV3SToE6CVCjquzaPdFx9C?usp=sharing Thank You!
,
Jun 11 2018
Update: Uploaded Crash Report ID 2301d20f1df501c6 (Local Crash ID: 5c645631-75f9-48ea-84ca-48dc9eb77994) Thank You!
,
Jun 11 2018
Stack trace for the crash id: ----------------------------- Thread 0 (id: 0x6998) CRASHED [EXC_BAD_ACCESS / KERN_INVALID_ADDRESS @ 0x00000008 ] MAGIC SIGNATURE THREAD Stack Quality54%Show frame trust levels 0x0000000113a7bfd4 (Google Chrome Framework -dialog_delegate.cc:237 ) views::DialogDelegate::GetDialogClientView() 0x00000001139ff237 (Google Chrome Framework -bridged_content_view_touch_bar.mm:38 ) -[BridgedContentView(TouchBarAdditions) touchBarButtonAction:] 0x00007fff3be28a42 (AppKit + 0x007d9a42 ) 0x0000000111dfb21a (Google Chrome Framework -chrome_browser_application_mac.mm:291 ) __43-[BrowserCrApplication sendAction:to:from:]_block_invoke 0x00000001121ba719 (Google Chrome Framework + 0x022a5719 ) base::mac::CallWithEHFrame(void () block_pointer) 0x0000000111dfb114 (Google Chrome Framework -chrome_browser_application_mac.mm:290 ) -[BrowserCrApplication sendAction:to:from:] 0x00007fff3b8ce53e (AppKit + 0x0027f53e ) 0x00007fff3b8ce466 (AppKit + 0x0027f466 ) 0x00007fff3b8ce36c (AppKit + 0x0027f36c ) 0x00007fff3b90f687 (AppKit + 0x002c0687 ) 0x00007fff3bb2a062 (AppKit + 0x004db062 ) 0x00007fff3bb08dd9 (AppKit + 0x004b9dd9 ) 0x00007fff3bb89a93 (AppKit + 0x0053aa93 ) 0x00007fff3bb898e7 (AppKit + 0x0053a8e7 ) 0x00007fff3bc369ab (AppKit + 0x005e79ab ) 0x00007fff3bc388a5 (AppKit + 0x005e98a5 ) 0x00007fff3bcc0c85 (AppKit + 0x00671c85 ) 0x00007fff3bc37ae0 (AppKit + 0x005e8ae0 ) 0x00007fff3bc2a9ce (AppKit + 0x005db9ce ) 0x00007fff3be26597 (AppKit + 0x007d7597 ) 0x0000000111dfad0f (Google Chrome Framework -chrome_browser_application_mac.mm:233 ) __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke 0x00000001121ba719 (Google Chrome Framework + 0x022a5719 ) base::mac::CallWithEHFrame(void () block_pointer) 0x0000000111dfac43 (Google Chrome Framework -chrome_browser_application_mac.mm:232 ) -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 0x00007fff3b685884 (AppKit + 0x00036884 ) 0x00000001121ca55b (Google Chrome Framework -message_pump_mac.mm:808 ) base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) 0x00000001121c90bd (Google Chrome Framework -message_pump_mac.mm:184 ) base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) 0x00000001121ec424 (Google Chrome Framework -run_loop.cc:102 ) <name omitted> 0x0000000111e019ca (Google Chrome Framework -chrome_browser_main.cc:2194 ) ChromeBrowserMainParts::MainMessageLoopRun(int*) 0x00000001109fd973 (Google Chrome Framework -browser_main_loop.cc:983 ) content::BrowserMainLoop::RunMainMessageLoopParts() 0x00000001109fff21 (Google Chrome Framework -browser_main_runner_impl.cc:169 ) content::BrowserMainRunnerImpl::Run() 0x00000001109fa31a (Google Chrome Framework -browser_main.cc:51 ) content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) 0x0000000111db5366 (Google Chrome Framework -content_main_runner_impl.cc:620 ) content::ContentMainRunnerImpl::Run() 0x00000001136563a3 (Google Chrome Framework -main.cc:459 ) service_manager::Main(service_manager::MainParams const&) 0x0000000111db43e3 (Google Chrome Framework -content_main.cc:19 ) content::ContentMain(content::ContentMainParams const&) 0x000000010ff19142 (Google Chrome Framework -chrome_main.cc:101 ) ChromeMain 0x000000010bb41dd4 (Google Chrome -chrome_exe_main_mac.cc:165 ) main 0x00007fff65f22014 (libdyld.dylib + 0x00001014 ) start
,
Jun 16 2018
,
Jul 11
,
Jul 12
,
Jul 12
,
Jul 12
It looks like the issue actually happens early: when you click More, in the failed case the touch bar never updates to show Cancel and Save buttons for the folder picker. Do you have any ideas on how to trigger *that* consistently? This crash is uncommon in the wild, so dropping to P2.
,
Jul 12
,
Jul 26
Tagging Needs-Feedback for #9.
,
Jul 27
Hi @sdy, Retested this issue in today's Canary #70.0.3504.0 on Mac Touchbar(10.13.6) and got the following observations: 1. After clicking on 'More' button, the touchbar updates and shows 'Save' & 'Cancel' buttons for 'Edit bookmark' overlay. Then after clicking on 'Save' button, touchbar again updates and shows 'Default' touch controls. Hence we can not reproduce this crash at our end, since the touchbar does not show 'Remove' & 'Done' buttons after clicking on 'Save' button in 'Edit bookmark' overlay. We are no longer able to reproduce the crash reported in original issue. Adding a link below for a 'Screen-cast' to show the latest behaviour. https://drive.google.com/open?id=15ZOHTdxo7rxb8v7HvfxBE4k9uVOs_JJi Thank you..!
,
Jul 27
Thanks for re-testing! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aiman.an...@etouch.net
, Jun 11 2018