New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Favicon Default Fallback Rules

Project Member Reported by martijnb@chromium.org, Jun 11

Issue description

We would like the default favicon fallback to be matching the mock. 

Character specs:
Bold, 12pt, Black 33%

Background: 
Similar as background color used when a valid favicon is returned. 
 
FaviconFallbackRules.png
356 KB View Download
Labels: Q2
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e32c79adbefcd0b581ba401d64d92285ad3309f8

commit e32c79adbefcd0b581ba401d64d92285ad3309f8
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Wed Jun 27 17:56:29 2018

[ios] Polish Collections Fallback Icon Styling

Set text color to a custom gray color and do not set the background color provided by the fallback style.

Bug:  851390 
Change-Id: I185b609577652f8b23a92d0dcc76a485fb967f28
Reviewed-on: https://chromium-review.googlesource.com/1112632
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570834}
[modify] https://crrev.com/e32c79adbefcd0b581ba401d64d92285ad3309f8/ios/chrome/browser/favicon/BUILD.gn
[modify] https://crrev.com/e32c79adbefcd0b581ba401d64d92285ad3309f8/ios/chrome/browser/favicon/favicon_loader.mm
[modify] https://crrev.com/e32c79adbefcd0b581ba401d64d92285ad3309f8/ios/chrome/browser/ui/favicon/BUILD.gn
[modify] https://crrev.com/e32c79adbefcd0b581ba401d64d92285ad3309f8/ios/chrome/common/favicon/favicon_view.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Favicons are displayed correctly.
Verified on M69.0.3480.0 canary
iOS: 11.4, 12, 10.3.3
Device: iPad Pro, iPhoneX, iPhone5S
https://drive.google.com/file/d/1kIWn8j9CrQiwytNcTs1IzlLU7pBtcNHU/view
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8eeff01fbfa506b55fc9f1c0126c618a788015a4

commit 8eeff01fbfa506b55fc9f1c0126c618a788015a4
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Thu Jul 12 16:05:53 2018

[ios] Set favicon fallback style for UI Refresh for ReadingList

- Sets the fallback monogram and background colors to a constant color.

Collections flag off screenshot: https://drive.google.com/file/d/10fYA9oHwx_o3cGWXBSR5P4qXKIPDTcfm/view?usp=sharing
Collections flag on screenshot: https://drive.google.com/file/d/1WtAYb-fPE6QdR4rIpcWxuZtLjGr7iPNQ/view?usp=sharing

Bug:  851390 

Change-Id: I7d67a4129263b2deed52eb7603b3f84aa8b8a201
Reviewed-on: https://chromium-review.googlesource.com/1125271
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574582}
[modify] https://crrev.com/8eeff01fbfa506b55fc9f1c0126c618a788015a4/ios/chrome/browser/ui/reading_list/reading_list_mediator.mm

Sign in to add a comment