New issue
Advanced search Search tips

Issue 851385 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Files app: Hide folders except for whitelited ones under "Play Files" by default.

Project Member Reported by fukino@chromium.org, Jun 11 2018

Issue description

Under "Play Files", only Pictures, Movies, Music, and Documents should be displayed by default.

We are adding a toggle option in the gear menu (placed on the top-right corner of Files app) to show all folders under "Play Files".
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26100045ec2da3a3c0869129f70dfdd2da5bc685

commit 26100045ec2da3a3c0869129f70dfdd2da5bc685
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Jun 12 04:24:54 2018

Files app: Add filter to hide non-default Android folders.

Under "Play Files", only whitelisted folders should be visible by default.
This CL adds a filter to hide non-default top-level Android folders and enable
the filter.
This also renames methods for an existing filter, which is for hide dot files
and .crdownloads files, to be consistent with the methods for the new filter.

I'll create a follow-up CL to add an toggle option in gear menu to disable the
filter.

Bug:  851385 
Test: Manually confirmed on Eve.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8a8ad47d05e3f921a94834264fd3abde945880a5
Reviewed-on: https://chromium-review.googlesource.com/1095194
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566309}
[modify] https://crrev.com/26100045ec2da3a3c0869129f70dfdd2da5bc685/ui/file_manager/file_manager/foreground/js/directory_contents.js
[modify] https://crrev.com/26100045ec2da3a3c0869129f70dfdd2da5bc685/ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js
[modify] https://crrev.com/26100045ec2da3a3c0869129f70dfdd2da5bc685/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/26100045ec2da3a3c0869129f70dfdd2da5bc685/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/26100045ec2da3a3c0869129f70dfdd2da5bc685/ui/file_manager/file_manager/foreground/js/naming_controller.js

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d96ac46fa8670b09932929a9feafcae43d9c1f9

commit 3d96ac46fa8670b09932929a9feafcae43d9c1f9
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Jun 12 10:05:33 2018

Files app: Add a gear menu option to show hidden Android folders.

This CL adds a command to toggle the visibility of hidden Android folders, and
add a gear menu option item corresponding to the new command.

Bug:  851385 
Test: Manually tested.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I30e3fb385e7e6f801f23259a2b6905a8e2615f83
Reviewed-on: https://chromium-review.googlesource.com/1096802
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566372}
[modify] https://crrev.com/3d96ac46fa8670b09932929a9feafcae43d9c1f9/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3d96ac46fa8670b09932929a9feafcae43d9c1f9/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/3d96ac46fa8670b09932929a9feafcae43d9c1f9/ui/file_manager/file_manager/main.html

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33910a55c0706992b0ccfc4293bd92304c2cfed0

commit 33910a55c0706992b0ccfc4293bd92304c2cfed0
Author: Naoki Fukino <fukino@chromium.org>
Date: Thu Jun 14 11:28:14 2018

Files app: Display "Show hidden Play folders" conditionally.

The gear menu option "Show hidden Play folders" doesn't make sense when the
"Play Files" volume is not mounted.
The option should be visible only when the corresponding volume is mounted.

Bug:  851385 
Test: Manually tested on Eve.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5f39a669890c455cbd9763a6d0d047854545acca
Reviewed-on: https://chromium-review.googlesource.com/1100721
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567225}
[modify] https://crrev.com/33910a55c0706992b0ccfc4293bd92304c2cfed0/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

Comment 4 by fukino@chromium.org, Jun 22 2018

Status: Fixed (was: Started)

Sign in to add a comment