New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 851350 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jul 5
Cc:
atotic@chromium.org
kojii@chromium.org
█ cathiec...@tencent.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 591099



Sign in to add a comment

[LayoutNG] LayoutNGList items are too tall

Project Member Reported by kojii@chromium.org, Jun 11 2018 
From atotic@:

In these tests, too-tall list items trigger scrollbars. I think the problem is the size of LayoutNGList items:

fast/gradients/list-item-gradient.html  - List items with images too large
fast/gradients/unprefixed-list-item-gradient.html - List items with images too large

Comment 1 by kojii@chromium.org, Jun 11 2018

Blocking: 591099

Comment 2 by kojii@chromium.org, Jun 11 2018

Components: Blink>Layout
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cacb53bf1b90e80c006f579c7c6480a17cda2538

commit cacb53bf1b90e80c006f579c7c6480a17cda2538
Author: cathiechen <cathiechen@tencent.com>
Date: Thu Jul 05 09:27:22 2018

[LayoutNG] Compute intrinsic size of marker image same as legacy layout

The image_resource_ of LayoutNGListMarkerImage is always LayoutImageResourceStyleImage.
ImageSizeWithDefaultSize() could eventually call StyleImage::ImageSize() which is the way
legacy layout used to compute marker image's size. This could handle generated/svg images
properly.

Bug:  851350 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8d2c0e0baf4e2abed2c8455541f2843cbe3ee815
Reviewed-on: https://chromium-review.googlesource.com/1120086
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: cathie chen <cathiechen@tencent.com>
Cr-Commit-Position: refs/heads/master@{#572743}
[modify] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[add] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/gradients/list-item-gradient-expected.png
[add] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/gradients/list-item-gradient-expected.txt
[add] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/gradients/unprefixed-list-item-gradient-expected.png
[modify] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/blink/renderer/core/layout/layout_image.cc
[modify] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/blink/renderer/core/layout/layout_image_resource.cc
[modify] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/blink/renderer/core/layout/layout_image_resource.h
[modify] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/blink/renderer/core/layout/layout_image_resource_style_image.cc
[modify] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/blink/renderer/core/layout/layout_image_resource_style_image.h
[modify] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker_image.cc
[modify] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker_image.h
[modify] https://crrev.com/cacb53bf1b90e80c006f579c7c6480a17cda2538/third_party/blink/renderer/core/layout/ng/list/ng_unpositioned_list_marker.cc

Comment 4 by cathiec...@tencent.com, Jul 5

Status: Fixed (was: Available)
►

Sign in to add a comment