Copy paste menu overlaps the handles and cannot extend selection
Reported by
mahesh.i...@gmail.com,
Jun 11 2018
|
|||
Issue descriptionSteps to reproduce the problem: 1. Goto google news. 2. Open any article. 3. Try to select some text and extend selection. 4. Copy paste menu overlaps handle and cannot extend selection What is the expected behavior? Copy paste menu should not overlap handles and handle drag should be possible. What went wrong? Looks like when only Right handle is visible, copy paste menu positioning is going wrong. Did this work before? N/A Chrome version: 66.0.3359.158 Channel: stable OS Version: 8.0 Flash Version:
,
Jun 11 2018
Tested the issue on using #66.0.3359.158 on Pixel 2, 8.1.0 as per the steps mentioned in original comment. No copy paste menu overlap is seen and able to extend the text selection as well. @mahesh: Could you please update Chrome to latest version #67.0.3396.81 and check if you still face the issue? If so please help us with the details of your device for further triaging? Thanks!!
,
Jun 11 2018
@sandeepkumars: I am able to reproduce the issue in latest dev/ code also. It happens when the start handle is hidden and only end handle is visible. I think I found a fix too - https://chromium-review.googlesource.com/c/chromium/src/+/1094818
,
Jun 11 2018
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab40ae54194ab93dd8c52db0169b782271ee8ca8 commit ab40ae54194ab93dd8c52db0169b782271ee8ca8 Author: Mahesh Machavolu <mahesh.ma@samsung.com> Date: Tue Jun 12 07:48:20 2018 Return Visible Touch Handle height for RWHVA::GetTouchHandleHeight ShowSelectionMenu queries for TouchHandle height while passing this information to Java for positioning the Floating Popup Menu. Only Start Handle height is being queried at all times. During an active selection, it is possible Start Handle is hidden but End handle is only visible. In these cases, Start handle height would be zero. So, return end handle height in these cases. Bug: 851346 Change-Id: I087d12d95b86abfc1068d4fb9f331837912ca7a9 Reviewed-on: https://chromium-review.googlesource.com/1094818 Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by: AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by: Mohsen Izadi <mohsen@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#566355} [modify] https://crrev.com/ab40ae54194ab93dd8c52db0169b782271ee8ca8/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/ab40ae54194ab93dd8c52db0169b782271ee8ca8/ui/touch_selection/touch_selection_controller.cc [modify] https://crrev.com/ab40ae54194ab93dd8c52db0169b782271ee8ca8/ui/touch_selection/touch_selection_controller.h [modify] https://crrev.com/ab40ae54194ab93dd8c52db0169b782271ee8ca8/ui/touch_selection/touch_selection_controller_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by pnangunoori@chromium.org
, Jun 11 2018