VDA unittest fails with import mode at intel platform |
||||
Issue descriptionVideo Playback using Chrome browser sets output mode to "ALLOCATE". On the other hand, Video playback using ARC++ sets output mode to "IMPORT". video_ddecode_accelerator_unittest sets output mode to "ALLOCATE" by default. There is an option "--test_import" so that it sets output mode to "IMPORT" and tests VDAs with "IMPORT" mode. Right now, VDA unittest fails with "IMPORT" mode at intel devices, and it should pass. Any CL for VDAs must be checked by VDA unittest with both ALLOCATE and IMPORT mode. After it passes with IMPORT mode, we can catch, by the unittest, a bad CL to break video playback with ALLOCATE mode.
,
Jun 13 2018
,
Jun 27 2018
Sent for review: https://chromium-review.googlesource.com/c/chromium/src/+/1116018
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2eaa5a32c7ef8f657ff45cd5e76ac20392fe893 commit a2eaa5a32c7ef8f657ff45cd5e76ac20392fe893 Author: Sharif Elcott <selcott@chromium.org> Date: Thu Jun 28 15:24:12 2018 Support heterogeneous plane and FD counts in video unit test helper. The previous version of this helper function incorrectly assumed that the number of planes and the number of FDs in a GbmBuffer are always the same, but they are not necessarily so. Note that this bug did not affect any production code; it was only a bug in the unit test. Bug: 851343 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5db5a5d571fad24aa0fa0d73863f0157bf30f90f Reviewed-on: https://chromium-review.googlesource.com/1116018 Commit-Queue: Sharif Elcott <selcott@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#571131} [modify] https://crrev.com/a2eaa5a32c7ef8f657ff45cd5e76ac20392fe893/media/gpu/test/video_decode_accelerator_unittest_helpers.cc
,
Jul 5
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dcasta...@chromium.org
, Jun 12 2018