Create a bookmark by dragging custom link to Bookmarks bar |
||||||||||||||||
Issue descriptionChrome Version: 69.0.3453.3 (Official Build) canary (64-bit) OS: MacOS 10.13.1 What steps will reproduce the problem? (1) Drag a custom link to Bookmarks bar What is the expected result? A new bookmark is created What happens instead? Nothing Not sure how often this is really used, but it's existing functionality with MV tiles.
,
Jun 12 2018
,
Jun 26 2018
Verified that this does work and does not require a fix.
,
Jun 26 2018
Re-opened because I can still reproduce this on Mac with 69.0.3472.0 (Official Build) canary. I have the following flags: --enable-features=DoodlesOnLocalNtp,ExperimentalUi,OneGoogleBarOnLocalNtp,UseGoogleLocalNtp,VoiceSearchOnLocalNtp I cannot repro on Linux with the same flags. Unconfirmed on CrOS & Windows, so removing those tags too.
,
Jun 26 2018
Hm, it looks like this only happens when the bookmarks bar is the larger GM2 version.
,
Jun 26 2018
Interesting. There's some ongoing Views work that *may* have some impact on this. I'll assign this to myself to troubleshoot / follow up with the MacViews team.
,
Jul 22
Low priority. Bumping to the next release.
,
Aug 21
,
Oct 3
,
Oct 4
I don't think it's worth doing this anymore - it was already low priority, and now there are some thoughts about removing the bar altogether from the NTP. yyushkina@: any objections to closing this?
,
Oct 5
Well, we won't remove the bar for folks who have it enabled (just for those who don't have it) but I agree that it's low priority. I'd leave it open but would unassign it and mark it available.
,
Oct 5
,
Oct 5
,
Oct 5
Done & removed the target release, give the low priority.
,
Nov 14
,
Nov 28
Removing RVG post-launch.
,
Nov 28
Issue 909670 has been merged into this issue.
,
Nov 28
This is odd. The drags have a 'urln' flavor but not a 'url ' flavor. But it does have a "Apple URL pasteboard type" flavor.
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad9ff3b032f9fe011f843112ff1437b9409e5eaa commit ad9ff3b032f9fe011f843112ff1437b9409e5eaa Author: Avi Drissman <avi@chromium.org> Date: Fri Nov 30 23:57:58 2018 Improve the Mac clipboard util. This now searches for new-style URL and title pairs as well as the old pboardtype. BUG= 851326 Change-Id: I00afe5ce5a3ca7e54648194bbf686b0fd85dad62 Reviewed-on: https://chromium-review.googlesource.com/c/1354259 Reviewed-by: Sidney San MartÃn <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612856} [modify] https://crrev.com/ad9ff3b032f9fe011f843112ff1437b9409e5eaa/content/browser/web_contents/web_drag_source_mac.mm [modify] https://crrev.com/ad9ff3b032f9fe011f843112ff1437b9409e5eaa/ui/base/clipboard/clipboard_util_mac.mm
,
Nov 30
,
Dec 3
Able to reproduce this issue on Mac OS 10.14.0 and 10.13.6 on the reported version 69.0.3453.3 and the issue is fixed on the latest M-73 build 73.0.3629.0. 1. Launched Chrome and Enabled chrome://flags as mentioned in the comment #4 2. Enabled bookmarks Bar 3. Dragged and dropped custom link to Bookmarks bar As we have observed that the A new bookmark is created. Attached is the screencast for reference. Hence adding TE verified labels as the fix is working as expected. Thanks..!
,
Dec 11
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by yyushkina@chromium.org
, Jun 10 2018