New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 851326 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Create a bookmark by dragging custom link to Bookmarks bar

Project Member Reported by ramyan@chromium.org, Jun 10 2018

Issue description

Chrome Version: 69.0.3453.3 (Official Build) canary (64-bit)
OS: MacOS 10.13.1

What steps will reproduce the problem?
(1) Drag a custom link to Bookmarks bar

What is the expected result?
A new bookmark is created

What happens instead?
Nothing

Not sure how often this is really used, but it's existing functionality with MV tiles.

 
Status: Assigned (was: Available)
Labels: zine-triaged
Status: WontFix (was: Assigned)
Verified that this does work and does not require a fix.

Comment 4 by ramyan@chromium.org, Jun 26 2018

Labels: -OS-Linux -OS-Windows -OS-Chrome
Status: Assigned (was: WontFix)
Re-opened because I can still reproduce this on Mac with 69.0.3472.0 (Official Build) canary. I have the following flags:

--enable-features=DoodlesOnLocalNtp,ExperimentalUi,OneGoogleBarOnLocalNtp,UseGoogleLocalNtp,VoiceSearchOnLocalNtp

I cannot repro on Linux with the same flags. Unconfirmed on CrOS & Windows, so removing those tags too.
Hm, it looks like this only happens when the bookmarks bar is the larger GM2 version.

Comment 6 by ramyan@chromium.org, Jun 26 2018

Cc: kristip...@chromium.org
Owner: ramyan@chromium.org
Interesting. There's some ongoing Views work that *may* have some impact on this. I'll assign this to myself to troubleshoot / follow up with the MacViews team.
Labels: -Target-69 Target-70
Low priority. Bumping to the next release.
Labels: -Target-70 Target-71
Owner: tgu...@chromium.org
I don't think it's worth doing this anymore - it was already low priority, and now there are some thoughts about removing the bar altogether from the NTP.

yyushkina@: any objections to closing this?
Well, we won't remove the bar for folks who have it enabled (just for those who don't have it) but I agree that it's low priority. I'd leave it open but would unassign it and mark it available.
NextAction: 2018-09-30
Labels: KR-NTP-MD2-Polish
Labels: -Target-71
Owner: ----
Status: Available (was: Assigned)
Done & removed the target release, give the low priority.
Labels: -KR-NTP-MD2-Polish
Labels: -Restrict-View-Google
NextAction: ----
Removing RVG post-launch.
Cc: nyerramilli@chromium.org manoranj...@chromium.org a...@chromium.org rbasuvula@chromium.org
 Issue 909670  has been merged into this issue.
This is odd. The drags have a 'urln' flavor but not a 'url ' flavor. But it does have a "Apple URL pasteboard type" flavor.
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad9ff3b032f9fe011f843112ff1437b9409e5eaa

commit ad9ff3b032f9fe011f843112ff1437b9409e5eaa
Author: Avi Drissman <avi@chromium.org>
Date: Fri Nov 30 23:57:58 2018

Improve the Mac clipboard util.

This now searches for new-style URL and title pairs as well as
the old pboardtype.

BUG= 851326 

Change-Id: I00afe5ce5a3ca7e54648194bbf686b0fd85dad62
Reviewed-on: https://chromium-review.googlesource.com/c/1354259
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612856}
[modify] https://crrev.com/ad9ff3b032f9fe011f843112ff1437b9409e5eaa/content/browser/web_contents/web_drag_source_mac.mm
[modify] https://crrev.com/ad9ff3b032f9fe011f843112ff1437b9409e5eaa/ui/base/clipboard/clipboard_util_mac.mm

Status: Fixed (was: Available)
Cc: phanindra.mandapaka@chromium.org
Labels: TE-Verified-M73 TE-Verified-73.0.3629.0
Able to reproduce this issue on Mac OS 10.14.0 and 10.13.6 on the reported version 69.0.3453.3 and the issue is fixed on the latest M-73 build 73.0.3629.0.

1. Launched Chrome and Enabled chrome://flags as mentioned in the comment #4
2. Enabled bookmarks Bar 
3. Dragged and dropped custom link to Bookmarks bar   
As we have observed that the A new bookmark is created. Attached is the screencast for reference.

Hence adding TE verified labels as the fix is working as expected.

Thanks..!
851326.mp4
3.5 MB View Download
Cc: swarnasree.mukkala@chromium.org
 Issue 913706  has been merged into this issue.

Sign in to add a comment