Unable to reproduce this issue on reported version 67.0.3396.79 using windows10 and Mac 10.13.3 with steps mentioned in comment#0.

Opened devtools and color picker window and able to see color pallet successfully.

@Reporter: Could you please check the video and let us know if we miss anything. Please check the issue by resetting devtools to default and let us know the behavior. If issue is still seen please provide a screencast on reproducing the issue.

Thanks!

Deleted: 851311.mp4 2.6 MB

	851311.mp4 2.6 MB View Download

Reporter, when the bug occurs next time, check the devtools-on-devtools console:
1. switch devtools to a detached window mode (in the three dot menu)
2. make sure this devtools window is focused by clicking anywhere inside it
3. press Ctrl-Shift-i to open devtools-on-devtools
4. switch to Console panel in that new window and copypaste the error log here

The video in comment#2 is doing everything right. I just get different results for some reason. I don't know if that makes any difference, but I'm using Windows8.1

Wow, I didn't know there was such a thing as devtools-on-devtools. That's cool.

Here is the log:

Uncaught TypeError: Cannot read property '0' of undefined
    at ColorPicker.Spectrum._showPalette (color_picker_module.js:85)
    at ColorPicker.Spectrum._loadPalettes (color_picker_module.js:108)
    at new ColorPicker.Spectrum (color_picker_module.js:67)
    at Elements.ColorSwatchPopoverIcon.showPopover (elements_module.js:36)
    at Elements.ColorSwatchPopoverIcon._iconClick (elements_module.js:33)

Oh yes, I forgot to test and report: restoring the settings to default has indeed "fixed" the problem. Let me test further, to see which of my settings might have caused this.

Unfortunately, I cannot reproduce it myself now. It may have happened due to outdated settings of previous Chrome versions.

At any rate, thanks for the help. And sorry for the triple-post.

 Issue 852914  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/426c0fc678846f56a905eca26feb182b34742bf6

commit 426c0fc678846f56a905eca26feb182b34742bf6
Author: Paul Irish <paulirish@chromium.org>
Date: Tue Jul 03 08:37:31 2018

DevTools: Restore colorpicker functionality on pre-m67 custom palettes
Bug:851311

Change-Id: Ia13bc1f082b69f37ee8ca65ac467cea166c11a2b
Reviewed-on: https://chromium-review.googlesource.com/1120951
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572146}
[modify] https://crrev.com/426c0fc678846f56a905eca26feb182b34742bf6/third_party/blink/renderer/devtools/front_end/color_picker/Spectrum.js

Unable to verify the fix on latest canary 69.0.3481.0 using windows 10 as we are unable to reproduce(...comment#2) the issue on reported chrome version 67.0.3396.79

@Paul Irish: Could you please help us in verifying the fix.

Thanks!

For me on OSX 10.11.6 using Version 67.0.3396.99 (Official Build) (64-bit)
Color pickers works fine now

Thanks @romboutv.

I thought this was already mentioned somewhere. I believe it was 2-3 weeks ago already

Same as rombo...@gmail.com reports. Issue persists.

OS: Mac OSX 10.13.5 ("High Sierra").


Google Chrome	67.0.3396.99 (Official Build) (64-bit)
Revision	a337fbf3c2ab8ebc6b64b0bfdce73a20e2e2252b-refs/branch-heads/3396@{#790}
OS	Mac OS X
JavaScript	V8 6.7.288.46
Flash	30.0.0.113 
User Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

@Meagan,

Mine is working fine, osx 10.11.6 using same chrome

 Issue 859875  has been merged into this issue.

This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

All the verifications are done on Mac OS, yet the bug states this was present in Windows. Can we have this verified in Windows?

lushnikov@, would you be able to verify this fix on Latest Canary for Windows? Some reason i can't reproduce this.

Had the same issue on 

MacOS Sierra 10.12.6
Chrome Version 67.0.3396.99

Restoring the settings to default has solved the problem. Can't reproduce the bug with setting my usual settings.

manoranjan, I can verify the fix on Windows. All good there.

paulirish@, sweet! thank you for the quick help!

Thanks, approved for M68. Branch:3440

 Issue 863814  has been merged into this issue.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12e5635f8c15874d69889665be99d19a98ad73e9

commit 12e5635f8c15874d69889665be99d19a98ad73e9
Author: Paul Irish <paulirish@chromium.org>
Date: Wed Jul 18 00:55:12 2018

DevTools: Restore colorpicker functionality on pre-m67 custom palettes

Bug:851311

Change-Id: Ia13bc1f082b69f37ee8ca65ac467cea166c11a2b
Reviewed-on: https://chromium-review.googlesource.com/1120951
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#572146}(cherry picked from commit 426c0fc678846f56a905eca26feb182b34742bf6)
Reviewed-on: https://chromium-review.googlesource.com/1140461
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#712}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/12e5635f8c15874d69889665be99d19a98ad73e9/third_party/blink/renderer/devtools/front_end/color_picker/Spectrum.js

I can confirm that the fix in #9 should resolve this issue. I can reproduce this issue and palette.colorNames is undefined. Is there anyway to copy across my Chrome 67 profile to Chrome Canary so I can verify the fix?

Can confirm the fix works. This is the way I reproduced the issue:

I downloaded Chromium 66 (66.0.3359.0 @ 540270), Chromium 67 (67.0.3396.0 @ 550431), and Chromium 69 (69.0.3495.0 @ 575882).

I first loaded Chromium 66, created a custom palette and inserted some colors. Confirmed the color picker was still working after a restart of Chrome 66.

I then loaded Chromium 67 and attempted to use the color picker, confirmed it did not work. Using Chrome Dev Tools to do some inception, confirmed that the error being thrown is the expected one (colorNames is undefined).

I then loaded Chromium 69 and attempted to use the color picker and confirmed that the color picker is again working.

This fix LGTM.

Nice. ;)

Yeah for anyone who *really* wants to get this fix in stable now.. you can do what Josh did and open devtools on devtools. Pause at the right point in spectrum_module.js and then set the `palette.colorNames` property to an empty array. It'll get saved to localStorage soon after and everything should be resolved.  

 Issue 866451  has been merged into this issue.

Tried checking the issue on reported chrome version 67.0.3396.79 by upgrading it from 66.0.3359.181 using Windows 10. Yet some how we couldn't reproduce the issue from our end i.e., we were able to see the colour picker working fine.

Could some one help us in verifying the fix as we couldn't reproduce(..C#2&10) it.

Thanks!

paulirish@, thank you so much for verifying this fix on today's stable RC# 68.0.3440.75. Appreciate your help in this regards.

vamshi.kommuri@: See my reproduction steps in Comment 31. The key part to reproducing this is ensuring you create custom palettes in the color picker. Once you do that, upgrading to Chrome 67 should reproduce the issue.

Version 69.0.3497.100 - 64Bit - Win 10 (1803)

The issue persist only if developer tool window is not docket to the main window

Deleted: working.png 242 KB

	working.png 242 KB View Download

Deleted: not.png 205 KB

	not.png 205 KB View Download

How can I mark https://bugs.chromium.org/p/chromium/issues/detail?id=866451 as a separate issue? It was merged as a duplicate of this one, but it isn't.

So my issue white color picker is next: When a dev tool window is set to dock to bottom then color picker not working. When dev tools window is left or right side its workgin. I was looking for a solution and discovered it that when my screen resolution is set default 1920x1080 then the color picker not working, but when I set the screen resolution to 1900x600 then color picker's start working. I have reset chrome settings, dev tool settings no help there. You may look this video: https://youtu.be/OUI8cajcTbM This issue exists chrome and chrome canary.Chrome: 70.0.3538.102 Chrome canary: Version 72.0.3608.2 (Official Build) canary (32-bit)