Lag when navigating text with the keyboard |
||||
Issue descriptionChrome Version: 69.0.3453.3 OS: macOS 10.13.5 What steps will reproduce the problem? (1) Open a page with a textarea (like the "new bug" form here, or "data:text/html,<textarea>"). (2) Type some text. (3) Use different combinations of keys to navigate the text. For example, alternately press the left and right arrow keys, or use option with the arrow keys to select by word. What is the expected result? Fast navigation. What happens instead? Repeatedly pressing one key works fine, but alternating keys, or using combinations of keys, has a several-hundred ms delay.
,
Jun 9 2018
Thanks for the report sdy@. I noticed this on MacVievs and MD-Refresh today, too. Under MacViews or MD-Refresh it is very prominent, when you want to cycle through the Omnibox Dropdown via the arrow down and up keys. Also very prominent when you want to cycle through other menus like Bookmarks Folder Menus or the Hamburger (Settings) Menu. I can confirm your suspecting CL https://crrev.com/8f2f9568808ee117698e0a9008a0b52902d2363e. This is the bisected regression range: https://chromium.googlesource.com/chromium/src/+log/da5bdd0447bb19040c26dfc86debd36955ab98d3..f8a8b721bbc47542d98e4eaf50f7d84b03c3da21 erikchen@: Thanks for looking into this issue in advance :)
,
Jun 11 2018
,
Jun 11 2018
The new logic calls menuNeedsUpdate: on the NSMenuDelegate before checking for hotkeys. Populating the "Share" menu under the "File" menu is quite slow.
,
Jun 11 2018
Fix up: https://chromium-review.googlesource.com/c/chromium/src/+/1096082
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22be209b487b5f78c85fa5d80daca2ce6a651186 commit 22be209b487b5f78c85fa5d80daca2ce6a651186 Author: erikchen <erikchen@chromium.org> Date: Tue Jun 12 15:54:00 2018 macOS: Fix slowness while navigating text with hotkeys. A recent CL modified hotkey lookup to call -[NSMenuDelegate menuNeedsUpdate:] on every submenu's delegate prior to looking up the hotkey. The delegate of the "Share" menu has a particularly slow implementation of this method. This CL modifies the logic to just call -[AppController updateMenuItemKeyEquivalents], which updates the relevant NSMenuItems. Bug: 851260 Change-Id: If1529404a19a41b4c4085edbbb57be688881e9dc Reviewed-on: https://chromium-review.googlesource.com/1096082 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#566441} [modify] https://crrev.com/22be209b487b5f78c85fa5d80daca2ce6a651186/chrome/browser/app_controller_mac.h [modify] https://crrev.com/22be209b487b5f78c85fa5d80daca2ce6a651186/chrome/browser/app_controller_mac.mm [modify] https://crrev.com/22be209b487b5f78c85fa5d80daca2ce6a651186/chrome/browser/global_keyboard_shortcuts_mac.mm
,
Jun 12 2018
,
Jun 13 2018
Verified the fix on Mac 10.13.1 using Chrome version #69.0.3457.0 as per the comment #0. Attaching screen cast for reference. Observed Navigating text with the keyboard was fast. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version 69.0.3453.3 Thanks...!! |
||||
►
Sign in to add a comment |
||||
Comment 1 by sdy@chromium.org
, Jun 9 2018