Issue metadata
Sign in to add a comment
|
Cmd+shift+T opens new tab, doesn't re-open previous tab |
||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3453.3 OS: macOS 10.13.5 What steps will reproduce the problem? (1) Close an open tab. (2) Type cmd+shift+t What is the expected result? The closed tab re-opens. What happens instead? A new tab opens.
,
Jun 11 2018
,
Jun 11 2018
,
Jun 11 2018
Issue 851606 has been merged into this issue.
,
Jun 11 2018
From merged issue 851606 : Cmd+Shift+N doesn't open Incognito window
,
Jun 11 2018
Erik, please revert the suspected CL soon.
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a8bff8ee3902ed0d134cd2e80c4812c37d42451 commit 5a8bff8ee3902ed0d134cd2e80c4812c37d42451 Author: erikchen <erikchen@chromium.org> Date: Mon Jun 11 21:12:17 2018 macOS: Fix shift key not being recognized in keyboard shortcuts. A recent refactor changed keyboard shortcut processing to use [NSMenuItem cr_firesForKeyEvent:] as the detection logic. That method has had a bug since its inception where it fails to recognize NSMenuItems that use the shift key. This CL fixes the bug and adds tests. Bug: 851259 Change-Id: I1ab0698d3ea259256e3f0bb459537d0a91b3beb7 Reviewed-on: https://chromium-review.googlesource.com/1095839 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#566147} [modify] https://crrev.com/5a8bff8ee3902ed0d134cd2e80c4812c37d42451/chrome/browser/global_keyboard_shortcuts_mac_browsertest.mm [modify] https://crrev.com/5a8bff8ee3902ed0d134cd2e80c4812c37d42451/chrome/browser/ui/cocoa/nsmenuitem_additions.mm [modify] https://crrev.com/5a8bff8ee3902ed0d134cd2e80c4812c37d42451/chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
,
Jun 11 2018
,
Jun 12 2018
Issue 851803 has been merged into this issue.
,
Jun 12 2018
Issue 852065 has been merged into this issue.
,
Jun 12 2018
,
Jun 13 2018
Tested the issue on Mac 10.13.3 using Chrome version M69 - 69.0.3457.0 as per the issue mentioned in original comment. Observed that issue is working as intended (Closed tab gets reopened by performing the key board action cmd+shift+t). Hence adding TE-Verified label. Attached the screencast for reference. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sdy@chromium.org
, Jun 9 2018Labels: FoundIn-69