"CrostiniInstallerViewBrowserTest.ErrorThenCancel" is flaky |
||||
Issue description"CrostiniInstallerViewBrowserTest.ErrorThenCancel" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBDcm9zdGluaUluc3RhbGxlclZpZXdCcm93c2VyVGVzdC5FcnJvclRoZW5DYW5jZWwM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 11 2018
Culprit is https://chromium-review.googlesource.com/c/chromium/src/+/1089600 which introduced the test. Assigning to nverne@ (author of the patch) to follow-up.
,
Jun 11 2018
Revert in commit queue: https://chromium-review.googlesource.com/c/chromium/src/+/1095134
,
Jun 11 2018
Issue 851214 has been merged into this issue.
,
Jun 11 2018
Revert submitted.
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53d190bd8b0365642871a661e9376cc1900fcddb commit 53d190bd8b0365642871a661e9376cc1900fcddb Author: Nicholas Verne <nverne@chromium.org> Date: Wed Jun 13 08:17:00 2018 Reland "Fixes a crash when the user's install flow fails and we press Cancel." This relands commit 9ec0dfc9a56f658f2c33cdd4c1918deacdf54537. In viz_browser_tests and mash_browser_tests it is possible for RunLoop::RunUntilIdle to return in a test while there are still pending tasks (on another task runner). We delay the test's continuation until the appropriate condition on FakeConciergeClient is satisfied. Bug: 851253 Change-Id: Iab1ade58607efae9ca7666666e0f77210d5973c1 Reviewed-on: https://chromium-review.googlesource.com/1096587 Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#566757} [modify] https://crrev.com/53d190bd8b0365642871a661e9376cc1900fcddb/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/53d190bd8b0365642871a661e9376cc1900fcddb/chrome/browser/ui/views/crostini/crostini_installer_view.cc [modify] https://crrev.com/53d190bd8b0365642871a661e9376cc1900fcddb/chrome/browser/ui/views/crostini/crostini_installer_view_browsertest.cc [modify] https://crrev.com/53d190bd8b0365642871a661e9376cc1900fcddb/chromeos/dbus/fake_concierge_client.cc [modify] https://crrev.com/53d190bd8b0365642871a661e9376cc1900fcddb/chromeos/dbus/fake_concierge_client.h
,
Jun 13 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88dd4409a40e1f4f0a52c7a044c261a9cdd6ff11 commit 88dd4409a40e1f4f0a52c7a044c261a9cdd6ff11 Author: Nicholas Verne <nverne@chromium.org> Date: Fri Jun 15 03:32:32 2018 CrostiniInstallerViewBrowserTest.InstallFlow flake fix. The old version of this test could cause a browser crash by shutting down too early. Now we wait until the flow has finished and the installer view is closed before shutting down. Bug: 851253 Change-Id: I9f00f23587d2e3b52c8b1355f682e5397a460de1 Reviewed-on: https://chromium-review.googlesource.com/1101599 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#567539} [modify] https://crrev.com/88dd4409a40e1f4f0a52c7a044c261a9cdd6ff11/chrome/browser/ui/views/crostini/crostini_installer_view_browsertest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by chromium...@appspot.gserviceaccount.com
, Jun 11 2018