"BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalSmallerThanActualSize" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyegsSBUZsYWtlIm9CYWNrZ3JvdW5kRmV0Y2hCcm93c2VyVGVzdC5PZmZsaW5lSXRlbUNvbGxlY3Rpb25fVmVyaWZ5UmVzb3VyY2VEb3dubG9hZGVkV2hlbkRvd25sb2FkVG90YWxTbWFsbGVyVGhhbkFjdHVhbFNpemUM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
test is still flaky. Especially bad on Mac, but also ChromiumOs and Linux MSAN: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalSmallerThanActualSize It seems that flakes started to happen around June 8th.
As I cannot see any changes to the directory in the last weeks, and there are no clues from Findit, I'll go ahead and disable the test.
Assigning to nator@ who implemented the test for triaging/fixing. Patch to disable the test: https://chromium-review.googlesource.com/c/chromium/src/+/1095183
Actually, BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalLargerThanActualSize is also flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalLargerThanActualSize (the submit of this patch failed due to that flake). I'm disabling this one too.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7451e312c9e7d9b845da7adf0f1998de99b10eb commit f7451e312c9e7d9b845da7adf0f1998de99b10eb Author: Tim Schumann <tschumann@chromium.org> Date: Mon Jun 11 14:27:02 2018 Disable flaky BackgroundFetchBrowserTest tests. -- BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalSmallerThanActualSize -- BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalLargerThanActualSize are flaky. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotal.*ThanActualSize TBR=peter@chromium.org Bug: 851229 , 839438 Change-Id: I0aee9f1fdbabcbe7802d85e3ee782b522a03ff61 Reviewed-on: https://chromium-review.googlesource.com/1095183 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#565993} [modify] https://crrev.com/f7451e312c9e7d9b845da7adf0f1998de99b10eb/chrome/browser/background_fetch/background_fetch_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/544227752f568f6ef49b4567adc6515412904c96 commit 544227752f568f6ef49b4567adc6515412904c96 Author: Rayan Kanso <rayankans@chromium.org> Date: Fri Jun 22 19:07:05 2018 Change CacheStorageManager in context from unique_ptr to scoped_refptr. Now that CacheStorage can have multiple clients/owners, some of them will need access to the CacheStorageManager after shutdown to wrap up their tasks. This CL changes the CacheStorageManager member in CacheStorageContextImpl to a scoped_refptr, so that if there are any references after the shutdown was initiated, systems that hold a reference can finish their tasks without crashing. Bug: 851164 , 851229 Change-Id: I3226e79325adce62594de2135ab4450f463b5eac Reviewed-on: https://chromium-review.googlesource.com/1095261 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#569722} [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_context.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_data_manager.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_data_manager.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_data_manager_unittest.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_test_data_manager.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_test_data_manager.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/cleanup_task.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/cleanup_task.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/database_task.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/database_task.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/delete_registration_task.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/delete_registration_task.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/get_settled_fetches_task.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/get_settled_fetches_task.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/mark_request_complete_task.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/mark_request_complete_task.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/README.md [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/cache_storage_context_impl.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/cache_storage_context_impl.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/cache_storage_manager.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/cache_storage_manager.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/cache_storage_manager_unittest.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/storage_partition_impl.cc
These have been fixed now, closing the bug.
Comment 1 by tschumann@google.com
, Jun 11 2018