New issue
Advanced search Search tips

Issue 851219 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-20
OS: iOS
Pri: 0
Type: Task
Q2



Sign in to add a comment

Enable recently closed tabs in tab grid

Project Member Reported by edchin@chromium.org, Jun 9 2018

Issue description

Enable recently closed tabs in tab grid.
 
Owner: edchin@chromium.org
Status: Assigned
Status: Started (was: Assigned)
Summary: Enable recently closed tabs in tab grid (was: Hook up Open All tabs in session)
Description: Show this description

Comment 5 by edchin@chromium.org, Jun 13 2018

NextAction: 2018-06-20
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d4b94246e31a5504128112fa3f35758b62086b4

commit 4d4b94246e31a5504128112fa3f35758b62086b4
Author: edchin <edchin@chromium.org>
Date: Thu Jun 14 06:44:29 2018

[ios] Enable recently closed in tab grid

This CL enables the user to:
1) See recently closed tabs in the tab grid.
2) Tap and open recently close tabs.

This CL adds a method to UrlLoader protocol that restores a tab to
the WebStateList based on SessionID.

In BVC, the restored tab replaces the current WebState.
In tab grid, the restored tab is added to the end of the WebStateList.

Bug:  851219 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6dc6c22f43d746a9dc73d15b65d6fd5193899a25
Reviewed-on: https://chromium-review.googlesource.com/1094324
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567175}
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/browser/ui/history/history_coordinator.h
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/browser/ui/history/history_coordinator.mm
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/browser/ui/tab_grid/tab_grid_url_loader.h
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/browser/ui/tab_grid/tab_grid_url_loader.mm
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/browser/ui/table_view/cells/table_view_accessory_item.mm
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/browser/ui/url_loader.h
[modify] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/ios/chrome/test/fakes/fake_url_loader.mm

Components: UI>Browser>Mobile>TabSwitcher

Comment 8 by edchin@chromium.org, Jun 15 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-06-20

Sign in to add a comment