Full range (PC range)'s color is clipped when using hardware-accelerated video decode
Reported by
human.p...@gmail.com,
Jun 9 2018
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3453.0 Safari/537.36 Example URL: https://files.catbox.moe/o5a8jg.mp4 Steps to reproduce the problem: 1. Make sure chrome://flags/#disable-accelerated-video-decode is enabled 1. Open the video (also attached as attachment). What is the expected behavior? The color should be represented as RGB value that the red fonts show. What went wrong? Color is clipped, 16,16,16 became 0,0,0 etc. Did this work before? N/A Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? N/A Chrome version: 69.0.3453.0 Channel: canary OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Contents of chrome://gpu: Graphics Feature Status Canvas: Hardware accelerated Flash: Hardware accelerated Flash Stage3D: Hardware accelerated Flash Stage3D Baseline profile: Hardware accelerated Compositing: Hardware accelerated Multiple Raster Threads: Enabled Native GpuMemoryBuffers: Software only. Hardware acceleration disabled Out-of-process Rasterization: Disabled Hardware Protected Video Decode: Unavailable Rasterization: Hardware accelerated Skia Deferred Display List: Disabled Skia Renderer: Disabled Surface Synchronization: Enabled Video Decode: Hardware accelerated Viz Service Display Compositor: Disabled WebGL: Hardware accelerated WebGL2: Hardware accelerated Driver Bug Workarounds clear_uniforms_before_first_program_use decode_encode_srgb_for_generatemipmap disable_accelerated_vpx_decode disable_delayed_copy_nv12 disable_direct_composition disable_discard_framebuffer disable_dxgi_zero_copy_video disable_framebuffer_cmaa exit_on_context_lost force_cube_complete scalarize_vec_and_mat_constructor_args texsubimage_faster_than_teximage Problems Detected Protected video decoding with swap chain is for Windows and Intel only Disabled Features: protected_video_decode Some drivers are unable to reset the D3D device in the GPU process sandbox Applied Workarounds: exit_on_context_lost TexSubImage is faster for full uploads on ANGLE Applied Workarounds: texsubimage_faster_than_teximage Clear uniforms before first program use on all platforms: 124764, 349137 Applied Workarounds: clear_uniforms_before_first_program_use Always rewrite vec/mat constructors to be consistent: 398694 Applied Workarounds: scalarize_vec_and_mat_constructor_args ANGLE crash on glReadPixels from incomplete cube map texture: 518889 Applied Workarounds: force_cube_complete Framebuffer discarding can hurt performance on non-tilers: 570897 Applied Workarounds: disable_discard_framebuffer Direct composition flashes black initially on Win <10: 588588 Applied Workarounds: disable_direct_composition Zero copy DXGI video hangs on shutdown on Win < 8.1: 621190 Applied Workarounds: disable_dxgi_zero_copy_video Use GL_INTEL_framebuffer_CMAA on ChromeOS: 535198 Applied Workarounds: disable_framebuffer_cmaa Disable KHR_blend_equation_advanced until cc shaders are updated: 661715 Applied Workarounds: disable(GL_KHR_blend_equation_advanced), disable(GL_KHR_blend_equation_advanced_coherent) Decode and Encode before generateMipmap for srgb format textures on Windows: 634519 Applied Workarounds: decode_encode_srgb_for_generatemipmap VPx decoding isn't supported well before Windows 10 creators update.: 616318, 667532 Applied Workarounds: disable_accelerated_vpx_decode Delayed copy NV12 displays incorrect colors on NVIDIA drivers.: 728670 Applied Workarounds: disable_delayed_copy_nv12 Don't expose disjoint_timer_query extensions to WebGL: 808744 Native GpuMemoryBuffers have been disabled, either via about:flags or command line. Disabled Features: native_gpu_memory_buffers Viz service display compositor is not enabled by default. Disabled Features: viz_display_compositor Skia renderer is not used by default. Disabled Features: skia_renderer Skia deferred display list is not used by default. Disabled Features: skia_deferred_display_list Version Information Data exported 2018-06-09T03:12:11.490Z Chrome version Chrome/69.0.3453.0 Operating system Windows NT 6.1.7601 SP1 Software rendering list URL https://chromium.googlesource.com/chromium/src/+/67baaec3f00fba7d0a5b1041fca4e28b16ac5e55/gpu/config/software_rendering_list.json Driver bug list URL https://chromium.googlesource.com/chromium/src/+/67baaec3f00fba7d0a5b1041fca4e28b16ac5e55/gpu/config/gpu_driver_bug_list.json ANGLE commit id 81970bc302dd 2D graphics backend Skia/69 9f752aada37c9e1e10328721ea0b480553da50d5- Command Line "C:\Users\Administrator\AppData\Local\Google\Chrome SxS\Application\chrome.exe" --flag-switches-begin --flag-switches-end Driver Information Initialization time 43 In-process GPU false Passthrough Command Decoder true Direct Composition false Supports overlays false Sandboxed true GPU0 VENDOR = 0x10de, DEVICE= 0x11c0 *ACTIVE* GPU1 VENDOR = 0x8086, DEVICE= 0x0412 Optimus false AMD switchable false Desktop compositing Aero Glass Diagonal Monitor Size of \\.\DISPLAY1 23.0" Driver D3D12 feature level Not supported Driver Vulkan API version Vulkan API 1.1.0 Driver vendor NVIDIA Driver version 24.21.13.9764 Driver date 5-7-2018 Pixel shader version 5.0 Vertex shader version 5.0 Max. MSAA samples 8 Machine model name Machine model version GL_VENDOR Google Inc. GL_RENDERER ANGLE (NVIDIA GeForce GTX 660 Direct3D11 vs_5_0 ps_5_0) GL_VERSION OpenGL ES 2.0 (ANGLE 2.1.0.81970bc302dd) GL_EXTENSIONS GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_explicit_context GL_ANGLE_explicit_context_gles1 GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object OES_compressed_EAC_R11_signed_texture OES_compressed_EAC_R11_unsigned_texture OES_compressed_EAC_RG11_signed_texture OES_compressed_EAC_RG11_unsigned_texture OES_compressed_ETC2_RGB8_texture OES_compressed_ETC2_RGBA8_texture OES_compressed_ETC2_punchthroughA_RGBA8_texture OES_compressed_ETC2_punchthroughA_sRGB8_alpha_texture OES_compressed_ETC2_sRGB8_alpha8_texture OES_compressed_ETC2_sRGB8_texture Disabled Extensions GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent Disabled WebGL Extensions EXT_disjoint_timer_query EXT_disjoint_timer_query_webgl2 Window system binding vendor Google Inc. (adapter LUID: 000000000000b26f) Window system binding version 1.4 (ANGLE 2.1.0.81970bc302dd) Window system binding extensions EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_ANGLE_robust_resource_initialization EGL_ANGLE_create_context_extensions_enabled Direct rendering Yes Reset notification strategy 0x8252 GPU process crash count 0 Compositor Information Tile Update Mode One-copy Partial Raster Enabled GpuMemoryBuffers Status ATC Software only ATCIA Software only DXT1 Software only DXT5 Software only ETC1 Software only R_8 Software only R_16 Software only RG_88 Software only BGR_565 Software only RGBA_4444 Software only RGBX_8888 GPU_READ, SCANOUT RGBA_8888 GPU_READ, SCANOUT BGRX_8888 Software only BGRX_1010102 Software only RGBX_1010102 Software only BGRA_8888 Software only RGBA_F16 Software only YVU_420 Software only YUV_420_BIPLANAR Software only UYVY_422 Software only Display(s) Information Info Display[2528732444] bounds=[0,0 1920x1080], workarea=[0,0 1920x1040], scale=1, external. Color space information {primaries:BT709, transfer:IEC61966_2_1, matrix:RGB, range:FULL} Bits per color component 8 Bits per pixel 24 Video Acceleration Information Decode h264 baseline up to 1920x1088 pixels Decode h264 main up to 1920x1088 pixels Decode h264 high up to 1920x1088 pixels Diagnostics 0 b3DAccelerationEnabled true b3DAccelerationExists true bAGPEnabled true bAGPExistenceValid true bAGPExists true bCanRenderWindow true bDDAccelerationEnabled true bDriverBeta false bDriverDebug false bDriverSigned false bDriverSignedValid false bNoHardware false dwBpp 32 dwDDIVersion 11 dwHeight 1080 dwRefreshRate 60 dwWHQLLevel 0 dwWidth 1920 iAdapter 0 lDriverSize 19009672 lMiniVddSize 0 szAGPStatusEnglish Enabled szAGPStatusLocalized 已启用 szChipType GeForce GTX 660 szD3DStatusEnglish Enabled szD3DStatusLocalized 已启用 szDACType Integrated RAMDAC szDDIVersionEnglish 11 szDDIVersionLocalized 11 szDDStatusEnglish Enabled szDDStatusLocalized 已启用 szDXVAHDEnglish Supported szDXVAModes szDescription NVIDIA GeForce GTX 660 szDeviceId 0x11C0 szDeviceIdentifier {D7B71E3E-5280-11CF-CC51-43151BC2D535} szDeviceName \\.\DISPLAY1 szDisplayMemoryEnglish 1664 MB szDisplayMemoryLocalized 1664 MB szDisplayModeEnglish 1920 x 1080 (32 bit) (60Hz) szDisplayModeLocalized 1920 x 1080 (32 bit) (60Hz) szDriverAssemblyVersion 24.21.13.9764 szDriverAttributes Final Retail szDriverDateEnglish 5/8/2018 16:22:28 szDriverDateLocalized 2018/5/8 16:22:28 szDriverLanguageEnglish English szDriverLanguageLocalized 英语(美国) szDriverModelEnglish WDDM 1.1 szDriverModelLocalized WDDM 1.1 szDriverName nvd3dumx.dll,nvwgf2umx.dll,nvwgf2umx.dll,nvd3dum,nvwgf2um,nvwgf2um szDriverNodeStrongName oem9.inf:NVIDIA_Devices.NTamd64.6.1:Section007:24.21.13.9764:pci\ven_10de&dev_11c0 szDriverSignDate szDriverVersion 24.21.0013.9764 szKeyDeviceID Enum\PCI\VEN_10DE&DEV_11C0&SUBSYS_354E1458&REV_A1 szKeyDeviceKey \Registry\Machine\System\CurrentControlSet\Control\Video\{656A931D-A01E-4CEA-89EE-13DB7423063A}\0000 szManufacturer NVIDIA szMiniVdd 暂缺 szMiniVddDateEnglish n/a szMiniVddDateLocalized 暂缺 szMonitorMaxRes szMonitorName 通用即插即用监视器 szNotesEnglish No problems found. szNotesLocalized 没有发现问题。 szOverlayEnglish Supported szRankOfInstalledDriver 00E62001 szRegHelpText szRevision szRevisionId 0x00A1 szSubSysId 0x354E1458 szTestResultD3D7English Not run szTestResultD3D7Localized 未运行 szTestResultD3D8English Not run szTestResultD3D8Localized 未运行 szTestResultD3D9English Not run szTestResultD3D9Localized 未运行 szTestResultDDEnglish Not run szTestResultDDLocalized 未运行 szVdd 暂缺 szVendorId 0x10DE Log Messages GpuProcessHostUIShim: The GPU process exited normally. Everything is okay. GpuProcessHostUIShim: The GPU process exited normally. Everything is okay. GpuProcessHostUIShim: The GPU process exited normally. Everything is okay. It works fine with software video decoding. I'm on Win 7 x64 with nVidia GPU.
,
Jun 11 2018
This bug is also on Android 8.1 (which I assume is hardware decoding). Tested with Nexus 6P.
,
Jun 11 2018
Le lun. 11 juin 2018 à 02:15, human.p… via monorail < monorail+v2.338603342@chromium.org> a écrit :
,
Jun 11 2018
Le lun. 11 juin 2018 à 02:33, Ammi Mohamed <ammimohamed1234@gmail.com> a écrit :
,
Jun 11 2018
Le lun. 11 juin 2018 à 02:32, Ammi Mohamed <ammimohamed1234@gmail.com> a écrit :
,
Jun 11 2018
,
Jun 11 2018
It seems to *work* on my laptop, which is Win10 + Intel GPU. Chrome://gpu info: https://pastebin.com/cswmfdVs
,
Jun 18 2018
,
Jul 24
First of all: This is supposed to work. (in fact it works on all machines I have tried it on so far.) There is code in there that tells the video processor "this is full-range video" and then asks it to convert it to RGB. Not sure why that's not enough, and I don't have a windows 7 machine to try it on. I will see if I can find a windows 7 machine to try it on though.
,
Jul 24
Thanks for looking into it. Do you by chance test on Android? As mentioned before, it didn't work there either. Granted, the Android version may have vastly different code base which is out of your field.
,
Jul 25
I can take a look at how it works on android, but as you point out, it's really a separate code path and a separate problem.
,
Jul 25
Actually, could you file a separate bug for the android problem?
,
Jul 26
Yeah, I filed it at bug 867977.
,
Dec 7
,
Dec 7
Just curious: are you quitting Chromium project? Saw you dropped basically all the assigned bugs. Anyway thanks for the help on video-related bugs all these years.
,
Dec 8
Same as issue 902550, we should just disable for Windows 7.
,
Dec 11
@human.peng: Yes hubbe@ has moved on to another team. Can you see if the issue occurs with --disable-features=video-blit-color-accuracy ?
,
Dec 14
@human.peng: Have you modified the NVIDIA control panel setting for full/limited range under "adjust video color settings" ?
,
Dec 15
Ah, good question. No, that setting is untouched ("with the video player settings").
So, If I use "--disable-features=video-blit-color-accuracy", it WILL mess up the color of limited range video :(
,
Dec 15
Just to make it clear: what I reported as "working" in comment 18 is because: disabling video-blit-color-accuracy will just re-introduce the previous bug ( issue 763224 ), which make *all* video's color washed-out (when that nV setting is set to auto instead of manual "full"). And that effect "cancels out" with the bug that full-color video's range is clipped, which makes it look normal. So, yeah, the full-range video color clipping bug is still there. (I think you definitely know better than me, just don't want to confuse anyone!)
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/925f40e1f40b6ffb40cf152efa6d92b7af6fbae1 commit 925f40e1f40b6ffb40cf152efa6d92b7af6fbae1 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Mon Dec 17 21:48:57 2018 Fix incorrect D3D11 color range configuration Color range was being set incorrectly presumably due to a typo. Bug: 851216, 825578, 902550 Change-Id: I22c1af549619c2fad194990a39f11ae7600ca684 Reviewed-on: https://chromium-review.googlesource.com/c/1379035 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#617242} [modify] https://crrev.com/925f40e1f40b6ffb40cf152efa6d92b7af6fbae1/ui/gfx/color_space_win.cc
,
Dec 17
The above change may fix the issues with washout. I'll let you know which Chrome Canary version gets that commit. Once available, please test if the issue is fixed there _without_ disabling video-blit-color-accuracy.
,
Dec 18
Sure, thank you.
,
Dec 18
Tested this issue on Windows 7 on the reported version 69.0.3453.0 and the latest M-73 73.0.3644.0 by following the below steps. 1. Launched Chrome and made sure chrome://flags/#disable-accelerated-video-decode is enabled 2. Navigated to https://files.catbox.moe/o5a8jg.mp4 and can observe the same behavior in the reported version and on the latest M-73 build Attached is the screen cast for reference. dalecurtis@ Request you to check and confirm if anything is missed from our end in verifying the issue and help us to verify the fix on the latest M-73 build. Thanks...
,
Dec 18
Thanks susan. @human.peng: Can you double check as well with canary version 73.0.3644.0? Also let me know if things are no longer fixed with --disable-features=video-blit-color-accuracy
,
Dec 18
@dale: They're still broken on my end with the following version, when using no launch option. Google Chrome 73.0.3644.0 (Official Build) canary (64-bit) (cohort: Clang-64) Revision fe72396229ba179b91d835591ff0cffb311d8076-refs/branch-heads/3644@{#1}
,
Dec 18
Thanks, but still fixed when using the option?
,
Dec 18
Well as mentioned before, it's hardly count as "fixed" because 1) using that option will mess up limited range video instead; 2) If I use that option together with setting color range manually to "full" in nVidia settings, it does nothing (i.e. as broken as without that option) But yes, if I use "--disable-features=video-blit-color-accuracy" and keep nVidia setting as "with the video player settings", it will show full-range (and full-range only) video correctly (which IMHO is just a coincidence of two bugs cancelling out). Basically, the whole situation is no difference from what I observed a few days ago.
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a30440e4cfc7016d4f75a4e108025667e130b78b commit a30440e4cfc7016d4f75a4e108025667e130b78b Author: Dale Curtis <dalecurtis@chromium.org> Date: Thu Dec 20 01:09:43 2018 Fix one more instance of incorrect color range. Another incorrect usage of RGB_Range=1/LIMITED and 0-255 for the nominal range. This switches the code to use GetD3D11ColorSpace for consistency; which may change some behaviors -- it sets matrix, rgb, and range based on color_space instead of always using full range. Per discussion with hubbe@ we're expecting this to make a direct copy so it shouldn't affect anything, but that's an unverified assumption. BUG=851216, 825578, 902550 TEST=none R=sunnyps Change-Id: I55d192de607a26cb76238cc70a46f4343bb8f290 Reviewed-on: https://chromium-review.googlesource.com/c/1383325 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#618054} [modify] https://crrev.com/a30440e4cfc7016d4f75a4e108025667e130b78b/media/gpu/windows/dxva_video_decode_accelerator_win.cc
,
Dec 20
I'm ooo until January, but let me know if that patch helps out! Should be in Friday's canary version. Probably 73.0.3647.0 or higher.
,
Dec 20
Tested this issue on Windows 7 on the reported version 69.0.3453.0 and the latest M-73 73.0.3646.0 by following the below steps. 1. Launched Chrome and made sure chrome://flags/#disable-accelerated-video-decode is enabled 2. Navigated to https://files.catbox.moe/o5a8jg.mp4 and can observe the same behavior in the reported version and on the latest M-73 build Attached is the screen shots of the reported version and the latest M-73. As dalecurtis@ is OOO till January, Requesting human.peng@ to check and confirm if anything is missed from our end in verifying the issue and help us to verify the fix on the latest M-73 build. Thanks...
,
Jan 3
@dale: unfortunately, it is still bugged.
,
Jan 7
Ah that's unfortunate. Can you test to see if the statements you made in c#22 are still true? I.e., that w/ --disable-features=video-blit-color-accuracy range isn't expanded correctly?
,
Jan 7
Yes, it is still true. w/ --disable-features=video-blit-color-accuracy + auto in nV setting: normal video: washed-out full-range video: correct w/ --disable-features=video-blit-color-accuracy + "full" in nV setting: Normal video: Correct Full-range video: clipped
,
Jan 7
Ahh that's unfortunate :/ Not sure where to go from here. Will have to give it some more thought. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by krajshree@chromium.org
, Jun 11 2018