New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 851211 link

Starred by 1 user
Status: Fixed
Owner:
vapier@chromium.org
Closed: Jun 2018
Cc:
derat@chromium.org
adlr@chromium.org
vapier@chromium.org
█ reve...@chromium.org
█ marc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

common-assets: drop X cursor install

Project Member Reported by vapier@chromium.org, Jun 9 2018 
common-assets installs a bunch of cursor related files generated by xcursorgen.  i think Chrome has internalized all its cursor assets now, so lets drop the system side.

i'm talking about the random files under /usr/share/cursors/xorg-x11/chromeos/cursors/
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4454a5cdeb9f3e1fa6c5211d60d017dd1cdfbd84

commit 4454a5cdeb9f3e1fa6c5211d60d017dd1cdfbd84
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jun 13 16:19:52 2018

common-assets: drop X cursor install

Chrome manages all its cursor assets itself now, so we don't need these.

BUG= chromium:851211 
TEST=precq passes

Change-Id: Ie45f0684613f3e4aab81e6d0177c2cc17826582f
Reviewed-on: https://chromium-review.googlesource.com/1094313
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/4454a5cdeb9f3e1fa6c5211d60d017dd1cdfbd84/chromeos-base/common-assets/common-assets-9999.ebuild
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/assets/+/d2b25b53486d43c20ea888b76f1e997c807173b8

commit d2b25b53486d43c20ea888b76f1e997c807173b8
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jun 15 17:57:25 2018

cursors: punt

Chrome manages all its cursor assets itself now, so we don't need these.

BUG= chromium:851211 
TEST=precq passes

Change-Id: I6a1be1f486e212a4ad854d47d9d95643f6c71d2b
Reviewed-on: https://chromium-review.googlesource.com/1094694
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/hand2.png
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/top_left_corner.cfg
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/xterm.cfg
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/sb_v_double_arrow.png
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/top_right_corner.png
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/left_ptr.png
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/left_ptr.cfg
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/sb_h_double_arrow.png
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/sb_v_double_arrow.cfg
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/sb_h_double_arrow.cfg
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/top_right_corner.cfg
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/hand2.cfg
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/fleur.cfg
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/fleur.png
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/xterm.png
[delete] https://crrev.com/52c47ad3827844c61c24a4bdd63a2d9b7145d1cf/cursors/top_left_corner.png

Comment 3 by vapier@chromium.org, Jun 15 2018

Owner: vapier@chromium.org
Status: Fixed (was: Unconfirmed)
►

Sign in to add a comment