New issue
Advanced search Search tips

Issue 851197 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 851193



Sign in to add a comment

Memory: Make links to the source code more discoverable

Project Member Reported by alph@chromium.org, Jun 9 2018

Issue description

Currently it is possible to jump to the source code by clicking a lint in the tooltip. The link instead should be located next to the title.
 

Comment 1 by alph@chromium.org, Jun 23 2018

Screenshot from 2018-06-22 17-57-55.png
248 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26964d1bdd962d371fc11fb8d5427b5b3f36cb77

commit 26964d1bdd962d371fc11fb8d5427b5b3f36cb77
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Jun 25 22:08:50 2018

DevTools: Show source code links for function objects in heap snapshots.

The link was previous available in a tooltip which is barely discoverable.

BUG= 851197 

Change-Id: Ia69d0c9a2b39afe54b4802b9fd1a392104e150e0
Reviewed-on: https://chromium-review.googlesource.com/1112843
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570195}
[add] https://crrev.com/26964d1bdd962d371fc11fb8d5427b5b3f36cb77/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-function-location-expected.txt
[add] https://crrev.com/26964d1bdd962d371fc11fb8d5427b5b3f36cb77/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-function-location.js
[modify] https://crrev.com/26964d1bdd962d371fc11fb8d5427b5b3f36cb77/third_party/blink/renderer/devtools/front_end/heap_profiler_test_runner/HeapProfilerTestRunner.js
[modify] https://crrev.com/26964d1bdd962d371fc11fb8d5427b5b3f36cb77/third_party/blink/renderer/devtools/front_end/profiler/HeapProfileView.js
[modify] https://crrev.com/26964d1bdd962d371fc11fb8d5427b5b3f36cb77/third_party/blink/renderer/devtools/front_end/profiler/HeapSnapshotDataGrids.js
[modify] https://crrev.com/26964d1bdd962d371fc11fb8d5427b5b3f36cb77/third_party/blink/renderer/devtools/front_end/profiler/HeapSnapshotGridNodes.js
[modify] https://crrev.com/26964d1bdd962d371fc11fb8d5427b5b3f36cb77/third_party/blink/renderer/devtools/front_end/profiler/HeapSnapshotView.js
[modify] https://crrev.com/26964d1bdd962d371fc11fb8d5427b5b3f36cb77/third_party/blink/renderer/devtools/front_end/profiler/ProfileType.js
[modify] https://crrev.com/26964d1bdd962d371fc11fb8d5427b5b3f36cb77/third_party/blink/renderer/devtools/front_end/profiler/ProfilesPanel.js
[modify] https://crrev.com/26964d1bdd962d371fc11fb8d5427b5b3f36cb77/third_party/blink/renderer/devtools/front_end/profiler/heapProfiler.css
[modify] https://crrev.com/26964d1bdd962d371fc11fb8d5427b5b3f36cb77/third_party/blink/renderer/devtools/front_end/sdk/HeapProfilerModel.js

Status: Fixed (was: Assigned)

Sign in to add a comment