New issue
Advanced search Search tips

Issue 851195 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 851193



Sign in to add a comment

Memory: Replace heap snapshot color coding with tags.

Project Member Reported by alph@chromium.org, Jun 9 2018

Issue description

Instead of painting items with colored background (yellow/red) use e.g. tags next to the item title with tooltips explaining what's that.
 

Comment 1 by alph@chromium.org, Jun 21 2018

Status: Started (was: Assigned)
Screenshot from 2018-06-21 11-05-23.png
204 KB View Download
Screenshot from 2018-06-21 11-06-28.png
202 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14fa09fdfc00f3222a1e5574b2dd8821a2a90f7b

commit 14fa09fdfc00f3222a1e5574b2dd8821a2a90f7b
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Jun 22 00:31:56 2018

DevTools: Replace color coding in heap snapshots with tags

Yellow meant object is reachable from window.
Red meant a DOM object is detached from the tree.

BUG= 851195 

Change-Id: I4439f70fcbc00de7432673264405d4feb12124ba
Reviewed-on: https://chromium-review.googlesource.com/1109274
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569470}
[modify] https://crrev.com/14fa09fdfc00f3222a1e5574b2dd8821a2a90f7b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-ranges-expected.txt
[modify] https://crrev.com/14fa09fdfc00f3222a1e5574b2dd8821a2a90f7b/third_party/blink/renderer/devtools/front_end/profiler/HeapSnapshotGridNodes.js
[modify] https://crrev.com/14fa09fdfc00f3222a1e5574b2dd8821a2a90f7b/third_party/blink/renderer/devtools/front_end/profiler/heapProfiler.css

Status: Fixed (was: Started)

Sign in to add a comment