Convert Full and Incremental Builders to master / slave groups. |
|||
Issue descriptionWe need to convert incremental builders into a master/slave group for purposes of build affinity ( https://crbug.com/851152 ). However, it's difficult to experiment with them since adding a master builder requires removing the buildbot schedulers for them (on chromiumos waterfall), which requires a master restart. In general, it would be handy if all incremental and full builders built the same code, so that build results could be directly compared. So... I will convert both full and incremental builders to master/slave groups and start with the full builders since they are easier to experiment with.
,
Jun 11 2018
can we get clarity on design/expectations for the manifest? will they always use current master? or whatever the cq master last posted?
,
Jun 12 2018
My expectation is that they will build TOT master. Or more precisely.... The master builder will generate a pinned manifest based on TOT master which will be passed to all slaves to build. It's also my belief that this is similar to what these builders are already doing. I don't think we have any builders left that build the most recent successful CQ build, but I haven't really gone looking.
,
Jun 12 2018
that's not how we've been doing master/incremental builders so far, although i don't think we particularly care one way or the other in this regard. full/incremental bots are completely disconnected from each other and just run `repo sync` at every start. which is why issue 333398 shows up every once in a while (if a bot starts syncing in the middle of a CQ run). based on issue 851152 , the only reason to convert full/incremental to a master/slave approach is that you're adding affinity support to the CQ master, and you want to re-use that on the full/incremental side ?
,
Jun 12 2018
Incrementals require affinity, and converting them to master/slave seems like the easiest way to get there. I'm just using the full builders as a way to experiment until buildbucket support for affinity exists. Much, much, much lower priority, having the similar builders sync'd with each other makes it easier to understand failures, since the build results become compatible to each other. I've had feature requests for this in the past, especially for the Chrome informationals. But since disrupting the full builders for a day or two is the least disruptive, I thought I would test with them.
,
Jun 12 2018
This will also help prove out the ability to move PFQ/release master/slave groups to swarming without breaking anything, though CQ builders will have to wait for affinity.
,
Jun 12 2018
The reason that master/slave is needed for build affinity is because some logic needs to run somewhere (like the master) to get it to work. See https://crbug.com/851152 for details.
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/88f7143dc33268b65f776d994877225fc48a963e commit 88f7143dc33268b65f776d994877225fc48a963e Author: Don Garrett <dgarrett@google.com> Date: Tue Jun 12 21:40:40 2018 chromeos_config: Create a master-full builder. I'm not at all certain if this will work, but it's a reasonable attempt to create a master-full builder. it will need a matching update to the luci-scheduler configuration. BUG= chromium:851183 TEST=run_tests Change-Id: I78e1c90e3423fb9e22c99c350da60a45a5d6de2b Reviewed-on: https://chromium-review.googlesource.com/1093638 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/88f7143dc33268b65f776d994877225fc48a963e/config/chromeos_config.py [modify] https://crrev.com/88f7143dc33268b65f776d994877225fc48a963e/config/waterfall_layout_dump.txt [modify] https://crrev.com/88f7143dc33268b65f776d994877225fc48a963e/config/config_dump.json [modify] https://crrev.com/88f7143dc33268b65f776d994877225fc48a963e/config/chromeos_config_unittest.py
,
Jun 12 2018
There is a build running: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8943888761872352016 It hasn't finished (or even launched slaves), but I see a problem already: 14:57:48: INFO: Publishing with commit message: Automatic: Start master-full master 10777.0.0 CrOS-Build-Id: 2659231 RELEASETAG: 10777.0.0 BUILDROOT: /b/swarming/w/ir/cache/cbuild/repository TRACKING BRANCH: master NEXT MANIFEST: /b/swarming/w/ir/cache/cbuild/repository/manifest-versions-internal/buildspecs/69/10777.0.0.xml It has incremental the ChromeOS version number globally, and has published the build spec as if this was a release build. More interestingly, it has published an EXTERNAL manifest as if it was a release version.
,
Jun 12 2018
If also totally failed to schedule any slave builds. Sigh.
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27be6b1ef3b058857db3f94f7fb04343127720f1 commit 27be6b1ef3b058857db3f94f7fb04343127720f1 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Jun 13 04:06:50 2018 Roll src/third_party/chromite 51360dbda4aa..11376cfc6fe9 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/51360dbda4aa..11376cfc6fe9 git log 51360dbda4aa..11376cfc6fe9 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 dgarrett@google.com chromeos_config: Mark assorted standalone builders important. 2018-06-12 dgarrett@google.com chromeos_config: Create a master-full builder. Created with: gclient setdep -r src/third_party/chromite@11376cfc6fe9 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:851183 TBR=chrome-os-gardeners@chromium.org Change-Id: Icad4a216ddef676124ce5ef2227e94d120c41c79 Reviewed-on: https://chromium-review.googlesource.com/1098435 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566714} [modify] https://crrev.com/27be6b1ef3b058857db3f94f7fb04343127720f1/DEPS
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9d6cdfe69f6456e4b3bb2e75e86ef3c19a4c37c1 commit 9d6cdfe69f6456e4b3bb2e75e86ef3c19a4c37c1 Author: Don Garrett <dgarrett@google.com> Date: Thu Jun 14 00:27:20 2018 master-full: Add better master/slave support for FULL_TYPE. This renames BUILD_FROM_SOURCE_TYPE to FULL_TYPE, and adds master/slave support for FULL_TYPE to SimpleBuilder and LKGMManager. It also adjusts master-full to only sync external code to start with, and tweaks a unittest to be okay with that. BUG= chromium:851183 TEST=run_tests Change-Id: I71672165db2aabce4d4fca6ffc3460312426aab2 Reviewed-on: https://chromium-review.googlesource.com/1098466 Trybot-Ready: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/9d6cdfe69f6456e4b3bb2e75e86ef3c19a4c37c1/config/chromeos_config.py [modify] https://crrev.com/9d6cdfe69f6456e4b3bb2e75e86ef3c19a4c37c1/cbuildbot/prebuilts.py [modify] https://crrev.com/9d6cdfe69f6456e4b3bb2e75e86ef3c19a4c37c1/config/config_dump.json [modify] https://crrev.com/9d6cdfe69f6456e4b3bb2e75e86ef3c19a4c37c1/config/chromeos_config_unittest.py [modify] https://crrev.com/9d6cdfe69f6456e4b3bb2e75e86ef3c19a4c37c1/cbuildbot/builders/simple_builders.py [modify] https://crrev.com/9d6cdfe69f6456e4b3bb2e75e86ef3c19a4c37c1/lib/constants.py [modify] https://crrev.com/9d6cdfe69f6456e4b3bb2e75e86ef3c19a4c37c1/cbuildbot/lkgm_manager.py
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fdada6c28d349e63ed16c3de4a4ea06c6823e4e commit 6fdada6c28d349e63ed16c3de4a4ea06c6823e4e Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Jun 14 05:35:04 2018 Roll src/third_party/chromite 402795d084bf..17b4574e14a3 (8 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/402795d084bf..17b4574e14a3 git log 402795d084bf..17b4574e14a3 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 chrome-bot@chromium.org Update config settings by config-updater. 2018-06-14 dgarrett@google.com master-full: Add better master/slave support for FULL_TYPE. 2018-06-14 bpastene@chromium.org cros_run_vm_test: Fix --host-cmd and --autotest cmd args. 2018-06-14 lannm@chromium.org Make FindOverlays output have deterministic ordering 2018-06-14 lannm@chromium.org Fix cros_mark_as_stable for CLs that create overlays 2018-06-13 ihf@chromium.org chromeos_config: make betty-arcnext important. 2018-06-13 bmgordon@chromium.org cros_sdk_lib: Reduce version warning to debug 2018-06-13 bmgordon@chromium.org cros_sdk: Add a --unmount action Created with: gclient setdep -r src/third_party/chromite@17b4574e14a3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:851183 ,chromium:None,chromium:851059,chromium:851059,chromium:834412,chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: I247744af7bf25889f89c57eee10cf8568af22542 Reviewed-on: https://chromium-review.googlesource.com/1100319 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567155} [modify] https://crrev.com/6fdada6c28d349e63ed16c3de4a4ea06c6823e4e/DEPS
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/2d37b8426f1945b124cec6c0633de2ad181ac57d commit 2d37b8426f1945b124cec6c0633de2ad181ac57d Author: Don Garrett <dgarrett@google.com> Date: Thu Jun 14 17:15:44 2018 luci-scheduler: Add external incremental builders. These are the only two builders on the external waterfall being scheduled by builder. Convert them to LUCI Scheduler so that we can direct control in scheduler web interface, like we already do for the internal incrementals. Rollout plan: Land this CL. Pause the schedulers. Remove the buildbot schedulers. Restart chromiumos. Unpause the schedulers. BUG= chromium:851183 TEST=None Change-Id: Idb6962a40d6088799e00feeb4a01884824863648 Reviewed-on: https://chromium-review.googlesource.com/1093586 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Nichols <mikenichols@chromium.org> [modify] https://crrev.com/2d37b8426f1945b124cec6c0633de2ad181ac57d/luci-scheduler.cfg
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/f4880d84ba8ecea1d21965f68c6d5d4036f26ac3 commit f4880d84ba8ecea1d21965f68c6d5d4036f26ac3 Author: Don Garrett <dgarrett@google.com> Date: Thu Jun 14 17:19:15 2018 master.chromiumos: Remove incremental build schedulers. We're moving scheduling of incremental builders to LUCI Scheduler, so no need for it here. BUG= chromium:851183 Change-Id: Ia7070fee0e08b20ebe2b1667d81298619ca75b96 Reviewed-on: https://chromium-review.googlesource.com/1094144 Reviewed-by: Mike Nichols <mikenichols@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/f4880d84ba8ecea1d21965f68c6d5d4036f26ac3/masters/master.chromiumos/master.cfg
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/54899e2b1191bc08112ace62aede75fb6a8a61cb commit 54899e2b1191bc08112ace62aede75fb6a8a61cb Author: Don Garrett <dgarrett@google.com> Date: Thu Jun 14 20:43:47 2018 chromeos_config: Make master-full internal. It seems that external master builders really don't work well, so re-enable the unittest to prevent them, and make master-full internal. This should mean that it will produce both internal and external build manifests. The internal one will end up being ignored, but now that they have been moved into a unique location. should be safe. BUG= chromium:851183 TEST=run_tests Change-Id: I1f2d415fba8d42e2e92ad87219cd334d160198d2 Reviewed-on: https://chromium-review.googlesource.com/1101471 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/54899e2b1191bc08112ace62aede75fb6a8a61cb/config/chromeos_config.py [modify] https://crrev.com/54899e2b1191bc08112ace62aede75fb6a8a61cb/config/config_dump.json [modify] https://crrev.com/54899e2b1191bc08112ace62aede75fb6a8a61cb/config/chromeos_config_unittest.py
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c593dc0ae14cdff73228974b68ba568c7b5823c8 commit c593dc0ae14cdff73228974b68ba568c7b5823c8 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Jun 14 23:22:39 2018 Roll src/third_party/chromite de5f8a610a0a..54899e2b1191 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/de5f8a610a0a..54899e2b1191 git log de5f8a610a0a..54899e2b1191 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 dgarrett@google.com chromeos_config: Make master-full internal. Created with: gclient setdep -r src/third_party/chromite@54899e2b1191 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:851183 TBR=chrome-os-gardeners@chromium.org Change-Id: I9b361d8a58e4d7ed2d365fed15745286938f444d Reviewed-on: https://chromium-review.googlesource.com/1101659 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567473} [modify] https://crrev.com/c593dc0ae14cdff73228974b68ba568c7b5823c8/DEPS
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ce952677d6479a10a3c404d2dc52e790773d23c3 commit ce952677d6479a10a3c404d2dc52e790773d23c3 Author: Don Garrett <dgarrett@google.com> Date: Fri Jun 15 13:32:32 2018 config_lib: Remove most UseBuildbucketScheduler hardcoding. The helper function UseBuildbucketScheduler can't easily be removed, but we can remove it's hard coded values, since we know that all master builders use buildbucket scheduling. Leave the PreCQLauncher as a hardcoded special case, because I'm not sure if removing it would break anything or not. Remove ScheduledByBuildbucket while touching the area, since nothing uses it. Filed chromium:853025 about removing UseBuildbucketScheduler, since it's a good proxy for buildbot specific logic that is already obsolete. BUG= chromium:851183 TEST=run_tests Change-Id: I815eb190c724f319e0f2f73c6d6a1ba2f391ab0e Reviewed-on: https://chromium-review.googlesource.com/1101972 Tested-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/ce952677d6479a10a3c404d2dc52e790773d23c3/lib/config_lib_unittest.py [modify] https://crrev.com/ce952677d6479a10a3c404d2dc52e790773d23c3/lib/config_lib.py
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc19a68d8c328a27cb8ab073ee20b8c42050df0e commit bc19a68d8c328a27cb8ab073ee20b8c42050df0e Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 15 14:37:45 2018 Roll src/third_party/chromite 90d481078b9b..ce952677d647 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/90d481078b9b..ce952677d647 git log 90d481078b9b..ce952677d647 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 dgarrett@google.com config_lib: Remove most UseBuildbucketScheduler hardcoding. Created with: gclient setdep -r src/third_party/chromite@ce952677d647 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:851183 TBR=chrome-os-gardeners@chromium.org Change-Id: Ic2db98b3dbf6ef5b994dfbda8e019d03e507cf82 Reviewed-on: https://chromium-review.googlesource.com/1102401 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567644} [modify] https://crrev.com/bc19a68d8c328a27cb8ab073ee20b8c42050df0e/DEPS
,
Jun 15 2018
Still not working, this time it seems to be an issue with how version strings are computed: [1;31m06:55:06: ERROR: Master build id 2667164 has full_version R69-10785.0.0-rc1, while slave version is R69-10785.0.0-b2667184.[0m
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/fce86c8bcb74eaaad2940a93f6ee99d29fec3a15 commit fce86c8bcb74eaaad2940a93f6ee99d29fec3a15 Author: Don Garrett <dgarrett@google.com> Date: Fri Jun 15 21:20:54 2018 chromeos_config: Switch full builders to manifest_version. Switch the sync stage used for full builders to allow master/slave versioned syncing. BUG= chromium:851183 TEST=run_tests Change-Id: Idb4b942f81729b91581d91aeca1e0b147189d0fe Reviewed-on: https://chromium-review.googlesource.com/1103000 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/fce86c8bcb74eaaad2940a93f6ee99d29fec3a15/config/chromeos_config.py [modify] https://crrev.com/fce86c8bcb74eaaad2940a93f6ee99d29fec3a15/config/config_dump.json
,
Jun 15 2018
I believe the current master run is working correctly, though it hasn't finished yet. https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8943618475956687856
,
Jun 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0496b4e506eb35f69d49007198fa1e666d5646df commit 0496b4e506eb35f69d49007198fa1e666d5646df Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Jun 16 15:52:18 2018 Roll src/third_party/chromite 3a51f2a80a38..ae92f3c98fbe (10 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/3a51f2a80a38..ae92f3c98fbe git log 3a51f2a80a38..ae92f3c98fbe --date=short --no-merges --format='%ad %ae %s' 2018-06-16 chrome-bot@chromium.org Update config settings by config-updater. 2018-06-16 dgarrett@google.com chromeos_config: Require all non-slaves to be important. 2018-06-15 lannm@chromium.org Annotate ScheduleSlavesStage with scheduled build links 2018-06-15 dgarrett@google.com generic_stages: Stop tagging skipped stages. 2018-06-15 dgarrett@google.com chromeos_config: Switch full builders to manifest_version. 2018-06-15 manojgupta@chromium.org Revert "chrome-sdk: Remove absolute path from simple chrome build using goma" 2018-06-15 xixuan@chromium.org SkylabHWTest: Swtich to use nyan_blaze release image to test. 2018-06-15 vapier@chromium.org cros lint: ignore initial UTF-8 BOM in JSON files 2018-06-15 ayatane@chromium.org chromeos-infra-go: Disable tests 2018-06-15 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@ae92f3c98fbe The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:852600,chromium:852916,chromium:851183,chromium:824548,chromium:846610,chromium:845314,chromium:None,chromium:852633 TBR=chrome-os-gardeners@chromium.org Change-Id: Id646fa70fc50cd3fd10506b67812fb6782bfdf36 Reviewed-on: https://chromium-review.googlesource.com/1103501 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567895} [modify] https://crrev.com/0496b4e506eb35f69d49007198fa1e666d5646df/DEPS
,
Jun 18 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/156087a40e75fe3b273ca885316c7ae29fdda08d commit 156087a40e75fe3b273ca885316c7ae29fdda08d Author: Don Garrett <dgarrett@google.com> Date: Mon Jun 18 18:57:29 2018
,
Jun 18 2018
Full builders have been converted.
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5831b835bc152c8dd7e10266912ffc16f37b5730 commit 5831b835bc152c8dd7e10266912ffc16f37b5730 Author: Don Garrett <dgarrett@google.com> Date: Wed Jun 20 21:23:47 2018 chromeos_config: Create master-incremental. Using lessons learns from master-full, create a master-incremental builder. This will break the individual incremental builders until it's deployed. This new builder will run as a swarming builder, but schedule the incrementals against the chromeos and chromiumos waterfalls. BUG= chromium:851183 TEST=run_tests Change-Id: Id4205fe6adac655661b7f749784b63ebb384f18c Reviewed-on: https://chromium-review.googlesource.com/1105475 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/5831b835bc152c8dd7e10266912ffc16f37b5730/config/chromeos_config.py [modify] https://crrev.com/5831b835bc152c8dd7e10266912ffc16f37b5730/config/waterfall_layout_dump.txt [modify] https://crrev.com/5831b835bc152c8dd7e10266912ffc16f37b5730/config/config_dump.json [modify] https://crrev.com/5831b835bc152c8dd7e10266912ffc16f37b5730/config/chromeos_config_unittest.py [modify] https://crrev.com/5831b835bc152c8dd7e10266912ffc16f37b5730/cbuildbot/builders/simple_builders.py [modify] https://crrev.com/5831b835bc152c8dd7e10266912ffc16f37b5730/cbuildbot/lkgm_manager.py
,
Jun 20 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/88fc8d4ae28f2bdafe264ec41273b09a413fe4fb commit 88fc8d4ae28f2bdafe264ec41273b09a413fe4fb Author: Don Garrett <dgarrett@google.com> Date: Wed Jun 20 21:43:13 2018
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62a28772aba9ff619580f8f376dab2a9b20eaad0 commit 62a28772aba9ff619580f8f376dab2a9b20eaad0 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Jun 21 00:00:46 2018 Roll src/third_party/chromite c4424eb6803d..5831b835bc15 (7 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/c4424eb6803d..5831b835bc15 git log c4424eb6803d..5831b835bc15 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 dgarrett@google.com chromeos_config: Create master-incremental. 2018-06-20 vapier@chromium.org pylintrc: enable bad-builtin for apply & input 2018-06-20 vapier@chromium.org pylintrc: stop disabling exec-used 2018-06-20 dgarrett@google.com builder_status: Remove config_lib.UseBuildbucketScheduler. 2018-06-20 dgarrett@google.com cbuildbot/stages: Remove config_lib.UseBuildbucketScheduler. 2018-06-20 dgarrett@google.com simpler_builder: Remove config_lib.UseBuildbucketScheduler. 2018-06-20 dgarrett@google.com repository: Log cleanup methods. Created with: gclient setdep -r src/third_party/chromite@5831b835bc15 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:851183 ,chromium:None,chromium:None,chromium:853025,chromium:853025,chromium:853025,chromium:853949 TBR=chrome-os-gardeners@chromium.org Change-Id: Ib0d09c8c2eb5246e5e9e7eaa7011ca8f33d7d333 Reviewed-on: https://chromium-review.googlesource.com/1109097 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569096} [modify] https://crrev.com/62a28772aba9ff619580f8f376dab2a9b20eaad0/DEPS
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5c1b5323374607ac699cb90e3452ddf629305d70 commit 5c1b5323374607ac699cb90e3452ddf629305d70 Author: Don Garrett <dgarrett@google.com> Date: Thu Jun 21 23:37:01 2018 luci-scheduler: Remove standalone incremental builders. The incremental builders have been converted to a master/slave group which is triggered from the ChromeOS LUCI Scheduler instance, so there is no need for these individual build schedulers. BUG= chromium:851183 TEST=None Change-Id: I7a337abec4f44891092a7e32e9c51ddcaed92946 Reviewed-on: https://chromium-review.googlesource.com/1108964 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Nichols <mikenichols@chromium.org> [modify] https://crrev.com/5c1b5323374607ac699cb90e3452ddf629305d70/luci-scheduler.cfg
,
Jun 21 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dgarr...@chromium.org
, Jun 8 2018Status: Started (was: Untriaged)