Bottom toolbar hides "Google uses your location..." bottom popup |
||||
Issue description
Chrome Version: M69
OS: Android
What steps will reproduce the problem?
(1) Go to chrome://flags and turn on #enable-chrome-duplex flag
(2) Google search for something.
(3) Notice that there is a menu hiding behind the bottom toolbar
(only the top of it is visible). Scroll down to hide the
bottom toolbar and you can see the location sharing popup.
What is the expected result?
Not sure. But we'd probably want to show the location sharing popup
above the bottom toolbar so they are both visible.
What happens instead?
The bottom toolbar is occluding the location sharing menu.
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e980559e29326a090e1689ab847d7957a6570508 commit e980559e29326a090e1689ab847d7957a6570508 Author: Matthew Jones <mdjones@chromium.org> Date: Tue Jun 12 00:17:38 2018 Fix bottom container offset from bottom UI This patch correctly applies offsets generated by the bottom sheet and the bottom toolbar to the bottom container (infobars and snackbars). Previously, the offsets from the bottom sheet and the bottom toolbar were combined (since they used to be a single UI). For the bottom sheet, the offset was in the wrong direction and applied the shadow offset even when hidden. Bug: 851182 Change-Id: I812f384cff0230b08518c035a6c3a8aa32ff95c7 Reviewed-on: https://chromium-review.googlesource.com/1095546 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#566223} [modify] https://crrev.com/e980559e29326a090e1689ab847d7957a6570508/chrome/android/java/src/org/chromium/chrome/browser/snackbar/BottomContainer.java
,
Jun 12 2018
,
Jun 12 2018
Still reproducible
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a4de1d23f8fd69331d83a142109e3cfcc8b7a89 commit 8a4de1d23f8fd69331d83a142109e3cfcc8b7a89 Author: Matthew Jones <mdjones@chromium.org> Date: Wed Jun 13 23:27:17 2018 Remove initialization of Y offset in BottomContainer In the BottomContainer, in order to handle sitting on top of multiple different UIs, the setTranslationY function is overridden to apply offsets independently of the view's original translation. This was broken because the initialization logic also attempted to apply this offset. This patch updates the incorrect call in the init function and updates the math in setTranslationY. Bug: 851182 Change-Id: Id4955aed45b91cd55a3baf4c70f8087a65123f24 Reviewed-on: https://chromium-review.googlesource.com/1099772 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#567044} [modify] https://crrev.com/8a4de1d23f8fd69331d83a142109e3cfcc8b7a89/chrome/android/java/src/org/chromium/chrome/browser/snackbar/BottomContainer.java
,
Jun 14 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mdjones@chromium.org
, Jun 11 2018Owner: mdjones@chromium.org
Status: Assigned (was: Available)