New issue
Advanced search Search tips

Issue 851177 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature



Sign in to add a comment

Support the option to upload multiple commits on a branch as separate commits

Project Member Reported by cmtm@chromium.org, Jun 8 2018

Issue description

"git cl upload" squashes commits on a branch into a single one when uploading to gerrit. I would like an option to support uploading them as individual gerrit CLs. I would also like a separate option that controls whether these newly created gerrit CLs are dependent on each other (the dependency tree mirroring the git commit ancestries).

Though the documentation isn't clear, it seems that "git cl upload --no-squash" is supposed to support this, but the commits still get squashed when using this option.
 

Comment 1 by aga...@chromium.org, Jun 21 2018

Cc: aga...@chromium.org
 Issue 855228  has been merged into this issue.

Comment 2 by aga...@chromium.org, Jun 21 2018

A couple comments here:
1) --no-squash is only partially supported in the first place (many git-cl features, such as tracking dependencies between local branches, are disabled in that mode)
2) if --no-squash isn't working for you, please provide a replication case so we can debug that
3) --no-squash will never support breaking the dependencies between the commits in your local branch, sorry. --no-squash is intended to better emulate the default gerrit behavior (one CL per commit), not to overshoot and do something on the far side of that behavior.

Comment 3 by cmtm@chromium.org, Jun 25 2018

Status: WontFix (was: Untriaged)
I just tried --no-squash and it worked. It seems the issue was fixed sometime between when I last tried it and now. I'll close this bug.

Sign in to add a comment