https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalSmallerThanActualSize (scroll to the bottom) This test crashes on every other run or so, then succeeds on retries. Please disable it or fix it soon.
The "large" one flakes too. Dashboard linke: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalLargerThanActualSize It did right on the waterfall: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8944253885834520128%2F%2B%2Fsteps%2Fbrowser_tests_on_Mac-10.12%2F0%2Flogs%2FBackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalLargerThanActualSize%2F0 [ RUN ] BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalLargerThanActualSize [31054:3843:0608/141017.469181:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated. [31054:84227:0608/141018.090801:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico [31054:775:0608/141018.105177:INFO:CONSOLE(44)] "sendResultToTest: ok - service worker registered", source: https://127.0.0.1:64956/result_queue.js (44) [31054:775:0608/141018.108338:INFO:CONSOLE(44)] "sendResultToTest: ok", source: https://127.0.0.1:64956/result_queue.js (44) [31054:34563:0608/141022.948006:WARNING:quarantine_mac.mm(202)] MDItemCreate failed for path /private/var/folders/2j/22s2gz0s7hn48k32d47clxf80000gm/T/.org.chromium.Chromium.GjM76F/dS8FviJ/Default/Download Service/Files/2e995325-130e-42a3-b8d8-390bbbfd8b60 BrowserTestBase received signal: Segmentation fault: 11. Backtrace: 0 browser_tests 0x0000000107d50ecc base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests 0x00000001082eaf95 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 229 2 libsystem_platform.dylib 0x00007fffbb545b3a _sigtramp + 26 3 ??? 0x0000000000000000 0x0 + 0 4 browser_tests 0x00000001068cadfa content::CacheStorageManager::DeleteCache(url::Origin const&, content::CacheStorageOwner, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::OnceCallback<void (blink::mojom::CacheStorageError)>) + 26 5 browser_tests 0x0000000106861467 content::background_fetch::DeleteRegistrationTask::Start() + 455 6 browser_tests 0x0000000106851d04 content::BackgroundFetchDataManager::DeleteRegistration(content::BackgroundFetchRegistrationId const&, base::OnceCallback<void (blink::mojom::BackgroundFetchError)>) + 212 7 browser_tests 0x000000010684ef81 content::BackgroundFetchContext::LastObserverGarbageCollected(content::BackgroundFetchRegistrationId const&) + 97 8 browser_tests 0x0000000106858c1d content::BackgroundFetchRegistrationNotifier::OnConnectionError(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, blink::mojom::BackgroundFetchRegistrationObserver*) + 221 9 browser_tests 0x0000000108da75c3 mojo::InterfaceEndpointClient::NotifyError(base::Optional<mojo::DisconnectReason> const&) + 163 10 browser_tests 0x0000000108dab533 mojo::internal::MultiplexRouter::ProcessNotifyErrorTask(mojo::internal::MultiplexRouter::Task*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) + 195 11 browser_tests 0x0000000108da99ff mojo::internal::MultiplexRouter::ProcessTasks(mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) + 447 12 browser_tests 0x0000000108da87ed mojo::internal::MultiplexRouter::OnPipeConnectionError() + 797 13 browser_tests 0x0000000108da48b4 mojo::Connector::HandleError(bool, bool) + 372 14 browser_tests 0x0000000108364a38 mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) + 248 15 browser_tests 0x0000000108364c81 mojo::SimpleWatcher::Context::Notify(unsigned int, MojoHandleSignalsState, unsigned int) + 401 16 browser_tests 0x00000001083641e0 mojo::SimpleWatcher::Context::CallNotify(MojoTrapEvent const*) + 32 17 browser_tests 0x00000001065e47f9 mojo::edk::WatcherDispatcher::InvokeWatchCallback(unsigned long, unsigned int, mojo::edk::HandleSignalsState const&, unsigned int) + 89 18 browser_tests 0x00000001065e40ec mojo::edk::Watch::InvokeCallback(unsigned int, mojo::edk::HandleSignalsState const&, unsigned int) + 76 19 browser_tests 0x00000001065e088d mojo::edk::RequestContext::~RequestContext() + 301 20 browser_tests 0x00000001065d6b4f mojo::edk::NodeChannel::OnChannelError(mojo::edk::Channel::Error) + 367 21 browser_tests 0x00000001065e9268 mojo::edk::(anonymous namespace)::ChannelPosix::OnFileCanReadWithoutBlocking(int) + 616 22 browser_tests 0x0000000107d607a5 base::MessagePumpLibevent::OnLibeventNotification(int, short, void*) + 197 23 browser_tests 0x000000010893e1dc event_base_loop + 1196 24 browser_tests 0x0000000107d6098f base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) + 127 25 browser_tests 0x0000000107cf4e75 base::RunLoop::Run() + 53 26 browser_tests 0x000000010689df84 content::BrowserProcessSubThread::IOThreadRun(base::RunLoop*) + 20 27 browser_tests 0x0000000107d28e1d base::Thread::ThreadMain() + 381 28 browser_tests 0x0000000107d5a3d7 base::(anonymous namespace)::ThreadFunc(void*) + 87 29 libsystem_pthread.dylib 0x00007fffbb54f93b _pthread_body + 180 30 libsystem_pthread.dylib 0x00007fffbb54f887 _pthread_body + 0 31 libsystem_pthread.dylib 0x00007fffbb54f08d thread_start + 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/544227752f568f6ef49b4567adc6515412904c96 commit 544227752f568f6ef49b4567adc6515412904c96 Author: Rayan Kanso <rayankans@chromium.org> Date: Fri Jun 22 19:07:05 2018 Change CacheStorageManager in context from unique_ptr to scoped_refptr. Now that CacheStorage can have multiple clients/owners, some of them will need access to the CacheStorageManager after shutdown to wrap up their tasks. This CL changes the CacheStorageManager member in CacheStorageContextImpl to a scoped_refptr, so that if there are any references after the shutdown was initiated, systems that hold a reference can finish their tasks without crashing. Bug: 851164 , 851229 Change-Id: I3226e79325adce62594de2135ab4450f463b5eac Reviewed-on: https://chromium-review.googlesource.com/1095261 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#569722} [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_context.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_data_manager.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_data_manager.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_data_manager_unittest.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_test_data_manager.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/background_fetch_test_data_manager.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/cleanup_task.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/cleanup_task.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/database_task.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/database_task.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/delete_registration_task.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/delete_registration_task.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/get_settled_fetches_task.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/get_settled_fetches_task.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/mark_request_complete_task.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/background_fetch/storage/mark_request_complete_task.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/README.md [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/cache_storage_context_impl.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/cache_storage_context_impl.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/cache_storage_manager.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/cache_storage_manager.h [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/cache_storage/cache_storage_manager_unittest.cc [modify] https://crrev.com/544227752f568f6ef49b4567adc6515412904c96/content/browser/storage_partition_impl.cc
These have been fixed now, closing the bug.
Comment 1 by mpear...@chromium.org
, Jun 8 2018