Expected drop in empty minidump in background app from unexpected value |
|||
Issue descriptionThe metric "empty minidump in background app" recorded as part of Tab.RendererDetailedExitStatus should be 0 since the metric is only recorded in foreground app. But this was not 0 till M66. It magically got to ~0 in M67. There is a similar increase in the same reocrd in Tab.RendererDetailedExitStatusUnbound. The check for app being foreground is done by checking base::TERMINATION_STATUS_OOM_PROTECTED, which is set when app is foreground when launcher get notified that process died. The check for app being background is done by checking app_state when minidump was processed. Metric: https://uma.googleplex.com/p/chrome/timeline_v2/?sid=af39b242b6a6eb523fc27104cc0a084f The range on Canary where it dropped: https://chromium.googlesource.com/chromium/src/+log/67.0.3367.0..67.0.3371.0?pretty=fuller&n=10000 Probable CL that caused the drop: https://chromium.googlesource.com/chromium/src/+/b0d842c16cd2f8e67ae2689c2d906e1855b1b571 This cl fixes the spare renderer process started in custom tab app to be background instead of foreground. The guess is that we have not fixed the foreground vs background check issue. But we stopped the crashes to be not oom protected when app is in that state.
,
Jun 8 2018
,
Jun 12 2018
It seems like the cl is the cause. We were probably recording spare renderer crashes in this metric. We used to initialize sApplicationInForeground = true. So, before activity is started, the application is in foreground, and a spare renderer crash will be recorded as empty minidump in background app. |
|||
►
Sign in to add a comment |
|||
Comment 1 by ssid@chromium.org
, Jun 8 2018