[Flaky test] PartitionReallocReturnNullTest.RepeatedReturnNullDirect |
||||
Issue description
Repros easily locally on Windows Z840 with a Release (dcheck-always-on) build.
out\Release\base_unittests.exe --test-launcher-jobs=42 --gtest_filter=Partition*
[ RUN ] PartitionReallocReturnNullTest.RepeatedReturnNullDirect
Received fatal exception 0xe0000008
Backtrace:
RaiseException [0x74FAAA12+62]
base::internal::PartitionRootBase::OutOfMemory [0x69311C5F+3f] (D:\src\chrome\src\base\allocator\partition_allocator\partition_root_base.cc:1b)
base::internal::PartitionBucket::SlowPathAlloc [0x693102FA+154a] (D:\src\chrome\src\base\allocator\partition_allocator\partition_bucket.cc:20f)
base::PartitionRootGeneric::Alloc [0x69274165+635] (D:\src\chrome\src\base\allocator\partition_allocator\partition_alloc.h:152)
(No symbol) [0x0140752E]
(No symbol) [0x0140803F]
(No symbol) [0x0142C9E0]
(No symbol) [0x0142D205]
(No symbol) [0x0142D6AB]
(No symbol) [0x014339B2]
(No symbol) [0x0143363C]
(No symbol) [0x014A5D3A]
(No symbol) [0x00DE6FD1]
(No symbol) [0x014A6DDF]
(No symbol) [0x014A6CA4]
(No symbol) [0x014A5AE7]
(No symbol) [0x014B895B]
BaseThreadInitThunk [0x744B62C4+24]
RtlSubscribeWnfStateChangeNotification [0x77A20FA9+439]
RtlSubscribeWnfStateChangeNotification [0x77A20F74+404]
[31/31] PartitionReallocReturnNullTest.RepeatedReturnNullDirect (CRASHED)
,
Jun 8 2018
,
Jun 19 2018
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6141b62823099c694931a7a572b977e7ccee1488 commit 6141b62823099c694931a7a572b977e7ccee1488 Author: Ryan Harrison <rharrison@chromium.org> Date: Mon Jun 25 15:11:28 2018 Convert users of DoReturnNullTest to be death tests This worker function is designed to test the behaviour of the partition allocator by restricting the amount of memory available and then intentionally exhausting it. Doing this leaves some of the global state associated with the allocator in a bad state. Thus these tests are non-hermetic. This Cl wraps up the call to the work function in a EXPECT_DEATH to force the test to be run its own process, which prevents the tests from poluting other tests. This removes the need to have them in their own class and eliminates the flakiness being seen, since run order no longer affects the viability of future test cases. BUG= chromium:851148 Change-Id: I6d63b769d73c0e725a4e0c811d816b62ad15d57b Reviewed-on: https://chromium-review.googlesource.com/1106602 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#570041} [modify] https://crrev.com/6141b62823099c694931a7a572b977e7ccee1488/base/allocator/partition_allocator/partition_alloc_unittest.cc [modify] https://crrev.com/6141b62823099c694931a7a572b977e7ccee1488/chromecast/BUILD.gn
,
Jun 25 2018
,
Jul 12
|
||||
►
Sign in to add a comment |
||||
Comment 1 by gab@chromium.org
, Jun 8 2018