New issue
Advanced search Search tips

Issue 851125 link

Starred by 1 user
Status: Fixed
Owner:
pfeldman@chromium.org
Closed: Sep 19
Cc:
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Deploy headless_shell snapshot next to content_shell in the continuous builders.

Project Member Reported by pfeldman@chromium.org, Jun 8 2018 
Headless chromium can be built as a separate binary, "headless_shell".

We have a builder that builds it continuously:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Headless%20Linux%20%28dbg%29

We would like to build a release version of headless_shell and make it available as a zip file next to chrome and content_shell at https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html.

What would it take to make it happen?

Comment 1 by bpastene@chromium.org, Jun 9 2018

Owner: pfeldman@chromium.org
Status: Assigned (was: Untriaged)
This is the bot that uploads linux release artifacts:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20x64

Looks like it builds "all" (so it should already be building headless_shell):
https://chromium.googlesource.com/chromium/src/+/master/testing/buildbot/waterfalls.pyl#17

To add a new zip file, you'll have to describe it using the given format in:
https://codesearch.chromium.org/chromium/src/chrome/tools/build/linux/FILES.cfg

Once it's defined, the bot should start uploading it automatically.

That seems rather self-service, yeah? Assigning it back to you to care of it. If you have any trouble or questions, feel free to punt it back to us.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/129f7f0e23081ac80baa3c5d4bcba88f70cb580e

commit 129f7f0e23081ac80baa3c5d4bcba88f70cb580e
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Thu Jun 14 21:02:16 2018

Deploy headless_shell binaries as headless-shell.zip.

Similarly to content_shell, deploys headless_shell as a zip archive.

Bug:  851125 
Change-Id: Ie5403eb8912dcd1556c87b5da33b5552fa8c7d50
Reviewed-on: https://chromium-review.googlesource.com/1099759
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567414}
[modify] https://crrev.com/129f7f0e23081ac80baa3c5d4bcba88f70cb580e/chrome/tools/build/linux/FILES.cfg

Comment 3 by pfeldman@chromium.org, Sep 19

Status: Fixed (was: Assigned)
►

Sign in to add a comment