https://chromium-review.googlesource.com/c/chromium/src/+/1093658

This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba15a027e9cf52297f042900e5a92a5d2696bbbe

commit ba15a027e9cf52297f042900e5a92a5d2696bbbe
Author: Ryan Landay <rlanday@chromium.org>
Date: Mon Jun 11 22:00:23 2018

Fix incognito toggle in Android horizontal tab switcher with no tabs open

Currently, tapping the incognito toggle button in the new Android horizontal tab
switcher does not correctly change the tab switcher's background color if there
are no tabs opened. This is because neither the switch away nor switch to
animations run in this case and we therefore never called
Layout#requestUpdate().

This CL fixes this issue by adding a call to requestUpdate() in
StackLayout#onTabModelSwitched().

Bug:  851124 ,831359
Change-Id: Ib1b6c6e2679a67bec3bf6291ab62d2aba25917cf
Reviewed-on: https://chromium-review.googlesource.com/1093658
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566164}
[modify] https://crrev.com/ba15a027e9cf52297f042900e5a92a5d2696bbbe/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java

Issue 851511 has been merged into this issue.

Please verify in canary

Verified in 69.0.3456.0

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0449ed6e1f4ac06093d8aee87375e4641ccf1fb2

commit 0449ed6e1f4ac06093d8aee87375e4641ccf1fb2
Author: Ryan Landay <rlanday@chromium.org>
Date: Thu Jun 14 20:59:21 2018

Fix incognito toggle in Android horizontal tab switcher with no tabs open

Currently, tapping the incognito toggle button in the new Android horizontal tab
switcher does not correctly change the tab switcher's background color if there
are no tabs opened. This is because neither the switch away nor switch to
animations run in this case and we therefore never called
Layout#requestUpdate().

This CL fixes this issue by adding a call to requestUpdate() in
StackLayout#onTabModelSwitched().

Bug:  851124 ,831359
Change-Id: Ib1b6c6e2679a67bec3bf6291ab62d2aba25917cf
Reviewed-on: https://chromium-review.googlesource.com/1093658
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566164}(cherry picked from commit ba15a027e9cf52297f042900e5a92a5d2696bbbe)
Reviewed-on: https://chromium-review.googlesource.com/1101737
Reviewed-by: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#362}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/0449ed6e1f4ac06093d8aee87375e4641ccf1fb2/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java