New issue
Advanced search Search tips

Issue 851119 link

Starred by 2 users
Status: Fixed
Owner:
eugene...@chromium.org
Closed: Jan 2
Cc:
danyao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task

Blocking:
issue 734150



Sign in to add a comment

WebStateObserverTest tests fail if SlimNavigationManager is enabled

Project Member Reported by eugene...@chromium.org, Jun 8 2018 
``App Version (from "Chrome Settings > About Chrome"): 
iOS Version: 
Device: 

Steps to reproduce: 
1.) Enable SlimNavigationManager
2.) Run ios_web_inttests

Observed behavior: 

[  FAILED  ] NavigationAndLoadCallbacksTest.FailedNavigation
[  FAILED  ] NavigationAndLoadCallbacksTest.ReloadWithUserAgentType
[  FAILED  ] NavigationAndLoadCallbacksTest.UserInitiatedHashChangeNavigation
[  FAILED  ] NavigationAndLoadCallbacksTest.RendererInitiatedHashChangeNavigation
[  FAILED  ] NavigationAndLoadCallbacksTest.StateNavigation
[  FAILED  ] NavigationAndLoadCallbacksTest.ForwardPostNavigation

Comment 1 by eugene...@chromium.org, Jun 8 2018

Cc: danyao@chromium.org
Labels: -Restrict-View-Google
Status: Assigned (was: Untriaged)
Danyao, is this a known bug?

Comment 2 by danyao@chromium.org, Jun 11 2018 

Yes.

Comment 3 by eugene...@chromium.org, Jun 11 2018

Blocking: 725241

Comment 4 by danyao@chromium.org, Jun 19 2018 

ForwardPostNavigation is failing in the final forward step. |hasUserGesture| is false in NavigationContextImpl when it should be true, because the forward navigation is initiated using navigationManager->GoForward().

Root cause is that both browser-initiated and renderer-initiated back/forward navigations are handled by the same code path and are indistinguishable in CRWWebController. In contrast, with LegacyNavigationManager, browser-initiated back/forward navigation is handled by |loadCurrentURL|, but not renderer-initiated back/forward navigation.

Comment 5 by danyao@chromium.org, Jun 19 2018 

StateNavigation is failing in the pushState step because WebStateObserver::DidChangeBackForwardState() is triggered, but no expectation was set by the test.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7f62fe9f07293e1888aceb39be14d69bb6ccbc4

commit b7f62fe9f07293e1888aceb39be14d69bb6ccbc4
Author: Danyao Wang <danyao@chromium.org>
Date: Thu Jun 21 20:22:57 2018

[Nav Experiment] Update missing DidChangeBackForwardState expectation.

This fixes NavigationAndLoadCallbacksTest.StateNavigation for

Bug:  851119 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idfe93cc78bed9ed16b0ebffea6ab1cfa58a68955
Reviewed-on: https://chromium-review.googlesource.com/1107111
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569369}
[modify] https://crrev.com/b7f62fe9f07293e1888aceb39be14d69bb6ccbc4/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eb4e8ded583bc76d7d17eaf195745f5f5f4432d

commit 1eb4e8ded583bc76d7d17eaf195745f5f5f4432d
Author: Danyao Wang <danyao@chromium.org>
Date: Thu Jun 21 20:23:11 2018

[Nav Experiment] Add missing DidChangeBackForwardState expectation.

This fixes NavigationAndLoadCallbacksTest.RendererInitiatedHashNavigation.

Bug:  851119 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia02421ad58b285ed62727453824f10eb403a5876
Reviewed-on: https://chromium-review.googlesource.com/1110265
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569370}
[modify] https://crrev.com/1eb4e8ded583bc76d7d17eaf195745f5f5f4432d/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97f9353ce77dd85ad2c312582d0529b28cd70247

commit 97f9353ce77dd85ad2c312582d0529b28cd70247
Author: Danyao Wang <danyao@chromium.org>
Date: Tue Jul 03 22:59:20 2018

[Nav Experiment] Parameterize NavigationAndLoadCallbacksTest.

This allows testing of both navigation manager implementations on bots.
Temporarily disabled currently failing tests.

Bug:  851119 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3ed3d60479aa180101571ce56e78b66c95d5d4f4
Reviewed-on: https://chromium-review.googlesource.com/1110999
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572382}
[modify] https://crrev.com/97f9353ce77dd85ad2c312582d0529b28cd70247/ios/web/web_state/navigation_and_load_callbacks_inttest.mm

Comment 9 by danyao@chromium.org, Jul 5

Owner: danyao@chromium.org

Comment 10 by eugene...@chromium.org, Jul 10

Blocking: -725241

Comment 11 by danyao@chromium.org, Nov 28

Blocking: 734150
Labels: Proj-WKBackForwardList Proj-WKBackForwardListBlocker

Comment 12 by eugene...@chromium.org, Nov 28

Summary: WebStateObserverTest tests fail if SlimNavigationManager is enabled (was: NavigationAndLoadCallbacksTest tests fail if SlimNavigationManager is enabled)
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/024c44482ffbe49636e902c01525b372059c7d1e

commit 024c44482ffbe49636e902c01525b372059c7d1e
Author: Danyao Wang <danyao@chromium.org>
Date: Sat Dec 08 00:26:30 2018

[Nav Experiment] Fix WebStateObserverTest.ForwardPostNavigation.

Propgate navigation item's page transition type to the navigation
context in back/forward navigation.

Bug:  851119 
Change-Id: If66f587d5d6149f222e2de5bfdd3631d4027b259
Reviewed-on: https://chromium-review.googlesource.com/c/1368452
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614880}
[modify] https://crrev.com/024c44482ffbe49636e902c01525b372059c7d1e/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/024c44482ffbe49636e902c01525b372059c7d1e/ios/web/web_state/web_state_observer_inttest.mm
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1b00bf181dd7ee4a636cc3e1f678e99223f5466

commit a1b00bf181dd7ee4a636cc3e1f678e99223f5466
Author: Danyao Wang <danyao@chromium.org>
Date: Mon Dec 10 15:59:48 2018

[Nav Experiment] Fix broken WebStateObserverTest.IframeNavigation.

The test expectations added for RequestInfo were always broken, but it
was not discovered because slim-nav was not run on CQ.

Bug:  851119 
Change-Id: Ia9949553d9a0b97cb16a8435b5f8c95084ab1880
Reviewed-on: https://chromium-review.googlesource.com/c/1369004
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615131}
[modify] https://crrev.com/a1b00bf181dd7ee4a636cc3e1f678e99223f5466/ios/web/web_state/web_state_observer_inttest.mm
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddd36e3048f0b834ab6a07875e0596a3d54b6804

commit ddd36e3048f0b834ab6a07875e0596a3d54b6804
Author: Samuel Huang <huangs@chromium.org>
Date: Mon Dec 10 16:21:20 2018

Revert "[Nav Experiment] Fix broken WebStateObserverTest.IframeNavigation."

This reverts commit a1b00bf181dd7ee4a636cc3e1f678e99223f5466.

Reason for revert: Compile failure in ios-webview.

Original change's description:
> [Nav Experiment] Fix broken WebStateObserverTest.IframeNavigation.
> 
> The test expectations added for RequestInfo were always broken, but it
> was not discovered because slim-nav was not run on CQ.
> 
> Bug:  851119 
> Change-Id: Ia9949553d9a0b97cb16a8435b5f8c95084ab1880
> Reviewed-on: https://chromium-review.googlesource.com/c/1369004
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Commit-Queue: Danyao Wang <danyao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615131}

TBR=eugenebut@chromium.org,danyao@chromium.org

Change-Id: I2ba72833afbdc5b1023ec2c0fabc58a432573b63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  851119 
Reviewed-on: https://chromium-review.googlesource.com/c/1369800
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615135}
[modify] https://crrev.com/ddd36e3048f0b834ab6a07875e0596a3d54b6804/ios/web/web_state/web_state_observer_inttest.mm
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a267525eb095936d2e3317fd41efef2baf7ee03f

commit a267525eb095936d2e3317fd41efef2baf7ee03f
Author: Danyao Wang <danyao@chromium.org>
Date: Mon Dec 10 21:06:36 2018

Reland "[Nav Experiment] Fix broken WebStateObserverTest.IframeNavigation."

This is a reland of a1b00bf181dd7ee4a636cc3e1f678e99223f5466

Original change's description:
> [Nav Experiment] Fix broken WebStateObserverTest.IframeNavigation.
> 
> The test expectations added for RequestInfo were always broken, but it
> was not discovered because slim-nav was not run on CQ.
> 
> Bug:  851119 
> Change-Id: Ia9949553d9a0b97cb16a8435b5f8c95084ab1880
> Reviewed-on: https://chromium-review.googlesource.com/c/1369004
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Commit-Queue: Danyao Wang <danyao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615131}

Bug:  851119 
Change-Id: I8bb26c31d4164e29dce171a0d118672975551946
Reviewed-on: https://chromium-review.googlesource.com/c/1370194
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615250}
[modify] https://crrev.com/a267525eb095936d2e3317fd41efef2baf7ee03f/ios/web/web_state/web_state_observer_inttest.mm
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3f8b7314f548ab9e2b431cd6229ebb0e74ddf9c

commit a3f8b7314f548ab9e2b431cd6229ebb0e74ddf9c
Author: Danyao Wang <danyao@chromium.org>
Date: Mon Dec 10 22:53:42 2018

[Nav Experiment] Re-enable UserInitiatedHashChangeNavigation test.

This CL doesn't yet fix the test for slim nav. It patches two known
bugs with hash-only changes so that the test can be re-enabled to
prevent other possible regressions.

Bug:  851119 
Change-Id: Ibf866d0c8cec0508632d9c2f66ca41763852f6f4
Reviewed-on: https://chromium-review.googlesource.com/c/1370884
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615293}
[modify] https://crrev.com/a3f8b7314f548ab9e2b431cd6229ebb0e74ddf9c/ios/web/web_state/web_state_observer_inttest.mm

Comment 18 by eugene...@chromium.org, Dec 18

Owner: eugene...@chromium.org
Status: Started (was: Assigned)
Last test is fixed here: crrev.com/c/1370374
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4

commit 8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4
Author: Eugene But <eugenebut@google.com>
Date: Wed Dec 19 21:31:57 2018

Fix WebStateObserverTest.UserInitiatedHashChangeNavigation for slim nav.

Create navigation content at the moment when navigation to back forward
list is initiated. This allows to associate navigation context with
correct WKNavigation object. This makes PendingBackForwardContext
concept obsolete.

Bug:  913052 ,  851119 
Change-Id: I1e30f5feee7bfc82a4bbc8f46a459d7cd3a43a64
Reviewed-on: https://chromium-review.googlesource.com/c/1370374
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617954}
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/navigation/legacy_navigation_manager_impl.h
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/navigation/legacy_navigation_manager_impl.mm
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/navigation/navigation_manager_delegate.h
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/navigation/navigation_manager_impl.h
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/navigation/navigation_manager_impl_unittest.mm
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/navigation/wk_based_navigation_manager_impl.h
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/navigation/wk_based_navigation_manager_impl.mm
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/navigation/wk_based_navigation_manager_impl_unittest.mm
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/test/fakes/fake_navigation_manager_delegate.h
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/test/fakes/fake_navigation_manager_delegate.mm
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/web_state/ui/crw_web_controller.h
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/web_state/ui/crw_web_view_navigation_proxy.h
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/web_state/ui/crw_wk_navigation_states.mm
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4/ios/web/web_state/web_state_observer_inttest.mm
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b

commit fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu Dec 20 00:52:08 2018

Revert "Fix WebStateObserverTest.UserInitiatedHashChangeNavigation for slim nav."

This reverts commit 8f78fecf6ba90f38fc60c6cb41fb6c98a20354a4.

Reason for revert: Believed to be the cause of https://bugs.chromium.org/p/chromium/issues/detail?id=916829

Original change's description:
> Fix WebStateObserverTest.UserInitiatedHashChangeNavigation for slim nav.
> 
> Create navigation content at the moment when navigation to back forward
> list is initiated. This allows to associate navigation context with
> correct WKNavigation object. This makes PendingBackForwardContext
> concept obsolete.
> 
> Bug:  913052 ,  851119 
> Change-Id: I1e30f5feee7bfc82a4bbc8f46a459d7cd3a43a64
> Reviewed-on: https://chromium-review.googlesource.com/c/1370374
> Reviewed-by: Danyao Wang <danyao@chromium.org>
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617954}

TBR=eugenebut@chromium.org,danyao@chromium.org

Change-Id: I813f4231c4cf1913e695dc94e2c25088e1f6fb59
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  913052 ,  851119 
Reviewed-on: https://chromium-review.googlesource.com/c/1385481
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618048}
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/navigation/legacy_navigation_manager_impl.h
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/navigation/legacy_navigation_manager_impl.mm
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/navigation/navigation_manager_delegate.h
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/navigation/navigation_manager_impl.h
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/navigation/navigation_manager_impl_unittest.mm
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/navigation/wk_based_navigation_manager_impl.h
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/navigation/wk_based_navigation_manager_impl.mm
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/navigation/wk_based_navigation_manager_impl_unittest.mm
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/test/fakes/fake_navigation_manager_delegate.h
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/test/fakes/fake_navigation_manager_delegate.mm
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/web_state/ui/crw_web_controller.h
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/web_state/ui/crw_web_view_navigation_proxy.h
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/web_state/ui/crw_wk_navigation_states.mm
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/fdc3adbb3c6b19359dbc8d8aa0bc9a7a33448a7b/ios/web/web_state/web_state_observer_inttest.mm
Project Member

Comment 21 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08d9fa1e884873016c608ddb604580b572cc19cb

commit 08d9fa1e884873016c608ddb604580b572cc19cb
Author: Eugene But <eugenebut@chromium.org>
Date: Fri Dec 21 15:23:07 2018

Reland Fix WebStateObserverTest.UserInitiatedHashChangeNavigation for slim nav.

Create navigation content at the moment when navigation to back forward
list is initiated. This allows to associate navigation context with
correct WKNavigation object. This makes PendingBackForwardContext
concept obsolete.

Original CL: https://chromium-review.googlesource.com/c/1370374

Bug:  913052 ,  851119 
Change-Id: I05678a686a50e3c1c0e1948225586b47dec202b3
Reviewed-on: https://chromium-review.googlesource.com/c/1385490
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618524}
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/navigation/legacy_navigation_manager_impl.h
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/navigation/legacy_navigation_manager_impl.mm
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/navigation/navigation_manager_delegate.h
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/navigation/navigation_manager_impl.h
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/navigation/navigation_manager_impl_unittest.mm
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/navigation/wk_based_navigation_manager_impl.h
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/navigation/wk_based_navigation_manager_impl.mm
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/navigation/wk_based_navigation_manager_impl_unittest.mm
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/test/fakes/fake_navigation_manager_delegate.h
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/test/fakes/fake_navigation_manager_delegate.mm
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/web_state/ui/crw_web_controller.h
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/web_state/ui/crw_web_view_navigation_proxy.h
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/web_state/ui/crw_wk_navigation_states.mm
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/08d9fa1e884873016c608ddb604580b572cc19cb/ios/web/web_state/web_state_observer_inttest.mm

Comment 22 by eugene...@chromium.org, Jan 2

Status: Fixed (was: Started)
►

Sign in to add a comment