Use taller region above tabs for custom themes in refresh |
|||||||
Issue descriptionIf custom themes in refresh set off background tabs from the frame (see bug 848546), they'll likely need a taller top handle to still be draggable, although this also interacts with whether we have the 50 DIP drag handle area post-tabs in the frame. The idea here would probably be that we increase the top height until there's 11 DIP of drag handle in this case. P3 since the 50 DIP horizontal region probably saves this from being release-blocking.
,
Jun 14 2018
To clarify, This is to increase the height of the white-space above the tab strip that can be used to drag & move the chrome window? And the height should be increased with all (or some?) custom theme, but not with the default theme?
,
Jun 14 2018
On linux, I've tried the GTK, classic, and 2 custom themes from the app store, and haven't noticed a difference in white-space above the tabs strip.
,
Jun 14 2018
manukh: assigning to you since you're looking into this. That doesn't mean that you're obligated to complete a fix.
,
Jun 18 2018
unassigning myself as I lack understanding of what the desired changes are.
,
Jun 18 2018
The issue here is that if inactive tabs don't blend into the frame, we can't extend the window drag handle into the inactive tab like we currently do, because that will feel broken (which we know already from testing it). But if we don't extend the drag handle windows won't be sufficiently draggable from the top. So in that case, we need to extend the top handle up to be taller.
,
Jun 28 2018
,
Jul 12
,
Sep 20
,
Sep 26
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pkasting@chromium.org
, Jun 8 2018