ChromeOS restored frame top should be 8 DIP rather than 7 |
||||||
Issue descriptionThe space above the tabs on Chromeos should be 8 DIP rather than 7, at least on Refresh (though we are almost certainly safe to just change it for all modes).
,
Jun 20 2018
,
Jun 27 2018
I'm guessing this is talking about |kInactiveTabHitTestOverlap| in tab_strip.cc? Does the |TAB_HEIGHT| need to be adjusted for Refresh modes as well?
,
Jun 27 2018
No, this is about the values in ash/public/cpp/ash_layout_constants.cc . Basically, the "restored" case should be rewritten to return the "maximized" value plus a constant, and that constant should be made 8 instead of the current 7 effective value.
,
Jun 28 2018
,
Jul 12
,
Jul 13
This sounds easy, so picking this off. https://chromium-review.googlesource.com/1137236
,
Jul 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c224b0605ec4cb3c2fc1ec06e2bb2e07c489d9b commit 2c224b0605ec4cb3c2fc1ec06e2bb2e07c489d9b Author: Lei Zhang <thestig@chromium.org> Date: Mon Jul 16 22:48:41 2018 Change ChromeOS restored frame top to 8 DIP. Change it to 8 from 7. Do this programmatically rather than with hard-coded constants. BUG= 851101 Change-Id: I638dfcfc641c92af860f4b0d4e630914bc6426f9 Reviewed-on: https://chromium-review.googlesource.com/1137236 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575457} [modify] https://crrev.com/2c224b0605ec4cb3c2fc1ec06e2bb2e07c489d9b/ash/public/cpp/ash_layout_constants.cc
,
Jul 16
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by pkasting@chromium.org
, Jun 8 2018