New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 851098 link

Starred by 1 user
Status: Fixed
Owner:
lijeffrey@chromium.org
Closed: Jun 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Add isolated_hash and build_url as properties to IsolatedTarget

Project Member Reported by lijeffrey@chromium.org, Jun 8 2018 
isolated_hash and build_url are necessary as return information for getting the isolated sha for a build in GetIsolateShaForBuildPipeline
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d0934b2371a483788d77cc2e87f1f01980cb1cdc

commit d0934b2371a483788d77cc2e87f1f01980cb1cdc
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Fri Jun 08 21:53:46 2018

[Findit] Adding isolated_hash and build_url to IsolatedTarget

Adding properties so the calling code has easy access. For example,
in Flake Analyzer, GetIsolateShaForBuildPipeline returns the isolated
hash and build url which would benefit from having these properties
available.

Bug:  851098 
Change-Id: Iadd0ed40ca8d4a00cef3c6288f6021b60b0a5a84
Reviewed-on: https://chromium-review.googlesource.com/1093463
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/d0934b2371a483788d77cc2e87f1f01980cb1cdc/appengine/findit/model/test/isolated_target_test.py
[modify] https://crrev.com/d0934b2371a483788d77cc2e87f1f01980cb1cdc/appengine/findit/model/isolated_target.py

Comment 2 by lijeffrey@chromium.org, Jun 11 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment