Ignore Bluetooth turn off request from Android |
|||||||
Issue descriptionWith the current architecture, there is no way to reliably tell whether a request from Android to turn off Bluetooth comes from a user or from Chrome OS. So it's proposed to ignore silently any request to turn off Bluetooth from Android due to the following: 1. On Chrome OS, Android system settings for Bluetooth and Airplane Mode is disabled. So there is no way for user to turn off Bluetooth from Android system settings on Chrome OS. 2. The only applications that use Android API to turn off Bluetooth are power saving apps, which don't make sense on Chrome OS anyway: https://developer.android.com/reference/android/bluetooth/BluetoothAdapter.html#disable() This will prevent bug 843650 from happening, until we have the new architecture for Android for doing Bluetooth state synchronization right.
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90237eeebcc0d1d45a88532a96b4b4df28eca7be commit 90237eeebcc0d1d45a88532a96b4b4df28eca7be Author: Sonny Sasaka <sonnysasaka@chromium.org> Date: Mon Jun 11 22:52:54 2018 arc_bluetooth_bridge: Ignore Bluetooth turn off request from Android With the current architecture, there is no way to reliably tell whether a request from Android to turn off Bluetooth comes from a user or from Chrome OS. So it's proposed to ignore silently any request to turn off Bluetooth from Android due to the following: 1. On Chrome OS, Android system settings for Bluetooth and Airplane Mode is disabled. So there is no way for user to turn off Bluetooth from Android system settings on Chrome OS. 2. The only applications that use Android API to turn off Bluetooth are power saving apps, which don't make sense on Chrome OS anyway. Bug: 851097 , 843650 Change-Id: I82c0d745fbd5b11437c05d827e79296ebe5bec5e Reviewed-on: https://chromium-review.googlesource.com/1093465 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#566185} [modify] https://crrev.com/90237eeebcc0d1d45a88532a96b4b4df28eca7be/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
,
Jun 12 2018
,
Jun 12 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 13 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/929ea5ceaf59528e9028bb2eb4ecc074a9406041 commit 929ea5ceaf59528e9028bb2eb4ecc074a9406041 Author: Miao-chen Chou <mcchou@chromium.org> Date: Wed Jun 13 20:41:45 2018 arc_bluetooth_bridge: Ignore Bluetooth turn off request from Android With the current architecture, there is no way to reliably tell whether a request from Android to turn off Bluetooth comes from a user or from Chrome OS. So it's proposed to ignore silently any request to turn off Bluetooth from Android due to the following: 1. On Chrome OS, Android system settings for Bluetooth and Airplane Mode is disabled. So there is no way for user to turn off Bluetooth from Android system settings on Chrome OS. 2. The only applications that use Android API to turn off Bluetooth are power saving apps, which don't make sense on Chrome OS anyway. TBR=sonnysasaka@chromium.org (cherry picked from commit 90237eeebcc0d1d45a88532a96b4b4df28eca7be) Bug: 851097 , 843650 Change-Id: I82c0d745fbd5b11437c05d827e79296ebe5bec5e Reviewed-on: https://chromium-review.googlesource.com/1093465 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#566185} Reviewed-on: https://chromium-review.googlesource.com/1099769 Cr-Commit-Position: refs/branch-heads/3440@{#347} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/929ea5ceaf59528e9028bb2eb4ecc074a9406041/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
,
Jul 9
,
Oct 4
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sonnysasaka@chromium.org
, Jun 8 2018