Run finch trial that requests PresentationFeedback for every frame |
||
Issue descriptionWe will run a finch trial that enables the use of PresenationFeedback every frame for new frame metrics. This will let us gather data while we work on lowering the overhead of PresentationFeedback. Once we are sure PresentationFeedback doesn't add much overhead, we can remove the finch trial.
,
Jul 13
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/759983cbb3649ffcaccb528b76230b1bcb93f720 commit 759983cbb3649ffcaccb528b76230b1bcb93f720 Author: yiyix <yiyix@chromium.org> Date: Tue Jul 17 17:03:31 2018 frame_metrics: remove finch flag kPresentationFeedbackEveryFrame We decided to skip the finch trial for adding these new UMA metrics, so remove the flag kPresentationFeedbackEveryFrame added earlier. Bug:851088 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I63eacff9d616594d340b983a0fe373c24e790032 Reviewed-on: https://chromium-review.googlesource.com/1136069 Reviewed-by: weiliangc <weiliangc@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#575689} [modify] https://crrev.com/759983cbb3649ffcaccb528b76230b1bcb93f720/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/759983cbb3649ffcaccb528b76230b1bcb93f720/ui/latency/frame_metrics.cc [modify] https://crrev.com/759983cbb3649ffcaccb528b76230b1bcb93f720/ui/latency/frame_metrics.h
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/808c1f33139afdc7d32b838938ed297a3f27f8f1 commit 808c1f33139afdc7d32b838938ed297a3f27f8f1 Author: yiyix <yiyix@chromium.org> Date: Thu Aug 09 04:25:20 2018 FrameMetrics: Adding frame metrics analysis to LayerTreeHostImpl Added frame metrics analysis to LayerTreeHostImpl. The frame presentation callback times are sent to frame metrics for every nth scrolling. Bug:851088 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I32aee9b5401c056ed3be64e17a45cc1958188199 Reviewed-on: https://chromium-review.googlesource.com/1147921 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581782} [modify] https://crrev.com/808c1f33139afdc7d32b838938ed297a3f27f8f1/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/808c1f33139afdc7d32b838938ed297a3f27f8f1/cc/trees/layer_tree_host_impl.h
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f898a23c1af094b58ea748c74948049893c08084 commit f898a23c1af094b58ea748c74948049893c08084 Author: yiyix <yiyix@chromium.org> Date: Tue Aug 28 21:31:21 2018 Revert "FrameMetrics: Adding frame metrics analysis to LayerTreeHostImpl" This reverts commit 808c1f33139afdc7d32b838938ed297a3f27f8f1. Reason for revert: increased the time spent in tasks_per_frame_total_all by 10%. Original change's description: > FrameMetrics: Adding frame metrics analysis to LayerTreeHostImpl > > Added frame metrics analysis to LayerTreeHostImpl. The frame presentation > callback times are sent to frame metrics for every nth scrolling. > > Bug:851088 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I32aee9b5401c056ed3be64e17a45cc1958188199 > Reviewed-on: https://chromium-review.googlesource.com/1147921 > Commit-Queue: Yi Xu <yiyix@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581782} TBR=sadrul@chromium.org,flackr@chromium.org,yiyix@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 851088 Change-Id: I86e8f294afcbd84c5e271fcbf2999f01e831df25 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1194685 Reviewed-by: Yi Xu <yiyix@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#586857} [modify] https://crrev.com/f898a23c1af094b58ea748c74948049893c08084/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/f898a23c1af094b58ea748c74948049893c08084/cc/trees/layer_tree_host_impl.h |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 12 2018