New issue
Advanced search Search tips

Issue 851074 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

analyze.py not seeing private dependency

Project Member Reported by jam@chromium.org, Jun 8 2018

Issue description

See https://chromium-review.googlesource.com/c/chromium/src/+/1093023/2 which touched chrome/test/views/accessibility_checker.cc. That file should cause browser_tests to run. However for some reason analyze skipped it.

Could it be because the "gn path" shows it's private? i.e. see below.

Marking this as P1 because it could lead to bad cls landing. Dirk: not sure who to assign it to, so please reassign as necessary. Thanks.




E:\src\chrome2\src>gn path out\Debug chrome/test:browser_tests chrome/test:test_support
//chrome/test:browser_tests --[private]-->
//chrome/test:test_support

Showing one of 8 "interesting" non-data paths. 0 of them are public.
Use --all to print all paths.

E:\src\chrome2\src>gn path out\Debug chrome/test:browser_tests chrome/test:test_support -all
//chrome/test:browser_tests --[private]-->
//chrome/test:test_support

//chrome/test:browser_tests --[private]-->
//chrome/test:browser_tests_runner --[private]-->
//chrome/test:test_support

//chrome/test:browser_tests --[private]-->
//chrome/test/data/webui:browser_tests_js_mojo_webui --[private]-->
//chrome/test:test_support

//chrome/test:browser_tests --[private]-->
//chrome/test/data/webui:browser_tests_js_webui --[private]-->
//chrome/test:test_support

//chrome/test:browser_tests --[private]-->
//chrome/test:sync_integration_test_support --[private]-->
//chrome/test:test_support

//chrome/test:browser_tests --[private]-->
//chrome/services/media_gallery_util/public/cpp:browser_tests --[private]-->
//chrome/test:test_support

//chrome/test:browser_tests --[private]-->
//chrome/test/media_router:browser_tests --[private]-->
//chrome/test/media_router:test_support --[private]-->
//chrome/test:test_support

//chrome/test:browser_tests --[private]-->
//chrome/test/media_router:browser_tests --[private]-->
//chrome/test/media_router:test_support --[private]-->
//chrome/browser/media/router:test_support --[private]-->
//chrome/test:test_support

8 "interesting" non-data paths found. 0 of them are public.

 
Status: WontFix (was: Assigned)
browser_tests isn't currently configured to run on win10_chromium_x64_dbg_ng (or the matching Win10 Tests x64 (dbg)). See bug 850343.

I don't think there's a bug here (at least not in analyze). You can see that analyze did trigger browser_tests correctly on linux_chromium_rel_ng, for example.

Comment 2 by jam@chromium.org, Jun 11 2018

ah, thank you i didn't know that

Sign in to add a comment