analyze.py not seeing private dependency |
|
Issue descriptionSee https://chromium-review.googlesource.com/c/chromium/src/+/1093023/2 which touched chrome/test/views/accessibility_checker.cc. That file should cause browser_tests to run. However for some reason analyze skipped it. Could it be because the "gn path" shows it's private? i.e. see below. Marking this as P1 because it could lead to bad cls landing. Dirk: not sure who to assign it to, so please reassign as necessary. Thanks. E:\src\chrome2\src>gn path out\Debug chrome/test:browser_tests chrome/test:test_support //chrome/test:browser_tests --[private]--> //chrome/test:test_support Showing one of 8 "interesting" non-data paths. 0 of them are public. Use --all to print all paths. E:\src\chrome2\src>gn path out\Debug chrome/test:browser_tests chrome/test:test_support -all //chrome/test:browser_tests --[private]--> //chrome/test:test_support //chrome/test:browser_tests --[private]--> //chrome/test:browser_tests_runner --[private]--> //chrome/test:test_support //chrome/test:browser_tests --[private]--> //chrome/test/data/webui:browser_tests_js_mojo_webui --[private]--> //chrome/test:test_support //chrome/test:browser_tests --[private]--> //chrome/test/data/webui:browser_tests_js_webui --[private]--> //chrome/test:test_support //chrome/test:browser_tests --[private]--> //chrome/test:sync_integration_test_support --[private]--> //chrome/test:test_support //chrome/test:browser_tests --[private]--> //chrome/services/media_gallery_util/public/cpp:browser_tests --[private]--> //chrome/test:test_support //chrome/test:browser_tests --[private]--> //chrome/test/media_router:browser_tests --[private]--> //chrome/test/media_router:test_support --[private]--> //chrome/test:test_support //chrome/test:browser_tests --[private]--> //chrome/test/media_router:browser_tests --[private]--> //chrome/test/media_router:test_support --[private]--> //chrome/browser/media/router:test_support --[private]--> //chrome/test:test_support 8 "interesting" non-data paths found. 0 of them are public.
,
Jun 11 2018
ah, thank you i didn't know that |
|
►
Sign in to add a comment |
|
Comment 1 by dpranke@chromium.org
, Jun 8 2018