New issue
Advanced search Search tips

Issue 851070 link

Starred by 1 user
Status: Fixed
Owner:
ftirelo@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

No proper emphasis in LayoutProvider for the autofill dropdown

Project Member Reported by ftirelo@chromium.org, Jun 8 2018 
No shadow elevation defined for MD/Refresh is appropriate for the
autofill dropdown: EMPHASIS_LOW is too low (1) and for EMPHASIS_MEDIUM is too high (3).

The proposal is to rename emphasis as follows:
 - EMPHASIS_LOW (current) -> EMPHASIS_LOW (new)
 - <non existing> (current) -> EMPHASIS_MEDIUM (new)
 - EMPHASIS_MEDIUM (current) -> EMPHASIS_HIGH (new)
 - EMPHASIS_HIGH (current) -> EMPHASIS_GIGANTIC (new)

The new EMPHASIS_MEDIUM will have the following spec:
 - shadow elevation = 2
 - corner radius = 4

We should also consider if some menus or other components should share the
same emphasis level.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99db48b6e238fb78979aff66834d2a391ae34d43

commit 99db48b6e238fb78979aff66834d2a391ae34d43
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Tue Jun 12 15:52:57 2018

Add a new emphasis level to LayoutProvider

This introduces a new emphasis level to support the autofill dropdown.
The main reason is that on MD/Refresh, the shadow elevation for
EMPHASIS_LOW is too low (1) and for EMPHASIS_MEDIUM is too high (3).

Instead of creating a new level between LOW and MEDIUM, I decided to
rename/add as follows:
 - EMPHASIS_LOW (current) -> EMPHASIS_LOW (new)
 - <non existing> (current) -> EMPHASIS_MEDIUM (new)
 - EMPHASIS_MEDIUM (current) -> EMPHASIS_HIGH (new)
 - EMPHASIS_HIGH (current) -> EMPHASIS_MAXIMUM (new)

Bug:  851070 
Change-Id: I361efb8aaa87dbb95ce7ecca203e5adb9bfa1de6
Reviewed-on: https://chromium-review.googlesource.com/1093550
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566440}
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/chrome/browser/ui/views/harmony/material_refresh_layout_provider.cc
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/ui/views/bubble/bubble_dialog_delegate.cc
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/ui/views/layout/layout_provider.cc
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/ui/views/layout/layout_provider.h
[modify] https://crrev.com/99db48b6e238fb78979aff66834d2a391ae34d43/ui/views/window/dialog_delegate.cc

Comment 2 by ftirelo@chromium.org, Jun 19 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment