New issue
Advanced search Search tips

Issue 851067 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

31.4% regression in media.desktop at 564541:564736

Project Member Reported by hubbe@google.com, Jun 8 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=851067

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=4f626c1b10edf81ddc37ceb0e6cb85b152134bf15232c9e3f14afb26e363947f


Bot(s) for this bug's original alert(s):

chromium-rel-win10
Cc: maxlg@chromium.org
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1698a651240000

[EventTiming] Remove the check of processing start being before onload by maxlg@chromium.org
https://chromium.googlesource.com/chromium/src/+/ddcf12998995d87b6fed15c881ac79dc57ff9e43
6.683e+06 → 8.78e+06 (+2.097e+06)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by maxlg@chromium.org, Jun 8 2018

That's weird. My CL has nothing to do with file sizes. 

Comment 5 by hubbe@google.com, Jun 8 2018

I think this might be a measure of used memory?

Comment 6 by maxlg@chromium.org, Jun 8 2018

Cc: tdres...@chromium.org
Owner: maxlg@chromium.org
Oh, got it.

It might be too costly to create a timing object each time in order to check whether we should buffer a event timing entry.

Comment 7 by dtu@chromium.org, Jun 11 2018

Cc: -maxlg@chromium.org
Owner: dtu@chromium.org
The Pinpoint result is not right, my fault. Re-running now.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jun 13 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/11f7b8e9240000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.

Comment 10 by dtu@chromium.org, Jun 19 2018

Those bots have churned through their queue now, going to re-run the job.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Jun 19 2018

Cc: steimel@chromium.org
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14fe5c1d240000

[Media Controls] Set overlay play button width/height dynamically by steimel@chromium.org
https://chromium.googlesource.com/chromium/src/+/3da026559a35a96de381e3a44cabfee364fae05b
6.683e+06 → 8.78e+06 (+2.097e+06)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: steimel@chromium.org
Components: Internals>Media

Sign in to add a comment