Correct padding around tabstrip for refresh |
|||||||
Issue descriptionFrom my notes: * Fix padding pre-tabs in TRAILING & maybe AFTER_TABS mode * Fix Mac padding post-NTB, also Windows leading-edge-caption padding post-NTB (I don't recall what "fix" means but I think it was usually along the lines of "should appear to be 8 but instead appears to be 0". Needs to be rechecked. Probably I need to be the one to recheck this.) Probably P2 and not P3 since without this I think the tabstrip may run awkwardly into the window frame edge in certain modes.
,
Jun 8 2018
,
Jun 20 2018
Issue 854602 has been merged into this issue.
,
Jun 20 2018
From duped-in bug: the current Mac trailing padding appears to be 4 DIP but should appear to be 8 DIP.
,
Jun 27 2018
Is this still an issue if we move the NTB button to the trailing position?
,
Jun 27 2018
Yes; it actually gets worse since the pre-tab padding is wrong for AFTER_TABS mode tabs, so instead of looking wrong in some cases we look wrong in all cases.
,
Jun 28 2018
Note to self: perhaps when maximized, the leading tab (on Windows; trailing on Mac) should be placed so that the layout width is flush with the window edge. If not, we need to add a Fitts' Law affordance for the first tab.
,
Jun 28 2018
,
Jul 12
,
Jul 12
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79fb092c2b302efbacf73a1bb8948b5b07e809cd commit 79fb092c2b302efbacf73a1bb8948b5b07e809cd Author: Peter Kasting <pkasting@chromium.org> Date: Fri Jul 13 20:27:59 2018 Correct padding around tabstrip for refresh. This moves the padding outside the NTB into the NTB, allowing more consistent positioning. Bug: 851044 Test: Open two tabs. The leftmost tab's left curve should taper out to the very corner of the toolbar, not 8 DIP later. Change-Id: I01487e3c416a24b8387bf67c2b1a3e0817125cd9 Reviewed-on: https://chromium-review.googlesource.com/1135965 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#575055} [modify] https://crrev.com/79fb092c2b302efbacf73a1bb8948b5b07e809cd/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc [modify] https://crrev.com/79fb092c2b302efbacf73a1bb8948b5b07e809cd/chrome/browser/ui/views/frame/browser_non_client_frame_view.h [modify] https://crrev.com/79fb092c2b302efbacf73a1bb8948b5b07e809cd/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm [modify] https://crrev.com/79fb092c2b302efbacf73a1bb8948b5b07e809cd/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/79fb092c2b302efbacf73a1bb8948b5b07e809cd/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc [modify] https://crrev.com/79fb092c2b302efbacf73a1bb8948b5b07e809cd/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc [modify] https://crrev.com/79fb092c2b302efbacf73a1bb8948b5b07e809cd/chrome/browser/ui/views/tabs/new_tab_button.cc [modify] https://crrev.com/79fb092c2b302efbacf73a1bb8948b5b07e809cd/chrome/browser/ui/views/tabs/tab_strip.cc
,
Jul 13
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pkasting@chromium.org
, Jun 8 2018