1st iteration of the password generation.

Deleted: Screen Shot 2018-06-08 at 19.57.15.png 25.0 KB

	Screen Shot 2018-06-08 at 19.57.15.png 25.0 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46898d23cdf5f209e6e40a1b8509682919efa4d5

commit 46898d23cdf5f209e6e40a1b8509682919efa4d5
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Jun 11 11:12:28 2018

Make password generation drop-down similar to MD2.

This CL is the first step to make the password generation drop-down matching the updated mocks. Shadow, border and corners are to be done.

TBR=rouslan@chromium.org

Bug:  851021 
Change-Id: I55dafadf3d55f1670defbaa87b778408a2ebfc69
Reviewed-on: https://chromium-review.googlesource.com/1093317
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565961}
[modify] https://crrev.com/46898d23cdf5f209e6e40a1b8509682919efa4d5/chrome/app/chromium_strings.grd
[modify] https://crrev.com/46898d23cdf5f209e6e40a1b8509682919efa4d5/chrome/app/generated_resources.grd
[modify] https://crrev.com/46898d23cdf5f209e6e40a1b8509682919efa4d5/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/46898d23cdf5f209e6e40a1b8509682919efa4d5/chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc
[modify] https://crrev.com/46898d23cdf5f209e6e40a1b8509682919efa4d5/chrome/browser/ui/android/autofill/password_generation_popup_view_android.h
[modify] https://crrev.com/46898d23cdf5f209e6e40a1b8509682919efa4d5/chrome/browser/ui/passwords/password_generation_popup_controller_impl.cc
[modify] https://crrev.com/46898d23cdf5f209e6e40a1b8509682919efa4d5/chrome/browser/ui/passwords/password_generation_popup_view.h
[modify] https://crrev.com/46898d23cdf5f209e6e40a1b8509682919efa4d5/chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc
[modify] https://crrev.com/46898d23cdf5f209e6e40a1b8509682919efa4d5/chrome/browser/ui/views/passwords/password_generation_popup_view_views.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2944cf12a76cd381b69d134ea94b3feb1883d77f

commit 2944cf12a76cd381b69d134ea94b3feb1883d77f
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Jun 21 12:17:57 2018

Move PresaveGeneratedPassword from PasswordManagerDriver to PasswordManagerClient.

The UI needs the new password value. Thus, the method is needed in ChromePasswordManagerClient.
Also it doesn't seem right to scatter all the generation events across two interfaces while autofill::mojom::PasswordManagerClient solely concentrates on generation.

Bug:  851021 
Change-Id: I6a6dcc59a934202bb0e2e336ff1324da131c6dfd
Reviewed-on: https://chromium-review.googlesource.com/1104339
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569224}
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/chrome/renderer/autofill/fake_content_password_manager_driver.cc
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/chrome/renderer/autofill/fake_content_password_manager_driver.h
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/chrome/renderer/autofill/fake_password_manager_client.h
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/components/autofill/content/common/autofill_driver.mojom
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/components/password_manager/content/browser/content_password_manager_driver.cc
[modify] https://crrev.com/2944cf12a76cd381b69d134ea94b3feb1883d77f/components/password_manager/content/browser/content_password_manager_driver.h

+maxwalker, nepper: Note that this UI works better in English sentence order (PTVTR... is the object which comes after the verb) than in German sentence order, where this would probably be translated to "Password gespeichert" "PTVTR..." Are we fine with that?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49d5c30b70308ebf22fe9c14a933840c35d3f189

commit 49d5c30b70308ebf22fe9c14a933840c35d3f189
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Jun 22 13:54:46 2018

Implement the password generation prompt for the editing state.

The user gets a feedback that the password is saved during editing.

TBR=rouslan@chromium.org

Bug:  851021 
Change-Id: I2d254b4b366d67fee5283898b769362902008b15
Reviewed-on: https://chromium-review.googlesource.com/1110229
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569597}
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/app/generated_resources.grd
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/password_manager/password_generation_interactive_uitest.cc
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/android/autofill/password_generation_popup_view_android.h
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/passwords/password_generation_popup_controller.cc
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/passwords/password_generation_popup_controller.h
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/passwords/password_generation_popup_controller_impl.cc
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/passwords/password_generation_popup_controller_impl.h
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/passwords/password_generation_popup_observer.h
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/passwords/password_generation_popup_view.cc
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/passwords/password_generation_popup_view.h
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/passwords/password_generation_popup_view_browsertest.cc
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/passwords/password_generation_popup_view_tester.h
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/views/passwords/password_generation_popup_view_tester_views.cc
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/views/passwords/password_generation_popup_view_tester_views.h
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/chrome/browser/ui/views/passwords/password_generation_popup_view_views.h
[modify] https://crrev.com/49d5c30b70308ebf22fe9c14a933840c35d3f189/components/autofill/content/renderer/password_generation_agent.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb4cfad260da0f59e4498815d26182f771a20070

commit cb4cfad260da0f59e4498815d26182f771a20070
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Jun 22 16:40:50 2018

Add strings for the password drop-down needed for MD2.

Bug:  851021 
Change-Id: Ia69cea98783f2b077b628e0975e22913f3e17d61
Reviewed-on: https://chromium-review.googlesource.com/1112004
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569655}
[modify] https://crrev.com/cb4cfad260da0f59e4498815d26182f771a20070/components/password_manager_strings.grdp

Different word order across translations seems fine to me (quick preview: https://screenshot.googleplex.com/mmfvJHaqsQe.png).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96b7e77a9d48258ec6f365d019d91bd188a8870c

commit 96b7e77a9d48258ec6f365d019d91bd188a8870c
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Wed Jul 04 10:47:26 2018

Add "Manage passwords" to the passwords drop-down.

- "Use password for:" title isn't used anymore in the password dropdown.
- The dropdown should have a footer "Manage passwords" leading to the settings.

Bug:  851021 
Change-Id: I24696fffa7c2db7bc21c6b9ec7fcb3aa9c277429
Reviewed-on: https://chromium-review.googlesource.com/1125061
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572533}
[modify] https://crrev.com/96b7e77a9d48258ec6f365d019d91bd188a8870c/chrome/browser/about_flags.cc
[modify] https://crrev.com/96b7e77a9d48258ec6f365d019d91bd188a8870c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/96b7e77a9d48258ec6f365d019d91bd188a8870c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/96b7e77a9d48258ec6f365d019d91bd188a8870c/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/96b7e77a9d48258ec6f365d019d91bd188a8870c/components/autofill_strings.grdp
[modify] https://crrev.com/96b7e77a9d48258ec6f365d019d91bd188a8870c/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/96b7e77a9d48258ec6f365d019d91bd188a8870c/components/password_manager/core/browser/password_autofill_manager_unittest.cc
[modify] https://crrev.com/96b7e77a9d48258ec6f365d019d91bd188a8870c/components/password_manager/core/common/password_manager_features.cc
[modify] https://crrev.com/96b7e77a9d48258ec6f365d019d91bd188a8870c/components/password_manager/core/common/password_manager_features.h

The drop-downs are temporarily ugly on Linux only.

Deleted: Screenshot from 2018-07-12 19-08-56.png 14.2 KB

	Screenshot from 2018-07-12 19-08-56.png 14.2 KB View Download

Deleted: Screenshot from 2018-07-12 19-10-08.png 12.6 KB

	Screenshot from 2018-07-12 19-10-08.png 12.6 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7a215a8798588119e928bccbdf62366c82ab8dc

commit e7a215a8798588119e928bccbdf62366c82ab8dc
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Jul 13 11:00:24 2018

Display masked password in the autofill drop-down.

The masked password is displayed for non-PSL and non-Android credentials now.
Later when the drop-down supports a bottom label, it'll be shown for all.

Bug:  851021 
Change-Id: I491e7c24a58311c1250e8e89cddb9ccae95a9296
Reviewed-on: https://chromium-review.googlesource.com/1135325
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574879}
[modify] https://crrev.com/e7a215a8798588119e928bccbdf62366c82ab8dc/components/password_manager/core/browser/password_autofill_manager.cc

Shadows

Deleted: Screenshot from 2018-07-13 17-03-26.png 10.5 KB

	Screenshot from 2018-07-13 17-03-26.png 10.5 KB View Download

Deleted: Screenshot from 2018-07-13 17-06-58.png 14.5 KB

	Screenshot from 2018-07-13 17-06-58.png 14.5 KB View Download

Deleted: Screenshot from 2018-07-13 17-07-08.png 16.5 KB

	Screenshot from 2018-07-13 17-07-08.png 16.5 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa89015c94aa96aed4bcf1452b8c808de3ab627c

commit fa89015c94aa96aed4bcf1452b8c808de3ab627c
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Jul 17 17:26:20 2018

Add a shadow to the password generation drop-down.

The CL moves as much as possible from AutofillPopupViewNativeViews to
AutofillPopupBaseView (parent for the generation drop-down). At the same time
AutofillPopupViewViews implements the stuff specific for it and irrelevant for
the new views prompts. AutofillPopupViewViews is gonna be deleted soon anyway.

Bug:  851021 
Change-Id: I4711c29220c841356e5a7d8adca0cd5c222c8cde
Reviewed-on: https://chromium-review.googlesource.com/1136633
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575698}
[modify] https://crrev.com/fa89015c94aa96aed4bcf1452b8c808de3ab627c/chrome/browser/ui/passwords/password_generation_popup_controller_impl.cc
[modify] https://crrev.com/fa89015c94aa96aed4bcf1452b8c808de3ab627c/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
[modify] https://crrev.com/fa89015c94aa96aed4bcf1452b8c808de3ab627c/chrome/browser/ui/views/autofill/autofill_popup_base_view.h
[modify] https://crrev.com/fa89015c94aa96aed4bcf1452b8c808de3ab627c/chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc
[modify] https://crrev.com/fa89015c94aa96aed4bcf1452b8c808de3ab627c/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/fa89015c94aa96aed4bcf1452b8c808de3ab627c/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h
[modify] https://crrev.com/fa89015c94aa96aed4bcf1452b8c808de3ab627c/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
[modify] https://crrev.com/fa89015c94aa96aed4bcf1452b8c808de3ab627c/chrome/browser/ui/views/autofill/autofill_popup_view_views.h