New issue
Advanced search Search tips

Issue 851018 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
xixuan@chromium.org
pprabhu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

skylab_inventory: change required fields to optional.

Project Member Reported by nxia@chromium.org, Jun 8 2018 
https://engdoc.corp.google.com/eng/doc/devguide/proto/index.md?cl=head#dont-add-a-required-field

I see a lot required fields in the skylab_inventory proto. It takes efforts to change them to optional before really launching them, but it should help in the long-term as it may cause problems in the future.

Comment 1 by pprabhu@chromium.org, Jun 8 2018 

This was actually an intentional choice. Not having required fields in an API is good for API maintanability. But for on-disk data, it's OK to have required fields, because we can change the data and the proto at the same time.

I decided that it is in fact good to have these fields to get some data integrity guarantees for free.

Comment 2 by ayatane@chromium.org, Jul 24

Status: Available (was: Untriaged)
"because we can change the data and the proto at the same time"

Really?  The data and proto are in separate repos, and you'd have drain all running processes using the old proto
►

Sign in to add a comment