Views-login should run existing oobe/login browser-tests The existing tests assume that login is webui. It will require some refactoring to get these tests running with views login.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03ca85bdf40eab251f03ebff0e3ae066882a95ac commit 03ca85bdf40eab251f03ebff0e3ae066882a95ac Author: Jacob Dufault <jdufault@google.com> Date: Thu Jun 14 15:30:16 2018 cros: Remove OobeBaseTest webui login dependency. Move ShowSigninScreenForTest from SigninScreenHandler to GaiaView, which is the gaia/login-specific interface. Bug: 851012 Change-Id: If01d1052341b670ca30ffece6bbbc00e981bc61a Reviewed-on: https://chromium-review.googlesource.com/1093376 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#567277} [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/active_directory_login_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/app_launch_controller.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/login_utils_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/oobe_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/reset_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/saml/saml_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/screens/gaia_view.h [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/signin/device_id_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/signin/oauth2_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/test/oobe_base_test.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/test/oobe_base_test.h [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/ui/login_display_mojo.h [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/ui/login_display_webui.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/ui/login_display_webui.h [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/login/webview_login_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/policy/blocking_login_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/policy/login_policy_test_base.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/policy/site_isolation_flag_handling_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/03ca85bdf40eab251f03ebff0e3ae066882a95ac/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f596585a382b7d234474019689588e1919d569f commit 7f596585a382b7d234474019689588e1919d569f Author: Jacob Dufault <jdufault@google.com> Date: Mon Jun 18 18:28:06 2018 cros: Make LoginDisplayHost own LoginDisplay Instead of this ownership model LoginDisplayHost owns ExistingUserController owns LoginDisplay LoginDisplayHost owns WebUIScreenLocker owns LoginDisplay switch to LoginDisplayHost owns ExistingUserController, LoginDisplay This makes it clear that the LoginDisplay instance has one owner, and that it shares the same lifetime as LoginDisplayHost. Bug: 851012 Change-Id: I80cb56d8fc244ce5331046ba31defba4cd77c45f Reviewed-on: https://chromium-review.googlesource.com/1093741 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#568084} [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/existing_user_controller.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/existing_user_controller.h [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/lock/webui_screen_locker.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/oobe_browsertest.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/screens/user_selection_screen.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/screens/user_selection_screen.h [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/signin_screen_controller.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/signin_screen_controller.h [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/fake_login_display_host.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/fake_login_display_host.h [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/login_display.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/login_display.h [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/login_display_host.h [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/login_display_host_mojo.h [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/login_display_host_webui.h [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/login_display_mojo.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/login_display_mojo.h [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/login_display_webui.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/login_display_webui.h [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/mock_login_display.cc [modify] https://crrev.com/7f596585a382b7d234474019689588e1919d569f/chrome/browser/chromeos/login/ui/mock_login_display_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc2e9699795a3e62edc16160e5fb171a58454522 commit dc2e9699795a3e62edc16160e5fb171a58454522 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Mon Jun 18 21:57:02 2018 Revert "cros: Make LoginDisplayHost own LoginDisplay" This reverts commit 7f596585a382b7d234474019689588e1919d569f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 568084 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdmNTk2NTg1YTM4MmI3ZDIzNDQ3NDAxOTY4OTU4OGUxOTE5ZDU2OWYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27973 Sample Failed Step: unit_tests Original change's description: > cros: Make LoginDisplayHost own LoginDisplay > > Instead of this ownership model > > LoginDisplayHost owns ExistingUserController owns LoginDisplay > LoginDisplayHost owns WebUIScreenLocker owns LoginDisplay > > switch to > > LoginDisplayHost owns ExistingUserController, LoginDisplay > > This makes it clear that the LoginDisplay instance has one owner, and > that it shares the same lifetime as LoginDisplayHost. > > Bug: 851012 > Change-Id: I80cb56d8fc244ce5331046ba31defba4cd77c45f > Reviewed-on: https://chromium-review.googlesource.com/1093741 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568084} Change-Id: I144f702fc39267db2ef830b276ca3c77c2c3c262 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851012 Reviewed-on: https://chromium-review.googlesource.com/1105240 Cr-Commit-Position: refs/heads/master@{#568182} [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/existing_user_controller.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/existing_user_controller.h [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/lock/webui_screen_locker.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/oobe_browsertest.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/screens/user_selection_screen.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/screens/user_selection_screen.h [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/signin_screen_controller.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/signin_screen_controller.h [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/fake_login_display_host.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/fake_login_display_host.h [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/login_display.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/login_display.h [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/login_display_host.h [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/login_display_host_mojo.h [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/login_display_host_webui.h [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/login_display_mojo.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/login_display_mojo.h [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/login_display_webui.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/login_display_webui.h [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/mock_login_display.cc [modify] https://crrev.com/dc2e9699795a3e62edc16160e5fb171a58454522/chrome/browser/chromeos/login/ui/mock_login_display_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cfbafc79b90602c341ee6a7e4ef8e9723341284 commit 7cfbafc79b90602c341ee6a7e4ef8e9723341284 Author: Jacob Dufault <jdufault@google.com> Date: Tue Jun 19 22:26:01 2018 Reland cros: Make LoginDisplayHost own LoginDisplay This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1093741, which was reverted in https://chromium-review.googlesource.com/c/1105240/ Bug: 851012 Change-Id: Icc587ff829e187b2eae7456aec227f5d66beb1ee Reviewed-on: https://chromium-review.googlesource.com/1106641 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#568619} [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/existing_user_controller.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/existing_user_controller.h [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/lock/webui_screen_locker.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/oobe_browsertest.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/screens/user_selection_screen.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/screens/user_selection_screen.h [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/signin_screen_controller.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/signin_screen_controller.h [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/fake_login_display_host.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/fake_login_display_host.h [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display.h [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display_host.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display_host.h [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display_host_mojo.h [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display_host_webui.h [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display_mojo.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display_mojo.h [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display_webui.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/login_display_webui.h [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/mock_login_display.cc [modify] https://crrev.com/7cfbafc79b90602c341ee6a7e4ef8e9723341284/chrome/browser/chromeos/login/ui/mock_login_display_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb9aed044e94bc2f95bf2b2bed9a90b882139520 commit cb9aed044e94bc2f95bf2b2bed9a90b882139520 Author: Jacob Dufault <jdufault@google.com> Date: Thu Jun 21 17:10:24 2018 cros: Add GetOobeWebContents to LoginDisplayHost Right now GetWebContents is done by first fetching GetWebUILoginView, which is not available in LoginDisplayHostMojo; however, LoginDisplayHostMojo does have an associated WebContents instance when it is hosting oobe in a dialog, so return that. Bug: 851012 Change-Id: Icb1f296ce4513369ecae424c717f9991baa142c0 Reviewed-on: https://chromium-review.googlesource.com/1100384 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#569310} [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/login_manager_test.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/screens/error_screen.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/test/oobe_base_test.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/fake_login_display_host.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/fake_login_display_host.h [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/login_display_host.h [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/login_display_host_mojo.h [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/login_display_host_webui.h [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/mock_login_display_host.h [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.h [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/ui/simple_web_view_dialog_browsertest.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/policy/device_local_account_browsertest.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/shutdown_policy_browsertest.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/chromeos/system/device_disabling_browsertest.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/media/chromeos_login_media_access_handler.cc [modify] https://crrev.com/cb9aed044e94bc2f95bf2b2bed9a90b882139520/chrome/browser/ui/views/select_file_dialog_extension.cc
The switch user UI has been crashing due to https://chromium-review.googlesource.com/c/chromium/src/+/1106641 However I cannot revert it without reverting the other CL. Is there a fix for this crash?
Re #6: That should be fixed now, see issue 855650 .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/073f7a000d86b4a74592600566bff2b1738983c2 commit 073f7a000d86b4a74592600566bff2b1738983c2 Author: Jacob Dufault <jdufault@google.com> Date: Mon Jul 16 21:38:51 2018 cros: Do not store unowned instances of WizardController. LoginDisplayHost owns WizardController, this makes it more obvious. Bug: 851012 Change-Id: Ideb743276be051024b237cd04e68838a02a85ef7 Reviewed-on: https://chromium-review.googlesource.com/1124944 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575433} [modify] https://crrev.com/073f7a000d86b4a74592600566bff2b1738983c2/chrome/browser/chromeos/login/screen_manager.cc [modify] https://crrev.com/073f7a000d86b4a74592600566bff2b1738983c2/chrome/browser/chromeos/login/screen_manager.h [modify] https://crrev.com/073f7a000d86b4a74592600566bff2b1738983c2/chrome/browser/chromeos/login/ui/fake_login_display_host.cc [modify] https://crrev.com/073f7a000d86b4a74592600566bff2b1738983c2/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc [modify] https://crrev.com/073f7a000d86b4a74592600566bff2b1738983c2/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/073f7a000d86b4a74592600566bff2b1738983c2/chrome/browser/chromeos/login/ui/login_display_host_webui.h [modify] https://crrev.com/073f7a000d86b4a74592600566bff2b1738983c2/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/073f7a000d86b4a74592600566bff2b1738983c2/chrome/browser/chromeos/login/wizard_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ef3aab0d47e721493ab466d44fcf587197187b9 commit 0ef3aab0d47e721493ab466d44fcf587197187b9 Author: Jacob Dufault <jdufault@google.com> Date: Tue Jul 17 15:54:50 2018 cros: Do not store unowned ExistingUserController instances. LoginDisplayHost owns ExistingUserController, this makes it more obvious and also simplifies instance creation. Bug: 851012 Change-Id: I8dc24c743aeb71070801009b2b4ec6472ee16409 Reviewed-on: https://chromium-review.googlesource.com/1125029 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#575655} [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/existing_user_controller.cc [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/existing_user_controller.h [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/ui/fake_login_display_host.cc [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/ui/fake_login_display_host.h [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/ui/login_display_host.h [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/ui/login_display_host_common.cc [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/ui/login_display_host_mojo.h [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/ui/login_display_host_webui.h [modify] https://crrev.com/0ef3aab0d47e721493ab466d44fcf587197187b9/chrome/browser/chromeos/login/ui/mock_login_display_host.h
Comment 1 by bugdroid1@chromium.org
, Jun 14 2018