New issue
Advanced search Search tips

Issue 851009 link

Starred by 1 user
Status: Fixed
Owner:
ftirelo@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Margins and heights in the new dropdown

Project Member Reported by ftirelo@chromium.org, Jun 8 2018 
Feedback from UI review:

1. Compensate for the corner radius in the left and the right margins: 8 today, should be 12 (additional 4 for the corner radius).

2. The last footer double counts the corner radius (it should be 36 + 4, but it's actually 36 + 2 * 4). Needs to be fixed.

3. All footer items should have the same height (today, we only compensate for the last item).
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d69ec1075df40982aff72fee93a36d34011ef46

commit 9d69ec1075df40982aff72fee93a36d34011ef46
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Wed Jun 13 19:16:57 2018

[af] Fix footer height and horizontal margins for the new dropdown

This addresses the following feedback provided during UI review:
 - Footer item height should be 40 = 36 (suggestion height) +
   4 (compensation for corner radius); in the current implementation,
   this is 44 (36 + 2 * 4).
 - All footer items should have the same value; in the current
   implementation, the last one is taller than the others.
 - Left and right padding should also compensate for the corner
   radius; it's 8 today, should be 8 + 4.

Bug:  851009 
Change-Id: I0dad1c8bbbe97dce9341900d25af44df9efbde11
Reviewed-on: https://chromium-review.googlesource.com/1091158
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566943}
[modify] https://crrev.com/9d69ec1075df40982aff72fee93a36d34011ef46/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc

Comment 2 by ftirelo@chromium.org, Jun 19 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment