Low end devices should not reuse logs |
||
Issue descriptionChrome Version: M67 OS: Android, Chromecast Low end devices (defined as devices with limited RAM) should not reuse the leveldb manifest. Doing so causes the log (current write buffer) to be reloaded from disk when the database is opened. Manifest is good for reducing database open times, but bad for memory as it uses more RAM. Low end devices typically have solid state storage so disabling manifest reuse should have a limited impact.
,
Jun 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9be71f536f8f336d9a330b6b27f522ab7e07cffc commit 9be71f536f8f336d9a330b6b27f522ab7e07cffc Author: Chris Mumford <cmumford@chromium.org> Date: Sat Jun 09 01:11:37 2018 leveldb: Do not reuse manifest on low end devices. Manifest reuse is beneficial as it reduced database open time, but it penalizes devices with limited RAM because it defers the database compaction from db open to when the write log becomes full, which defaults to 4MB. Bug: 851006 Change-Id: If4ab6dc683cb745234298545ad9d92cb55c00769 Reviewed-on: https://chromium-review.googlesource.com/1093268 Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#565810} [modify] https://crrev.com/9be71f536f8f336d9a330b6b27f522ab7e07cffc/third_party/leveldatabase/env_chromium.cc
,
Jun 21 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by cmumford@chromium.org
, Jun 8 2018