New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 851004 link

Starred by 1 user
Status: Fixed
Owner:
█ hongjunchoi@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
█ tengs@chromium.org
kenrb@chromium.org
martinkr@google.com
engedy@chromium.org
ssoneff@google.com
kpaulhamus@chromium.org
jdoerrie@chromium.org
mknowles@chromium.org
Components:
EstimatedDays: 1
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fix Cable advertisment format in accordance to the new spec

Project Member Reported by hongjunchoi@chromium.org, Jun 8 2018 
Authenticator and client EID are now located from the second byte.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2ffb85b51ee471ed2e3c070c391fe5e212f880b

commit d2ffb85b51ee471ed2e3c070c391fe5e212f880b
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Wed Jun 13 02:40:22 2018

Fix Cable advertisement packet format

With new update on the Cable spec, the ordering of elements in
client/authenticator advertisement packets has changed. Update
FidoCableDiscovery accordingly.

Bug:  851004 
Change-Id: Ib40ec3af1e10490ea80e8934403cd1a381319f83
Reviewed-on: https://chromium-review.googlesource.com/1093256
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566697}
[modify] https://crrev.com/d2ffb85b51ee471ed2e3c070c391fe5e212f880b/device/fido/fido_cable_discovery.cc
[modify] https://crrev.com/d2ffb85b51ee471ed2e3c070c391fe5e212f880b/device/fido/fido_cable_discovery_unittest.cc

Comment 2 by hongjunchoi@chromium.org, Jun 21 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment