New issue
Advanced search Search tips

Issue 851002 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

input.properties is incomplete

Project Member Reported by no...@chromium.org, Jun 8 2018

Issue description

input.properties currently contains only properties defined in parameters_json, i.e. specified in the build scheduling request. That list of properties is incomplete because some input properties are specified in the config. input.properties should include them. The property merging happens in https://chromium.googlesource.com/infra/infra/+/8f241688eaf8a03844811e4909ba7389da064bd2/appengine/cr-buildbucket/swarming/swarming.py#446
 

Comment 1 by no...@chromium.org, Jun 12 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/77b4b72169488f7d322495bc75093683cafb4e6b

commit 77b4b72169488f7d322495bc75093683cafb4e6b
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Jun 13 22:47:00 2018

[buildbucket] Add model.Build.parameters_actual

When a build is scheduled, its actual parameters/input is computed from its
parameters and the server state. The resulting parameters are used to compute
the swarming task definition, including input properties.
Users of build API and BQ need to build parameters/input that was actually used,
regardless of whether it came from a build or server state.

Store the actual/computed parameters in new model.Build.properties_actual
datastore property.

Update v2/builds.py to use it.

Bug:  851002 
Change-Id: I0d4895e4c2004b0fef3ffac28f8b82da4bb8a69b
Reviewed-on: https://chromium-review.googlesource.com/1098231
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/77b4b72169488f7d322495bc75093683cafb4e6b/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/77b4b72169488f7d322495bc75093683cafb4e6b/appengine/cr-buildbucket/swarming/test/swarming_test.py
[modify] https://crrev.com/77b4b72169488f7d322495bc75093683cafb4e6b/appengine/cr-buildbucket/v2/test/builds_test.py
[modify] https://crrev.com/77b4b72169488f7d322495bc75093683cafb4e6b/appengine/cr-buildbucket/model.py
[modify] https://crrev.com/77b4b72169488f7d322495bc75093683cafb4e6b/appengine/cr-buildbucket/v2/builds.py

Comment 3 by no...@chromium.org, Jun 14 2018

Status: Fixed (was: Started)

Sign in to add a comment