New issue
Advanced search Search tips

Issue 850997 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 598069
issue 612328



Sign in to add a comment

Move //content/renderer/device_sensors to blink

Project Member Reported by oksamyt@chromium.org, Jun 8 2018

Issue description

The files from //content/renderer/device_sensors need to be moved to //third_party/blink/renderer/modules/device_orientation. This also covers removing the connection between PlatformEventObserver and DeviceSensorEventPump and moving the creation of Device*EventPump instances to appropriate Device*Dispatchers in device_orientation.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf8cb38bf49d190ab13fbf352fedd2d8c8da476a

commit bf8cb38bf49d190ab13fbf352fedd2d8c8da476a
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Wed Jun 13 03:24:51 2018

Decouple DeviceSensorEventPump from PlatformEventObserver

This changes prepares DeviceSensorEventPump and its subclasses for
the move to blink by removing the inheritance of DeviceSensorEventPump
from PlatformEventObserver and moving listener-related logic to
DeviceSensorEventPump. Since Device*EventPump instances can no longer be
stored in RendererBlinkPlatformImpl::platform_event_observers_, separate
variables have been added temporarily that will be moved to appropriate
Device*Dispatcher classes along with the logic when Device*EventPump
classes are moved to blink.

Bug:  850997 
Change-Id: Iedf23e368adb9180091d094146306330987bcf9c
Reviewed-on: https://chromium-review.googlesource.com/1091275
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566706}
[modify] https://crrev.com/bf8cb38bf49d190ab13fbf352fedd2d8c8da476a/content/renderer/device_sensors/device_motion_event_pump.cc
[modify] https://crrev.com/bf8cb38bf49d190ab13fbf352fedd2d8c8da476a/content/renderer/device_sensors/device_orientation_event_pump.cc
[modify] https://crrev.com/bf8cb38bf49d190ab13fbf352fedd2d8c8da476a/content/renderer/device_sensors/device_sensor_event_pump.h
[modify] https://crrev.com/bf8cb38bf49d190ab13fbf352fedd2d8c8da476a/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/bf8cb38bf49d190ab13fbf352fedd2d8c8da476a/content/renderer/renderer_blink_platform_impl.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4540438b4c21f8b23aa2b8dc8c333d3876c4f356

commit 4540438b4c21f8b23aa2b8dc8c333d3876c4f356
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Fri Jun 22 16:47:04 2018

device_sensors in content -> device_orientation in blink

This change moves Device*EventPump classes and appropriate unit tests to
third_party/blink/renderer/modules/device_orientation. Their instances
are now created in relevant Device*Dispatcher methods with a LocalFrame*
passed to be used for Mojo interface creation.
Some updates were required to satisfy blink dependencies limitations
and for consistency:
- base::RepeatingTimer was replaced by TaskRunnerTimer which has to be
initialized with a base::SingleThreadTaskRunner, so the constructors
were extended with a new parameter;
- base::Time -> WTF::Time;
- base::BindOnce -> WTF::Bind, base::Unretained -> WTF::Unretained;
- device::mojom:: -> device::mojom::blink::;
- in the unit tests, device::mojom::SensorProviderPtrInfo is wrapped
into device::mojom::blink::SensorProviderPtr since FakeSensorProvider
implements device::mojom::SensorProvider

Bug:  850997 
Change-Id: I440b9379f50ab42fc50b9d92490c2615ef8c3cc9
Reviewed-on: https://chromium-review.googlesource.com/1099492
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569659}
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/content/renderer/BUILD.gn
[delete] https://crrev.com/5c603095d05fbe072479d6e72db9df4ca3bbdafa/content/renderer/device_sensors/OWNERS
[delete] https://crrev.com/5c603095d05fbe072479d6e72db9df4ca3bbdafa/content/renderer/device_sensors/device_motion_event_pump.h
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/content/test/BUILD.gn
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/BUILD.gn
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/DEPS
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/device_motion_dispatcher.cc
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/device_motion_dispatcher.h
[rename] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump.cc
[add] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump.h
[rename] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump_unittest.cc
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/device_orientation_dispatcher.cc
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/device_orientation_dispatcher.h
[rename] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump.cc
[rename] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump.h
[rename] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump_unittest.cc
[rename] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/renderer/modules/device_orientation/device_sensor_event_pump.h
[modify] https://crrev.com/4540438b4c21f8b23aa2b8dc8c333d3876c4f356/third_party/blink/tools/audit_non_blink_usage.py

Status: Fixed (was: Started)

Sign in to add a comment