New issue
Advanced search Search tips

Issue 850988 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Don't dismiss page capping infobar on same page navigation

Project Member Reported by ryansturm@chromium.org, Jun 8 2018

Issue description

The infobar for page load capping should not be dismissed when a user does a same page navigation (e.g., and anchor navigation).


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9437ed478c185173bc3fb91bfb44eca62bdbd050

commit 9437ed478c185173bc3fb91bfb44eca62bdbd050
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Fri Jun 08 20:12:08 2018

Matching PLM behavior in the infobar expiration logic

PLM tracks pages as new page main frame navigations, the page load
capping infobar should match this behavior exactly to keep consistency
between the two approaches. This may allow better understanding of what
a page load actually is when the infobar is showing.

Bug:  850988 
Change-Id: I339f9000088731d807b4db973220c805cf4d3e3b
Reviewed-on: https://chromium-review.googlesource.com/1093191
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565725}
[modify] https://crrev.com/9437ed478c185173bc3fb91bfb44eca62bdbd050/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_browsertest.cc
[modify] https://crrev.com/9437ed478c185173bc3fb91bfb44eca62bdbd050/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_infobar_delegate.cc

Status: Fixed (was: Started)

Sign in to add a comment